1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 16:53:34 +00:00
Commit Graph

11638 Commits

Author SHA1 Message Date
Oscar Hinton
b6117d6801 Re-add native dependencies to src/package.json (#1233) 2022-01-13 10:46:33 +01:00
Thomas Rittson
b962af303a Fix always logging out instead of lock (#444) 2022-01-13 17:35:48 +10:00
Vince Grassia
3292d119fe Update Version Bump action (#1388) 2022-01-12 16:06:50 -05:00
Thomas Rittson
ddcfe23367 Make lowdbStorageService wait until initialised (#605)
* Make lowdbStorageService wait until initialised

* Fix prettier
2022-01-13 06:18:54 +10:00
Addison Beck
653ff8f45f [Bug] VaultTimeout incorrectly defaults to "Never" (#1230)
* [Bug] VaultTimeout incorrectly defaults to "Never"

The default desktop vault timeout value is "On Restart", but there is no default set for this in the state service and account model.
This commit extends the StateService and Account model to consider the special vault timeout default requirements needed for desktop.

* [style] Lint fixes

* [chore] Update jslib
2022-01-12 11:37:23 -05:00
Addison Beck
957e010036 [bug] Ensure neverLock vaults can be manually locked (#607)
The client side storage restructuring work incorrectly checks if a vault has ever been unlocked to determine neverLock scenerios, but production does the opposite.
This creates an inability to never manually lock neverLock vaults.
This commit sets that condition back to the way it was.
2022-01-12 11:32:45 -05:00
Daniel James Smith
71c2fee574 Close opened AccountSwitcher dropdown (#1228)
When a user clicks outside of an opened account switching dropdown, it should close automatically when clicking outside of the dropdown.
2022-01-12 17:20:19 +01:00
Daniel James Smith
d885e3296b Do not switch accounts if it is already the active account (#1229) 2022-01-12 17:20:07 +01:00
Addison Beck
c7ccb997bd [bug] Use the correct login url in lock guard (#606) 2022-01-12 10:15:39 -05:00
Addison Beck
f32b917a9f [Account Switching] Misc Bug Fixes and Refactors (#1223)
* [bug] Pull serverUrl directly from stateService for the account switcher

Create a small extended Account model for handling the switchers server url, and pull environment urls from disk where they actually live

* [refactor] Add a message handler for switching accounts

* This allows for logic reuse between manually switching accounts and automatically switching accounts on login
* This commit also adds a loading spinner to app root while syncing after a switch

* [bug] Remove vertical scrollbar

* An old styling fix to add extra height and padding seems to be now creating an unecassary scroll bar. It is likely that since making more use of flexbox for our containers that this issue has been resolved without the manually added extra hight & padding

* [refactor] Turn down activity monitoring

Saving last activity is a disk call, and we currently do this a lot more than is necassary. For example:
* We track mousedown & click, which is redundant
* We track every mouse movement regardless of if an action is taken. This seems inappropriate for use in locking behavior.

* [bug] Address potential race condition when locking

Sometimes when swapping between an unlocked account and a locked account a race condition occurs that swaps the user but doesn't redirect to the lock screen
This commit just adds some awaits and restructures lock order of operations to be more in line with other message handlers

* [refactor] Change click event to mousedown event for the account switcher

This is simply a little snappier, and ensures we stay ahead of change detection and don't get stuck not properly interpreting the action

* [chore] Update jslib

* [chore] Linter fixes

* [chore] Linter fixes

* [chore] Update jslib

* [chore] Update jslib
2022-01-12 09:23:00 -05:00
Daniel James Smith
2b64ec5375 Fix null ref when building/updating the MenuBar (#1227) 2022-01-12 15:19:18 +01:00
Robyn MacCallum
172392ff3b [Account Switching] Fix options dropdowns being empty (#603)
* Fix dropdowns initially being empty

* run prettier

* Remove default nulls for locale and theme
2022-01-12 09:11:25 -05:00
Ivan Kovnatsky
da640794c4 Add git credential helper example (#388) 2022-01-12 04:54:33 -08:00
Danielle Flinn
42d8f99249 aligned dark theme variables to the new WV dark theme (#2241)
* aligned dark theme variables to the new WV dark theme

* Update plugins.scss

updated toast close button color

* Run prettier on plugins.scss

Co-authored-by: Daniel James Smith <djsmith@web.de>
2022-01-12 13:12:30 +01:00
Oscar Hinton
f6f0bd2bfb Remove webpack-node-externals and use asarUnpack (#1221) 2022-01-12 11:32:02 +01:00
Christian Oliff
b8de92435b Add Inputmode for tel and email (identities) (#1384) 2022-01-12 10:07:56 +01:00
Thomas Rittson
2341b1907a Fix "no amr found" error in bwdc cli (#589)
* Fix amr error when authing with org api key

* Fix linting

* Return null instead of error if no amr

* Return false instead of null
2022-01-11 13:22:52 +10:00
Oscar Hinton
23a7072341 Disable spellchecker (#1225) 2022-01-10 18:27:14 +01:00
Addison Beck
4074c2a45f [Bug] [Account Switching] Ensure EnvironmentUrls Pull From The Correction Location On Account Add (#602)
* [bug] Fully initilize environmentUrls default value

We want the full environmentUrls object to be saved to storage with null values as an indicator of using BW cloud.
Currently the initilization behavior creates an empty object instead. Setting property values returns the correct behavior.

* [bug] Return the correct environmentUrls when scaffloging a new account

To allow for setting environmentUrls before an account is created we save that value as a global setting and then apply it to any newly authed accounts.
There is a bug that will instead save the urls used by the previous logged in account, making account switching with multiple servers cause errors.

This commit resolves this by specifically getting environementUrls from global state when creating a new account
2022-01-10 12:25:38 -05:00
Oscar Hinton
def3c47a1e Disable spell checking (#601) 2022-01-10 16:38:10 +01:00
Oscar Hinton
fd1d512a0f Run prettier on #1232 (#1383) 2022-01-10 14:50:54 +01:00
Daniel James Smith
14b8903d9a Fix items not opening when they had a password reprompt set (#1381) 2022-01-10 14:12:35 +01:00
Simon Legner
45284eefb3 Compress images u2fkey/yubikey using avif/webp (#1232)
Co-authored-by: Hinton <oscar@oscarhinton.com>
2022-01-10 12:37:21 +01:00
Daniel James Smith
f26bfb5859 Add ts files to prettier (#433)
* Add ts files to prettier

* Add all filestypes to prettier and ignore via .prettierignore

* Add --ignore-unknown to prettier
2022-01-07 19:14:02 +01:00
Daniel James Smith
d64b00977c Fix menu separators (#1220)
* Fix separators appearing when they shouldn't

* Use const instead of let
2022-01-07 15:54:35 +01:00
Addison Beck
57d60bdfa6 Misc Account Switching Fixes & Refactors (#600)
* [refactor] Restructure EnvironmentUrls in state

* Patch up (add missing fields) and more extensivly use the EnvironmentUrls class instead of passing around an any
* Add environmentUrls to the AccountSettings model in addition to GlobalState for use in both scopes
* Move EnvironmentUrls initialization to the model level and out of StateSerice
* Adjust the StateMigrationService to account for these changes

* [refactor] Improve order of operations for LockGuardService

We currently jump through a bunch of hoops to verify users can access the Lock page, like checking authentication first.
If a user is not authenticated, they are not locked, so we can improve performance for the happy path of this serivice by checking isLocked first and using isAuthenticated to deviate from the normal flow if needed.

* [bug] Subscribe to State.accounts in EnvironmentService and set urls accordingly

The EnvironmentService has no context for account changes currently and does not update actively used urls based on active account.
This commit addresses this issue by subscribing to State.accounts and resetting the service's urls on account change.

* [bug] Clear AccessToken from State on clean

In order for logout flows to function as expected we need to deauthenticate users when cleaning up state before checking for the next active user
Otherwise the service will continue to think the user being logged out is active

* [refactor] Stop pushing accounts when modifying disk state

There is no reason to push new accounts to subscribers when updating disk state.
Subscribers recieve a copy of in memory state, so changes to disk will not be refelected and have to be fetched seperatly from the service.
Pushing when saving disk state is just creating an unecassary performance burden.

* [refactor] Default to in memory active user if availible, even when accessing disk state

Sometimes we need to pull activeUserId from storage to access a bit of data, like on initial boot, but most of the time this isn't necassary.
Since we pull this userId a lot, checking disk each time is a performance burden. Defaulting to the in memory user ID if avaible helps alleviate this.

* [style] Ran prettier

* [style] Change a let to a const
2022-01-07 09:30:54 -05:00
Daniel James Smith
49f6cfab7f Fixed linting issues (ran prettier) (#1379) 2022-01-07 14:28:25 +01:00
Daniel James Smith
c6f20f8142 Fix prettier (#598)
* Add .github/workflows to .prettierignore

* Add all filestypes to prettier and ignore via .prettierignore

* Add --ignore-unknown to prettier for lint-staged
2022-01-07 14:23:42 +01:00
github-actions[bot]
2d271460e3 Autosync the updated translations (#1378)
Co-authored-by: github-actions <>
2022-01-07 13:51:08 +01:00
github-actions[bot]
209eb3e3e2 Autosync the updated translations (#2261)
Co-authored-by: github-actions <>
2022-01-07 13:50:50 +01:00
github-actions[bot]
695e8389d8 Autosync the updated translations (#1222)
Co-authored-by: github-actions <>
2022-01-07 13:50:31 +01:00
github-actions[bot]
241004f13b Bumped version to 2.25.1 (#1376)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-01-06 14:15:35 -08:00
Daniel James Smith
dd73a45f64 Add ts files to prettier (#1219)
* Add ts files to prettier

* Add scss to prettier

* Add all filetypes to prettier and ignore via .prettierignore

* Add --ignore-unknown to prettier
2022-01-06 23:06:58 +01:00
Oscar Hinton
2f5d0201fe [BEEEP] Add script for optimizing images (#1374) 2022-01-06 21:20:35 +01:00
Daniel James Smith
8ffe2c2dca Add --ignore-unknown to prettier (#2259) 2022-01-06 21:07:09 +01:00
Robyn MacCallum
c874d0d1a7 update jslib (#434) 2022-01-06 13:41:18 -05:00
Robyn MacCallum
c27fc39411 Use correct api Keys (#599) 2022-01-06 11:03:44 -05:00
Daniel James Smith
7ffb5db310 Add --ignore-unknown to prettier on lint-staged (#1375) 2022-01-06 16:47:55 +01:00
Daniel James Smith
6603521d88 Add all filetypes to prettier and ignore via .prettierignore (#1373) 2022-01-06 15:13:29 +01:00
Daniel James Smith
ca887c2291 Run prettier on *.ts files (#2257)
* Run prettier on *.ts files

* Add scss to prettier

Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>

* Add all filetypes to prettier and ignore via .prettierignore

Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
2022-01-06 14:57:04 +01:00
Daniel James Smith
a1bbbcf4bf Update year in copyright (#1216) 2022-01-05 19:44:08 +01:00
Daniel James Smith
59ff1a829e Update year in copyright (#432) 2022-01-05 19:44:04 +01:00
Oscar Hinton
27b1ee2ab3 Whitelist rxjs in nodeExternals (#1218) 2022-01-04 20:51:21 +01:00
Addison Beck
d066e0586a [bug] Add defaults for vault timeout (#1365)
* [bug] Add state defaults for vault timeout

* [chore] Update jslib
2022-01-04 11:15:58 -05:00
Daniel James Smith
756464c1e2 Merge pull request #2256 from bitwarden/apply-prettier-on-previously-ignored-files
Apply prettier for previously ignored file
2022-01-04 16:58:45 +01:00
Daniel James Smith
4b2266a7ce Add newline before export class 2022-01-04 16:48:57 +01:00
Daniel James Smith
a3fd33c5ae Apply prettier for previously ignored file 2022-01-04 16:41:07 +01:00
Daniel James Smith
ccd96d5d36 Merge pull request #2255 from bitwarden/Refactor-Autofill-service
Tech-Debt: Refactor autofill service
2022-01-04 15:21:47 +01:00
Daniel James Smith
d0e661b84b Update year in copyright (#1370) 2022-01-03 17:14:50 +01:00
Daniel James Smith
bacbc71dad Merge pull request #2254 from bitwarden/update-copyright
Update year in copyright
2022-01-03 12:00:11 +01:00