1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-27 10:03:23 +00:00
Commit Graph

1890 Commits

Author SHA1 Message Date
Nick Krantz
e422dc7f29 [PM-32717] Individual Vault - Edit Cipher permissions (#19228)
* bypass cipher edit permissions for individual vault

* replace bypassCipherEditPermission with form configuration mode

* allow partial edit to view cipher form

* remove old comment
2026-02-25 13:26:56 -06:00
Bernd Schoolmann
666ff42d22 [PM-31763] Add unlock service & module (#18870)
* Add unlock service

* Move methods

* Prettier

* Fix type errors

* Prettier

* Fix test

* Fix module order

* Attempt to fix tests

* Cleanup CODEOWNERS

* Backport biometric unlock and legacy master-key logic

* Add tests for biometrics

* Prettier

* Add biometric unlock to abstract unlock service

* Fix build
2026-02-25 18:50:25 +01:00
Dave
4f706746d6 [PM-30811] Update change email flow to use new Key Management APIs (#18857)
* feat(change-email) [PM-30811]: Add feature flag.

* feat(change-email) [PM-30811]: Add new constructor to EmailTokenRequest.

* feat(change-email) [PM-30811]: Update import.

* feat(change-email) [PM-30811]: Stub new ChangeEmailService.

* feat(change-email) [PM-30811]: Provide ChangeEmailService.

* feat(change-email) [PM-30811]: Add ChangeEmailService impl.

* feat(change-email) [PM-30811]: Add ChangeEmailService to component.

* feat(change-email) [PM-30811]: Remove change-email methods from ApiService.

* feat(change-email) [PM-30811]: Update EmailTokenRequest for new APIs.

* feat(change-email) [PM-30811]: Finish implementation of both paths in ChangeEmailService.

* feat(change-email) [PM-30811]: Wire-up service in ChangeEmailComponent.

* test(change-email) [PM-30811]: Add ChangeEmailService tests.

* test(change-email) [PM-30811]: Update tests.

* refactor(change-email) [PM-30811]: EmailTokenRequest strict-ignore until legacy support can be unwound.

* refactor(change-email) [PM-30811]: Re-order imports.

* test(change-email) [PM-30811]: Update component tests to reflect new implementation.

* refactor(change-email) [PM-30811]: Formatting.

* test(change-email-service) [PM-30811]: Improve accuracy of null-checking tests: kdf, userKey, salt, in order.
2026-02-25 12:41:29 -05:00
Bernd Schoolmann
4024d34df8 [PM-31406] fix: TypeScript 5.9 type compatibility fixes for audit.service (#19195)
* fix: TypeScript 5.9 type compatibility fixes for audit.service

Add explicit `as BufferSource` casts and `Uint8Array` wrapping to satisfy
stricter type checking in TypeScript 5.9. Non-functional changes.

* Add non-null assertion
2026-02-25 10:46:13 -06:00
Bernd Schoolmann
cf7f9cfc7e [BEEEP|PM-32521] Remove compare key hash and move to proof of decryption (#19101)
* Remove compare key hash and move to proof of decryption

* Fix cli build

* Fix mv2

* Fix provider

* Prettier
2026-02-25 17:02:04 +01:00
Alex Morask
b964cfc8e4 [PM-32612] Only show subscription menu option when premium user has subscription (#19209)
* fix(billing): only show Subscription menu option when premium user has subscription

* fix(billing): missed state service invocation changes
2026-02-25 08:25:24 -06:00
Bernd Schoolmann
b27f820ffb Add non-null type hints (#19219) 2026-02-25 14:47:20 +01:00
Bernd Schoolmann
98f6169333 Narrow types for platform utils service (#19196) 2026-02-25 03:12:13 -06:00
Bernd Schoolmann
d20f659bbc [PM-31406] fix: TypeScript 5.9 type compatibility fixes for vault-owned code (#19191)
* fix: TypeScript 5.9 type compatibility fixes for vault-owned code

Add explicit `as BufferSource` casts and `Uint8Array` wrapping to satisfy
stricter type checking in TypeScript 5.9. Non-functional changes.

* Fix cli build
2026-02-25 10:04:23 +01:00
Thomas Rittson
da0005b01b [PM-32131] Add UseMyItems organization ability (#19018)
Not used in the front-end yet, but adding it here
for consistency
2026-02-25 12:54:23 +10:00
Daniel James Smith
181e4767d8 Parse the CommunicationServerConfigResponse within the ConfigService and expose changes via an observable. (#19184)
Model was introduced on the server with https://github.com/bitwarden/server/pull/6892

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-02-24 15:03:44 -05:00
Vijay Oommen
4bcdd08ab8 [PM-32447] Integration card after edits (#19203) 2026-02-24 13:37:33 -06:00
sven-bitwarden
d50c5e1819 [PM-32172] Redirect All Calls to PUT Policy VNext Endpoint (#19015)
* Redirect all remaining calls to VNextSavePolicy endpoint

* Remove unused code

---------

Co-authored-by: bnagawiecki <107435978+bnagawiecki@users.noreply.github.com>
2026-02-24 12:37:58 -06:00
cd-bitwarden
435375ab53 Removing feature flag from client side (#19070) 2026-02-23 12:48:34 -06:00
Thomas Avery
672a6026e3 [PM-27331] Update the sdk service to use accountCryptographicState (#18274)
* Update the sdk service to use accountCryptographicState
2026-02-23 12:23:37 -06:00
Nik Gilmore
99445e1ca6 [PM-31958] BUGFIX: Blank Screen showing after deleting item (#18860)
* Move clearCache calls before SDK calls, to prevent race conditions from firing.

* Swap calls to clearCache and restoreWithServer/restoreManyWithServer to fix race condition
2026-02-23 09:53:01 -08:00
Jackson Engstrom
ef7df6b841 [PM-30521] Add Autofill button to View Login screen for extension (#18766)
* adds autofill button for cipher view

* adds tests

* changes autofill function for non login types

* adds top margin to autofill button

* adds more top margin to autofill button

* only shows autofill button when autofill is allowed (not in a popout)

* add button type

* updates _domainMatched to take a tab param, updates how the component is passed through to slot

* fixes tests from rename

* adds comment about autofill tab checking behavior

* removes diff markers
2026-02-20 14:28:54 -08:00
Bernd Schoolmann
3a56f2e832 [PM-30785|BEEEP] Remove deprecated master key login with device flow (#17943)
* Remove deprecated master key login with device flow

* Resolve conflicts / cleanup

* Linting

* Fix lint

* Run prettier
2026-02-20 13:22:05 -05:00
John Harrington
c623407621 [PM-32471] [Defect] Importers have regressed during folder migration (#19079)
* relax type-checking and add importer test coverage

* satisfy lint
2026-02-20 09:31:49 -07:00
Nick Krantz
a610ce01a2 [PM-31433] Welcome Dialog with Extension Prompt (#18849)
* add welcome prompt when extension is not installed

* add feature flag

* move prompt logic to internal service and add day prompt

* rename dialog component

* remove feature flag hardcode and add documentation

* use i18n for image alt

* move state into service

* be more explicit when the account or creation date is not available

* remove spaces

* fix types caused by introducing a numeric feature flag type

* add `typeof` for feature flag typing
2026-02-20 10:23:59 -06:00
Bernd Schoolmann
bb110122a5 [PM-30144] Implement client-side user-key-rotation-service (#18285)
* Implement client-side user-key-rotation-service

* Feature flag

* Add tests

* Fix flag name

* Fix build

* Prettier

* Small clean-up

* Codeowners order cleanup

* Fix eslint issue

* Update sdk to 550

* Cleanup & fix incompatibilities

* Prettier
2026-02-20 15:28:24 +01:00
Jordan Aasen
46a2af38a0 [PM-31974] - Vault Welcome dialog (#18960)
* premium upgrade prompt and onboarding dialog

* finalize onboard vault dialog

* vault welcome dialog no ext

* finish welcome dialog prompt

* revert changes to unified upgrade prompt service

* rename component

* rename feature flag

* add welcome dialog service

* fix tests

* fix footer position in welcome dialog

* present dialog in order

* fix tests

* fix padding
2026-02-19 09:29:54 -08:00
Alex Morask
4f256fee6d [PM-29087] [PM-29088] Remove FF: pm-26793-fetch-premium-price-from-pricing-service - Logic + Flag (#18946)
* refactor(billing): remove PM-26793 feature flag from subscription pricing service

* test(billing): update subscription pricing tests for PM-26793 feature flag removal

* chore: remove PM-26793 feature flag from keys
2026-02-19 09:26:18 -06:00
Brandon Treston
c8ba23e28d [PM-26378] Auto confirm events (#19025)
* add notification handler for auto confirm

* add missing state check

* fix test

* isolate angular specific code from shared lib code

* clean up

* use autoconfirm method

* add event logging for auto confirm

* update copy
2026-02-19 09:57:52 -05:00
Bernd Schoolmann
6498ec42f8 [BEEEP] Add util functions for uint8 array conversion (#18451)
* Add util functions for uint8 array conversion

* Use polyfill instead of old functionality

* Replace last usage of old functions
2026-02-19 14:04:43 +01:00
Mike Amirault
6dea7504a6 [PM-26732] Remove Chromium ABE importer feature flag (#19039) 2026-02-18 14:49:51 -05:00
Alex Morask
5161a232f5 [PM-29055] Remove pm-25379-use-new-organization-metadata-structure feature flag (#18848)
Remove the fully-enabled feature flag and simplify the billing metadata
API to always use the vNext endpoints. The legacy API path is removed
since the server will no longer serve it.

- Remove FeatureFlag.PM25379_UseNewOrganizationMetadataStructure enum and default
- Delete legacy getOrganizationBillingMetadata() API method (old /billing/metadata path)
- Rename vNext methods to remove VNext suffix
- Simplify OrganizationMetadataService to always use cached vNext path
- Remove ConfigService dependency from OrganizationMetadataService
- Update tests to remove feature flag branching
2026-02-18 09:06:10 -06:00
Dave
e262441999 [PM-31088] saltForUser should emit salt from master password unlock data (#18976)
* feat(salt-for-user) [PM-31088]: Add feature flag for saltForUser.

* feat(salt-for-user) [PM-31088]: Flag saltForUser logic to return unlockdata.salt or emailToSalt.

* test(salt-for-user) [PM-31088]: Update tests to include coverage for new behavior.
2026-02-17 17:43:00 -05:00
SmithThe4th
61326979b9 Updated delete attachment to conform with the server side changes (#19014) 2026-02-17 16:07:14 -05:00
John Harrington
728eab3dab set auth to false for anon file send access (#18978) 2026-02-16 15:55:03 -07:00
SmithThe4th
8bd1e5a855 [PM-30580] Add encryptMany to SDK for batch cipher encryption (#18942)
* Migrated encrypt many to the sdk

* removed comment

* updated sdk package
2026-02-13 23:13:41 +00:00
SmithThe4th
2297082b1a [PM-31668] Race condition in cipher cache clearing causes stale failed decryption state after leaving organization (#18941)
* Refactored the search index to index with the cipherlistview

* Fixed comment

* clear encrypted cipher state to prevent stale emissions during sync

* skip decrypt call when cipher arry is emoty during sync
2026-02-13 16:46:29 -05:00
Brandon Treston
2912bf05e1 [PM-26901] Add notification handler for auto confirm (#18886)
* add notification handler for auto confirm

* add missing state check

* fix test

* isolate angular specific code from shared lib code

* clean up

* use autoconfirm method

* fix test
2026-02-13 14:36:11 -05:00
Jared
b567fea7e7 [PM-29506] Rid of old feature flag for members feature flag (#18884)
* [PM-31750] Refactor members routing and user confirmation logic

* Simplified user confirmation process by removing feature flag checks.
* Updated routing to directly use the new members component without feature flagging.
* Removed deprecated members component references from routing modules.
* Cleaned up feature flag enum by removing unused entries.

* trigger claude

* [PM-31750] Refactor members component and remove deprecated files

* Renamed vNextMembersComponent to MembersComponent for consistency.
* Removed deprecated_members.component.ts and associated HTML files.
* Updated routing and references to use the new MembersComponent.
* Cleaned up related tests to reflect the component name change.

* Refactor import statements in security-tasks.service.ts for improved readability

* Update apps/web/src/app/admin-console/organizations/manage/user-confirm.component.ts

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* Remove BaseMembersComponent and related imports from the admin console, streamlining member management functionality.

* Remove unused ConfigService import from UserConfirmComponent to clean up code.

* Implement feature flag logic for user restoration in MemberDialogComponent, allowing conditional restoration based on DefaultUserCollectionRestore flag.

---------

Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
2026-02-13 11:38:35 -05:00
Jordan Aasen
2a72d2e74d [PM-25685][PM-31077] - Migrate all Folder models (#17077)
* enforce strict types on folders

* fix folder api service

* fix tests

* fix test

* fix type issue

* fix test

* add extra checks for folders. add specs

* fix folder.id checks

* fix id logic

* remove unecessary check

* name name and id optional in folder model

* fix tests

* Update folder and folderview

* fix folder with id export

* fix tests

* fix tests

* more defensive typing

* fix tests

* no need to check for presence

* check for empty name in folder toDomain

* fixes to folder

* initialize id in folder constructor. fix failing tests

* remove optional param to folder constructor

* fix folder

* fix test

* remove remaining checks for null folder id

* fix logic

* pass null for empty folder ids

* make id more explicit

* fix failing test

* fix failing test

* fix "No Folder" filter
2026-02-12 13:52:29 -08:00
Bernd Schoolmann
9d69b15798 [PM-32063] Disable cipher-key-downgrading (#18911)
* Proposal: Disable cipher-key-downgrading

* Cleanup
2026-02-12 10:31:48 +01:00
Jordan Aasen
396286ff9a [PM-26703] - Update Item Action Behavior for Extension (#18921)
* Revert "Revert "[PM-26703]- Browser - Update autofill Behavior (#18467)" (#18723)"

This reverts commit 5d17d9ee71.

* fix title in non-autofill list

* add feature flag

* add old logic. add specs

* revert changes

* remove comments

* update language in spec

* update appearance spec

* revert change to security-tasks

* fix logic for blocked uri. add deprecated notice.

* fix test

* fix type error
2026-02-11 16:54:05 -08:00
Rui Tomé
5cf4678838 [PM-28300] Remove BlockClaimedDomainAccountCreation feature flag and related logic from policy component (#18720) 2026-02-11 22:10:55 +00:00
Nick Krantz
f20686cdf4 [PM-24978] Corrupt Attachment Keys (#17790)
* display translated content for attachments that cannot be downloaded

* consume decryption failure from the sdk for attachments

* add decryption errors from sdk

* only show fix attachment issues for when key is null and it does not have a decryption failure

* separate decryption failure state in view
2026-02-11 10:31:38 -06:00
Jon David Schober
29e2be0d2b [PM-30529][PM-31279] Webauthn: Support Related Origin Requests (#18242)
* Webauthn: Support Related Origin Requests

* review changes

* PM-31279 Add feature flag to guard executing ROR checks

* Fix fido2-client.service tests

* Set ROR_MAX_LABELS to 5

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Addison Beck <github@addisonbeck.com>
2026-02-11 10:32:22 -05:00
Brandon Treston
1aef83b6e3 [PM-28262] Bulk re-invite UI improvements (#18754)
* implement dilogs and logic

* clean up, add tests

* add feature flag key

* product requested changes

* more product changes

* edit error message
2026-02-10 16:20:39 -05:00
Bernd Schoolmann
d37e173ee3 [BEEEP] Add deprecation notices to encstring encrypt API (#18811)
* Add deprecation notices to encstring encrypt API

* Cleanup comment

* Run prettier
2026-02-09 17:29:45 -06:00
Bernd Schoolmann
9856902688 Make hazmat warnings more bold (#18813) 2026-02-09 15:56:24 -06:00
Jason Ng
322ff6b70b [PM-31675] remove archive from web edit (#18764)
* refactor default cipher archive service, update archive/unarchive in vault-item-dialog, remove archive/unarchive items in edit form
2026-02-09 16:17:46 -05:00
Alex Dragovich
e485623ed8 [PM-31685] Removing email hashes (#18744)
* [PM-31685] Removing email hashes

* [PM-31685] fixing tests, which are now passing

* [PM-31685] removing anon access emails field and reusing emails field

* [PM-31685] fixing missed tests

* [PM-31685] fixing missed tests

* [PM-31685] code review changes

* [PM-31685] do not encrypt emails by use of domain functionality

* [PM-31685] test fixes
2026-02-09 12:59:17 -08:00
SmithThe4th
48d18df285 Revert "[PM-31668] Race condition in cipher cache clearing causes stale faile…" (#18846)
This reverts commit bf13194b9c.
2026-02-09 14:32:49 -06:00
Bernd Schoolmann
ea04b0562f Prevent SDK from disposing withit debounce period (#18775) 2026-02-09 20:19:38 +00:00
SmithThe4th
d02886ba8d Revert "[PM-30580] Add encryptMany to SDK for batch cipher encryption (#18803)" (#18840)
This reverts commit a637983305.
2026-02-09 10:31:26 -05:00
Bernd Schoolmann
f7a5ad712f [PM-29208] Remove individual cryptographic-key states & migrate key service (#18164)
* Remove inividual user key states and migrate to account cryptographic state

* Fix browser

* Fix tests

* Clean up migration

* Remove key-pair creation from login strategy

* Add clearing for the account cryptographic state

* Add migration

* Cleanup

* Fix linting
2026-02-09 12:39:55 +01:00
Daniel James Smith
03a60a61cb Revert "[PM-29149] Add ServerCommunicationConfigService (#18815)" (#18821)
This reverts commit f1b9408e3f.
2026-02-06 21:15:12 +00:00