1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-10 05:30:01 +00:00
Commit Graph

276 Commits

Author SHA1 Message Date
Alec Rippberger
028bdf4697 fix tests 2025-04-16 08:53:06 -05:00
Alec Rippberger
543df715e7 fix tests 2025-04-16 08:28:34 -05:00
Alec Rippberger
e051b8dbc7 Rename TwoFactorAuthEmailCache to TwoFactorAuthEmailComponentCache 2025-04-15 22:43:22 -05:00
Alec Rippberger
47bdcf9665 fix tests 2025-04-15 17:15:40 -05:00
Alec Rippberger
f6a4e30fbb Move service to live alongside component 2025-04-15 16:42:10 -05:00
Alec Rippberger
6ee84f502c Add "component" to file name and variables for clarity 2025-04-15 16:33:10 -05:00
Alec Rippberger
d09293a934 Remove default selectedProviderType 2025-04-15 16:22:16 -05:00
Alec Rippberger
73a6f059a8 Use TwoFactorAuthData import instead of separate interface 2025-04-15 16:15:20 -05:00
Alec Rippberger
d0c1f6d662 Add "component" to component cache service name 2025-04-15 16:06:45 -05:00
Alec Rippberger
b11b950ef5 fromJSON should return null if the cache is empty 2025-04-15 15:52:49 -05:00
Alec Rippberger
07035a1b58 Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-04-15 15:41:34 -05:00
Bernd Schoolmann
b09305577f [PM-19603] Change asymmetric interface to only allow key encapsulation (#14046)
* Change asymmetric interface to only allow key encapsulation

* Fix naming

* Clean up naming

* Update libs/common/src/key-management/crypto/abstractions/encrypt.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/crypto/services/encrypt.service.implementation.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/crypto/abstractions/encrypt.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Fix test

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2025-04-15 16:39:02 +02:00
Todd Martin
356a20a4bc fix(login): [PM-20174] Do not show validation errors on email input on LoginComponent
* Do not show validation errors on input

* Removed one-line function.

* Removed awaits
2025-04-14 15:55:01 -04:00
Alec Rippberger
31064ce5f8 Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-04-10 18:41:05 -05:00
Todd Martin
f7934b98c6 fix(login): [PM-11502] Support Remember Email option consistently
* Moved saving of SSO email outside of browser/desktop code

* Clarified comments.

* Tests

* Refactored login component services to manage state

* Fixed input on login component

* Fixed tests

* Linting

* Moved web setting in state into web override

* updated tests

* Fixed typing.

* Fixed type safety issues.

* Added comments and renamed for clarity.

* Removed method parameters that weren't used

* Added clarifying comments

* Added more comments.

* Removed test that is not necessary on base

* Test cleanup

* More comments.

* Linting

* Fixed test.

* Fixed base URL

* Fixed typechecking.

* Type checking

* Moved setting of email state to default service

* Added comments.

* Consolidated SSO URL formatting

* Updated comment

* Fixed reference.

* Fixed missing parameter.

* Initialized service.

* Added comments

* Added initialization of new service

* Made email optional due to CLI.

* Fixed comment on handleSsoClick.

* Added SSO email persistence to v1 component.

* Updated login email service.

* Updated setting of remember me

* Removed unnecessary input checking and rearranged functions

* Fixed name

* Added handling of Remember Email to old component for passkey click

* Updated v1 component to persist the email on Continue click

* Fix merge conflicts.

* Merge conflicts in login component.

* Persisted login email on v1 browser component.

* Merge conflicts

* fix(snap) [PM-17464][PM-17463][PM-15587] Allow Snap to use custom callback protocol

* Removed Snap from custom protocol workaround

* Fixed tests.

* Updated case numbers on test

* Resolved PR feedback.

* PM-11502 - LoginEmailSvcAbstraction - mark methods as abstract to satisfy strict ts.

* Removed test

* Changed to persist on leaving fields instead of button click.

* Fixed type checking.

---------

Co-authored-by: Bernd Schoolmann <mail@quexten.com>
Co-authored-by: Jared Snider <jsnider@bitwarden.com>
Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>
2025-04-10 18:58:49 -04:00
Alec Rippberger
1b2522683e Add tests for new services 2025-04-10 16:55:52 -05:00
Alec Rippberger
3ad40d7082 Move email sent information to its own cache service 2025-04-10 16:26:44 -05:00
Alec Rippberger
3668fed7b4 Update naming for consistency 2025-04-10 15:41:12 -05:00
Alec Rippberger
92797c99c7 Rename to remove "view" and "default" 2025-04-10 15:35:19 -05:00
Alec Rippberger
116c4ec5ed Move TwoFactorFormView into service and rename to remove "view" and "form" 2025-04-10 15:22:52 -05:00
Bernd Schoolmann
5a1b0744f0 [PM-17665] Move cryptofunction service to km (#13285)
* Move cryptofunction service to km

* Fix formatting

* Fix import

* Fix build on desktop

* Fix build on browser and tests
2025-04-10 11:09:35 +02:00
Alec Rippberger
42a4b081d1 Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-04-09 09:16:43 -05:00
rr-bw
a4040b6b6b refactor(set-change-password): [Auth/PM-17649] Move CompareInputs Validator (#14173)
This PR
- Moves the `compareInputs` validator to `libs/auth` (with some minor updates to the validator)
- Adds unit tests for `compareInputs`
- Removes the deprecated input validators from `InputsFieldMatch` along with the `inputs-field-match.validator.ts` file
2025-04-08 12:42:41 -07:00
Alec Rippberger
40e9b6ad76 Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-04-08 10:06:37 -05:00
rr-bw
81350a2ee1 Revert "refactor(set-change-password): [Auth/PM-17649] Move and test compareI…" (#14171)
This reverts commit ecb4b2d0b7.
2025-04-07 18:34:35 -07:00
rr-bw
ecb4b2d0b7 refactor(set-change-password): [Auth/PM-17649] Move and test compareInputs validator (#13553)
- Move the `compareInputs` validator to `libs/auth`
- Add tests for the `compareInputs` validator
- Delete the deprecated `InputsFieldMatch` class (inputs-field-match.validator.ts)
2025-04-07 15:04:24 -07:00
rr-bw
2267876860 refactor(set-change-password): [Auth/PM-18206] Update InputPasswordComponent to handle multiple flows (#13745)
Updates the InputPasswordComponent so that it can eventually be used in multiple set/change password scenarios.

Most importantly, this PR adds an InputPasswordFlow enum and @Input so that parent components can dictate which UI elements to show.
2025-04-07 11:58:50 -07:00
Alec Rippberger
331fcce3fe Merge branch 'auth/pm-9115/implement-view-data-persistence-in-2FA-flows' of https://github.com/bitwarden/clients into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-04-07 11:02:54 -05:00
Alec Rippberger
6593912ddd Fix tests 2025-04-07 11:02:41 -05:00
Alec Rippberger
782e33c91d Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-04-07 10:51:18 -05:00
Alec Rippberger
7adc4eaee5 Refactor TwoFactorFormCacheService 2025-04-07 10:42:21 -05:00
Patrick-Pimentel-Bitwarden
1af8fe2012 feat(device-approval-persistence): [PM-19380] Device Approval Persistence (#13958)
* feat(device-approval-persistence): [PM-19380] Device Approval Persistence - Added lookup on standard auth requests.

* fix(device-approval-persistence): [PM-19380] Device Approval Persistence - Fixed issue with null value trying to be parsed from the fromJSON function.




---------

Co-authored-by: Todd Martin <tmartin@bitwarden.com>
2025-04-04 15:44:48 -04:00
Alec Rippberger
f31240971d Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-04-03 13:28:24 -05:00
Bernd Schoolmann
1450a033b3 [PM-19469] Add logs for unlock time (#13972)
* Add logs for unlock time

* Undo local flag override

* Update message

* Update messages

* Fix build on chrome
2025-04-02 23:19:53 +02:00
Will Martin
76cb3fd38d [CL-623] export CDK dialog deps from libs/components (#14074)
* add cdk dialog deps to CL dialog barrel file

* find and replace cdk dialog import

* run prettier
2025-04-02 15:08:38 -04:00
Alec Rippberger
8563bc8983 Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-03-31 14:26:53 -05:00
Bernd Schoolmann
22039d038d [PM-3475] Remove deprecated keys (#13266)
* Remove deprecated keys

* Fix cli build

* Fix build
2025-03-31 16:58:02 +02:00
Alec Rippberger
4c7684bc5e Remove unnecessary conditionals 2025-03-29 15:20:10 -05:00
Alec Rippberger
c814a2e378 Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-03-29 07:48:55 -05:00
Jason Ng
66a914badf [PM-19654] add hideIcon option to extension anon layout (#14045) 2025-03-28 15:50:30 -04:00
Alec Rippberger
7d4c3e3c57 Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-03-25 15:42:31 -05:00
Brandon Treston
0fd01ed7ee [PM-18566] Wire up vNextPolicyService for Clients (#13678)
* wire up vNext impl

* wire up vNextPolicyService for browser

* wire up vNextPolicyService for desktop

* wire up vNextPolicyService for cli

* fix test

* fix missed caller

* cleanup

* fix missing property assignment

* fix QA bug for PM-19205

* fix QA bug for PM-19206

* fix QA bug for pm-19228

* cleanup
2025-03-25 11:30:47 -04:00
Alec Rippberger
b49fd01094 Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-03-21 16:50:28 -05:00
Patrick-Pimentel-Bitwarden
841e5980d7 fix(device-approval-login): [PM-19379] Approve Device Login - Fix the call so that it works when not in a TDE scenario. (#13934) 2025-03-21 10:22:37 -04:00
Alec Rippberger
eb31561f06 Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-03-20 15:58:22 -05:00
Patrick-Pimentel-Bitwarden
2e0c991f83 fix(device-approval-persistence): [PM-9112] Device Approval Persistence (#13680)
* feat(device-approval-persistence): [PM-9112] Device Approval Persistence - Added in view cache data needed to persist the approval process. Clears after 2 minutes.
2025-03-19 19:26:10 +00:00
Alec Rippberger
edadfcdb93 Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-03-18 15:46:38 -05:00
Thomas Avery
a11536a424 [PM-17668] Move DeviceTrustService to KM ownership (#13194)
* move DeviceTrustService to KM ownership

* update codecov
2025-03-17 12:02:44 -05:00
Alec Rippberger
e42ae9f410 Merge branch 'main' into auth/pm-9115/implement-view-data-persistence-in-2FA-flows 2025-03-17 09:27:56 -05:00
Thomas Avery
81335978d8 [PM-17669] Move MasterPasswordService to KM (#13148)
* Move MasterPasswordService to KM
2025-03-13 13:29:27 -05:00