bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 05:13:29 +00:00
Code Issues Releases Wiki Activity
18,914 Commits 1,211 Branches 568 Tags
6bd8638ad87293e0c77b4c793cbeb9fcc82df1d2
Commit Graph

2741 Commits

Author SHA1 Message Date
Bernd Schoolmann
6bd8638ad8 [PM-24126] Move pin service to km ownership (#15821) 
* Move pin service to km ownership

* Run format

* Eslint

* Fix tsconfig

* Fix imports and test

* Clean up imports

* Remove unused dependency on PinService

* Fix comments

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
 2025-08-04 17:01:39 +02:00
Addison Beck
361f7e3447 refactor: introduce @bitwarden/state and other common libs (#15772) 
* refactor: introduce @bitwarden/serialization

* refactor: introduce @bitwarden/guid

* refactor: introduce @bitwaren/client-type

* refactor: introduce @bitwarden/core-test-utils

* refactor: introduce @bitwarden/state and @bitwarden/state-test-utils

Creates initial project structure for centralized application state management. Part of modularization effort to extract state code from common.

* Added state provider documentation to README.

* Changed callouts to Github format.

* Fixed linting on file name.

* Forced git to accept rename

---------

Co-authored-by: Todd Martin <tmartin@bitwarden.com>
 2025-08-04 11:01:28 -04:00
Vicki League
f7cc937581 [CL-753] Fix popover spacing in client code (#15839) 2025-08-04 10:19:07 -04:00
Maciej Zieniuk
8a22dca877 lock component unit test coverage (#15801) 2025-08-02 14:55:14 +02:00
renovate[bot]
2dd6164fce [deps] Autofill: Update prettier to v3.6.2 (#15496) 
* [deps] Autofill: Update prettier to v3.6.2

* fix: [PM-23425] Fix prettier issues related to dependency updte

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* [deps] Autofill: Update prettier to v3.6.2

---------

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ben Brooks <bbrooks@bitwarden.com>
 2025-08-01 14:02:54 -07:00
Bernd Schoolmann
0cc473fb0f Remove legacy key support form platform code (#15351) 2025-08-01 13:06:22 -05:00
Dave Brothers
e47dc174a0 fix(login-component): [Auth/PM-19475] button icons are not marked as aria-hidden="true" (#15866) 2025-08-01 09:09:35 -04:00
Alex Morask
18bce185f0 Fix TaxService.previewTaxAmountForOrganizationTrial return type (#15848) 2025-07-31 08:19:20 -05:00
Justin Baur
4f9b2b618f [PM-24280] Remove account service from state (#15828) 
* Introduce ActiveUserAccessor

* Use ActiveUserAccessor over AccountService

* Updates tests and testing utils to support ActiveUserAccessor

* Update all injection points

* Fix types test

* Use ternary instead
 2025-07-31 09:09:14 -04:00
Bernd Schoolmann
021d275c43 [PM-24079] Switch EncryptedString to SDK type (#15796) 
* Update usages of sdk to type-safe SDK type

* Update sdk version

* Update to "toSdk"
 2025-07-30 23:49:50 +02:00
Jordan Aasen
1c5095806f [PM-24232] - [Defect][Web] Admin Console - SSH key and Folder should not show as options from New button (#15834) 
* properly call input functions

* don't enable sshkey form

* fix logic for disabling cipher form

* prefer use of observable

* use destroyRef. change to enabled status only
 2025-07-30 12:15:59 -07:00
Bernd Schoolmann
5dae5267d9 [PM-22623] Remove most TS encryption code, remove service workers (#15153) 
* Add new encrypt service functions

* Undo changes

* Cleanup

* Fix build

* Fix comments

* Switch encrypt service to use SDK functions

* Move remaining functions to PureCrypto

* Tests

* Increase test coverage

* Enforce sdk.ready and drop unused codepaths

* Delete unused code

* Delete unused code

* Delete more code

* Add forgotten sdk init logic

* Fix build

* Fix cli

* Fix tests

* Fix build

* Fix browser build

* Remove compare and add more comments / warnings

* Run prettier

* Remove unused feature flags

* Add hazmat warning to aesDecrypt

* Fix build

* Fix comment

* Fix test
 2025-07-30 15:50:00 +02:00
Bryan Cunningham
f6e8df18c0 [CL-587] disabled item styles (#15822) 
* wip

* remove cursor not allowed

* add disabled button story

* add cursor not allowed
 2025-07-29 16:12:01 -04:00
Vicki League
6a2d8ee294 [CL-768] Fix small a11y errors in storybook stories (#15826) 2025-07-29 14:29:37 -04:00
Bernd Schoolmann
a7d3c0f5c2 [PM-23809] Add simplified interface to MP service (#15631) 
* Add new mp service api

* Fix tests

* Add test coverage

* Add newline

* Fix type

* Rename to "unwrapUserKeyFromMasterPasswordUnlockData"

* Fix build

* Fix build on cli

* Fix linting

* Re-sort spec

* Add tests

* Fix test and build issues

* Fix build

* Clean up

* Remove introduced function

* Clean up comments

* Fix abstract class types

* Fix comments

* Cleanup

* Cleanup

* Update libs/common/src/key-management/master-password/types/master-password.types.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/services/master-password.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/types/master-password.types.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Add comments

* Fix build

* Add arg null check

* Cleanup

* Fix build

* Fix build on browser

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Add tests for null params

* Cleanup and deprecate more functions

* Fix formatting

* Prettier

* Clean up

* Update libs/key-management/src/abstractions/key.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Make emailToSalt private and expose abstract saltForUser

* Add tests

* Add docs

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
 2025-07-29 18:53:17 +02:00
Oscar Hinton
e3d5385661 Migrate UIF to use takeuntilDestroyed (#15777) 2025-07-29 10:17:30 +02:00
adudek-bw
33ed9ac6ac [PM-19976] Implement SDK generator engines (#15063) 
* Hook up sdk engines to feature flag

---------

Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>
 2025-07-28 16:52:19 -04:00
Will Martin
f34260bc5e [CL-800] delete a11y-grid, a11y-row, a11y-cell directives (#15709) 
* delete a11y-grid,-row,-cell directives

* remove missed references

* remove missed references
 2025-07-28 14:12:56 -04:00
Shane Melton
b48d7d4b97 [PM-23085] Use SDK to get rotated cipher data (#15670) 
* [PM-23085] Add encryptWithKey method to CipherEncryptionService

* [PM-23085] Use new encryptWithKey() SDK method in getRotatedData() based on feature flag

* [PM-23085] Rename cipher encryption method to encryptCipherForRotation to better reflect intended use case

* [PM-23085] Update @bitwarden/sdk-internal package version

* [PM-23085] Fix failing test after method rename

* [PM-23085] Fix other failing test

* [PM-23085] Typo
 2025-07-28 10:36:34 -07:00
Bernd Schoolmann
edeb0f4597 Remove decrypt with key from EncString, domain-base (#15702) 2025-07-28 18:18:36 +02:00
Alex Morask
f4254ba920 [PM-21821] Provider portal takeover states (#15725) 
* Updates:

- Update simple dialog to disallow user to close the dialog on acceptance
- Split payment components to provide a "require" component that cannot be closed out of
- Add provider warning service to manage the various provider warnings

* Fix test

* Will's feedback and sync on payment method success
 2025-07-28 09:26:19 -05:00
Thomas Avery
2db31d1228 [PM-22611] Require userid for masterKey methods on the key service (#15663) 
* Require userId on targeted methods.

* update method consumers

* unit tests
 2025-07-25 09:37:04 -05:00
Tom
b358d5663d [PM-23822] [PM-23823] Organization integration and configuration api services (#15763) 
* Adding the organization integration api service and test cases

* Adding configuration api files and test cases. Fixing the id guids and integration type and event type nullable

* Adding get endpoint methods to the integration and config service and test cases

* fixing type check issues

* lowercase directory name
 2025-07-25 09:43:41 -04:00
Vicki League
37987f4f97 [CL-801] Move popover in kitchen sink story to avoid scrolling (#15767) 2025-07-25 08:34:39 -04:00
Bernd Schoolmann
594455af88 [PM-23099] Prevent private key regen / private key generation on v2 accounts (#15413) 
* Prevent private key regen / private key generation on v2 accounts

* Fix tests

* Fix build

* Fix tests
 2025-07-25 13:19:48 +02:00
Oscar Hinton
1491445392 [PM-24042] Migrate AC owned abstract services to strict TS (#15733) 
* Migrate remaining AC owned abstract services to strict TS

* Remove now unused service
 2025-07-25 05:21:15 -05:00
Daniel James Smith
d9480a8dab [PM-17503] Delete old password-strength component (#15652) 
* Removed flag and components.

* More cleanup

* Removed ChangePasswordComponent.

* Removed old EmergencyAccessTakeover

* Removed service initialization.

* Fixed test failures.

* Fixed tests.

* Test changes.

* Updated comments

* Delete old password-strength component

A PasswordStrengthV2Component had been created in July 2024 and now all usages of the old component have been replaced.

* Re-add canAccessFeature back into app-routing.module.
Messed up by merging main.

---------

Co-authored-by: Todd Martin <tmartin@bitwarden.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
 2025-07-25 08:10:35 +00:00
Bryan Cunningham
1f73ff17ed [CL-791] global text color change (#15723) 
* update variables to use same color as text-main

* remove unused headers key from tailwind config
 2025-07-24 16:15:51 -04:00
Vicki League
4766efd938 [CL-803] Temporarily disable flaky popover test (#15761) 2025-07-24 15:05:40 -04:00
Jordan Aasen
7b85870e58 [PM-22377] - [Vault] [Clients] Update cipher form component to restrict editing old My Vault items (#15687) 
* disable cipher form for "My Items" ciphers

* use correct property

* prevent changing non org fields in cli for org owned vaults

* update var name

* fix tests

* fix stories

* revert changes to item details section. update comment in edit command

* remove unused props

* fix test

* re-apply logic to enforce org ownership

* re-apply logic to enforce org ownership

* fix logic and test

* add empty line to comment

* remove unused var

* delegate form enabling/disabling to cipherFormContainer

* rename var and getter back to original. update comment
 2025-07-24 10:59:29 -07:00
Todd Martin
b3db1b79ce chore(feature flags): [PM-19034] Remove feature flags and old components for Set/Change Password 
* Removed flag and components.

* More cleanup

* Removed ChangePasswordComponent.

* Removed old EmergencyAccessTakeover

* Removed service initialization.

* Fixed test failures.

* Fixed tests.

* Test changes.

* Updated comments

* Fixed tests.

* Fixed tests.

* Fixed merge conflict.

* Removed style and routing references.

* Better comments.

* Removed ResetPasswordComponent
 2025-07-24 12:46:18 -04:00
Vijay Oommen
df8e0ed094 [PM-23825] setup crowdstrike card (#15728) 2025-07-24 08:53:03 -05:00
Brandon Treston
d0d1359ff4 [PM-12048] Wire up vNextCollectionService (#14871) 
* remove derived state, add cache in service. Fix ts strict errors

* cleanup

* promote vNextCollectionService

* wip

* replace callers in web WIP

* refactor tests for web

* update callers to use vNextCollectionServcie methods in CLI

* WIP make decryptMany public again, fix callers, imports

* wip cli

* wip desktop

* update callers in browser, fix tests

* remove in service cache

* cleanup

* fix test

* clean up

* address cr feedback

* remove duplicate userId

* clean up

* remove unused import

* fix vault-settings-import-nudge.service

* fix caching issue

* clean up

* refactor decryption, cleanup, update callers

* clean up

* Use in-memory statedefinition

* Ac/pm 12048 v next collection service pairing (#15239)

* Draft from pairing with Gibson

* Add todos

* Add comment

* wip

* refactor upsert

---------

Co-authored-by: Brandon <btreston@bitwarden.com>

* clean up

* fix state definitions

* fix linter error

* cleanup

* add test, fix shareReplay

* fix item-more-options component

* fix desktop build

* refactor state to account for null as an initial value, remove caching

* add proper cache, add unit test, update callers

* clean up

* fix routing when deleting collections

* cleanup

* use combineLatest

* fix ts-strict errors, fix error handling

* refactor Collection and CollectionView properties for ts-strict

* Revert "refactor Collection and CollectionView properties for ts-strict"

This reverts commit a5c63aab76.

---------

Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
 2025-07-23 19:05:15 -04:00
Bernd Schoolmann
7a24a538a4 [PM-23072] Remove legacy key support in auth code (#15350) 
* Remove legacy key support in auth code

* Fix tests
 2025-07-23 22:29:44 +02:00
Bryan Cunningham
4458a7306b update xs text size (#15680) 2025-07-23 16:00:37 -04:00
Jordan Aasen
fe1c040993 [PM-23789][PM-237090][PM-23791][PM-23792] - [Web][Desktop][Browser] - Do not import cards if policy is enabled (#15740) 
* restrict item types in import

* add comment

* fix spec

* fix dep

* clean up logic
 2025-07-23 10:37:40 -07:00
Jared Snider
e47e1f79d9 fix(ChangePasswordComp): [Auth/PM-23913] Extension popout now closes after a password change (#15681) 2025-07-23 12:58:44 -04:00
Jason Ng
aee23f7206 [PM-23722] remove previous change for the account security badge (#15739) 2025-07-23 12:29:40 -04:00
Ben Brooks
a74e95fbfe [CL-601] Replace default reset button to enable it in more browsers (#14974) 
* bb/pm-19497/replace default reset button to enable it in more browsers

* address feedback: add ngClass; improve accessibility

* add signals for form hover and input focus; compute showResetButton

* fix(style): [CL-601] Improve CSS per reviewer comments

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* fix: [CL-601] add ngForm; remove standalone attributes

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* fix: [CL-601] add translation strings

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* fix: [CL-601] Use message key in aria label

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* fix: [CL-601] Remove unnecessary aria-hidden attribute

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* fix: [CL-601] Remove unecessary ngForm attributes

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* fix: [CL-601] Add storybook description

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* fix: [CL-601] Match main for recent signal input changs

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

---------

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
 2025-07-23 09:17:47 -07:00
Tom
6b76581918 Removing the notifications feature flag and logic (#15551) 2025-07-23 09:51:02 -04:00
Nick Krantz
2f47add6f1 [PM-23596] Redirect to /setup-extension (#15641) 
* remove current redirection from auth code

* update timeouts of the web browser interaction

* add guard for setup-extension page

* decrease timeout to 25ms

* avoid redirection for mobile users + add tests

* add tests

* condense variables

* catch error from profile fetch

---------

Co-authored-by: Shane Melton <smelton@bitwarden.com>
 2025-07-22 17:08:09 -07:00
Oscar Hinton
c37965174b Migrate platform owned abstract service to strict ts (#15734) 2025-07-22 22:00:24 +02:00
Oscar Hinton
54f0852f1a Migrate auth abstract services to strict ts (#15732) 2025-07-22 22:00:07 +02:00
Oscar Hinton
c2bbb7c031 Migrate vault abstract services to strict ts (#15731) 2025-07-22 21:59:42 +02:00
Oscar Hinton
8aeeb92958 [PM-24030] Migrate abstract services in libs/common strict TS (#15727) 
Migrates the abstract classes in libs/common to be strict ts compatible. Primarily by adding abstract to every field and converting it to a function syntax instead of lambda.
 2025-07-22 11:48:00 -05:00
Justin Baur
a563e6d910 Add messaging & messaging-internal libraries (#15711) 2025-07-22 11:47:25 -04:00
Thomas Avery
e99abb49ec [PM-23621] Require userId for initAccount on the key-service (#15684) 
* require userID for initAccount on key service

* add unit test coverage

* update consumer
 2025-07-22 10:30:50 -05:00
cyprain-okeke
96f31aac3a [PM 18701]Optional payment modal after signup (#15384) 
* Implement the planservice

* Add the pricing component and service

* Add the change plan type service

* resolve the unit test issues

* Move the changeSubscriptionFrequency endpoint

* Rename planservice to plancardservice

* Remove unused and correct typos

* Resolve the double asignment

* resolve the unit test failing

* Remove default payment setting to card

* remove unnecessary check

* Property initialPaymentMethod has no initializer

* move the logic to service

* Move estimate tax to pricing service

* Refactor thr pricing summary component

* Resolve the lint unit test error

* Add changes for auto modal

* Remove custom role for sm

* Resolve the blank member page issue

* Changes on the pricing display
 2025-07-22 15:58:17 +01:00
✨ Audrey ✨
5290e0a63b [PM-19054] configure send with email otp authentication via cli (#15360) 2025-07-22 09:33:34 -04:00
Shane Melton
2a07b952ef [PM-24000] Convert string date values to Date objects for CipherExport types (#15715) 2025-07-22 09:32:00 -04:00