1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-10 21:50:15 +00:00
Commit Graph

24 Commits

Author SHA1 Message Date
Anders Åberg
acdc6b131a Removed extra cancelRequest in deinint 2025-03-04 12:12:32 +01:00
Anders Åberg
d999c31f42 changed timeout to be spec recommended maxium, 10 minutes, for now. 2025-03-04 11:45:24 +01:00
Anders Åberg
c02f81eb5a Change windowXy to a Record instead of [number,number] 2025-02-28 10:11:16 +01:00
Anders Åberg
1cef3ead6f remove dead code 2025-02-27 20:26:56 +01:00
Anders Åberg
316c7eb5d2 Use .error to log errors 2025-02-27 20:24:51 +01:00
Anders Åberg
a54442f7d2 Adjusted error logging 2025-02-27 20:23:15 +01:00
Anders Åberg
f1ad32d1cf Removed extra logging 2025-02-27 20:23:15 +01:00
Anders Åberg
82d84acde4 Update apps/desktop/macos/autofill-extension/CredentialProviderViewController.swift
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
2025-02-27 20:12:26 +01:00
Anders Åberg
437a81bb1e Update apps/desktop/macos/autofill-extension/CredentialProviderViewController.swift
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
2025-02-27 19:56:20 +01:00
Anders Åberg
b884871c9d tweaked logging 2025-02-20 16:19:39 +01:00
Anders Åberg
fbfd1638b3 Cleanup swift file 2025-02-20 16:14:39 +01:00
Anders Åberg
a8f63cb981 Passing position from native to electron 2025-02-20 00:26:13 +01:00
Anders Åberg
7555b49e3d Launching bitwarden if its not running 2025-02-18 22:58:06 +01:00
Anders Åberg
578802e465 Introduced observable 2025-02-17 16:10:16 +01:00
Anders Åberg
5f5f6a75b8 Cancel after 90s 2025-02-17 15:48:48 +01:00
Anders Åberg
f6ef7a3bef not working 2025-02-13 16:25:15 +01:00
Anders Åberg
1f4b22f604 a whole lot of wiring 2025-02-13 14:43:47 +01:00
Anders Åberg
350554f826 Remove logger 2025-02-12 23:37:37 +01:00
Anders Åberg
43e7e18c9c pick credential, draft 2025-02-12 23:15:40 +01:00
Anders Åberg
ddb73f9e41 This hides the swift UI 2025-01-29 17:13:10 +01:00
Anders Åberg
8d2fd7247e Add logging 2025-01-23 21:07:57 +01:00
Daniel García
51f6594d4b [PM-9473] Add messaging for macOS passkey extension and desktop (#10768)
* Add messaging for macos passkey provider

* fix: credential id conversion

* Make build.sh executable

Co-authored-by: Colton Hurst <colton@coltonhurst.com>

* chore: add TODO

---------

Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
Co-authored-by: Colton Hurst <colton@coltonhurst.com>
2024-12-19 09:00:21 +01:00
Andreas Coroiu
f16bfa4cd2 [PM-9035] desktop build logic to provide credentials to os on sync (#10181)
* feat: scaffold desktop_objc

* feat: rename fido2 to autofill

* feat: scaffold electron autofill

* feat: auto call hello world on init

* feat: scaffold call to basic objc function

* feat: simple log that checks if autofill is enabled

* feat: adding some availability guards

* feat: scaffold services and allow calls from inspector

* feat: create custom type for returning strings across rust/objc boundary

* chore: clean up comments

* feat: enable ARC

* feat: add util function `c_string_to_nsstring`

* chore: refactor and rename to `run_command`

* feat: add try-catch around command execution

* feat: properly implement command calling

Add static typing. Add proper error handling.

* feat: add autoreleasepool to avoid memory leaks

* chore: change objc names to camelCase

* fix: error returning

* feat: extract some helper functions into utils class

* feat: scaffold status command

* feat: implement status command

* feat: implement password credential mapping

* wip: implement sync command

This crashes because we are not properly handling the fact that `saveCredentialIdentities` uses callbacks, resulting in a race condition where we try to access a variable (result) that has already gotten dealloc'd.

* feat: first version of callback

* feat: make run_command async

* feat: functioning callback returns

* chore: refactor to make objc code easier to read and use

* feat: refactor everything to use new callback return method

* feat: re-implement status command with callback

* fix: warning about CommandContext not being FFI-safe

* feat: implement sync command using callbacks

* feat: implement manual password credential sync

* feat: add auto syncing

* docs: add todo

* feat: add support for passkeys

* chore: move desktop autofill service to init service

* feat: auto-add all .m files to builder

* fix: native build on unix and windows

* fix: unused compiler warnings

* fix: napi type exports

* feat: add corresponding dist command

* feat: comment signing profile until we fix signing

* fix: build breaking on non-macOS platforms

* chore: cargo lock update

* chore: revert accidental version change

* feat: put sync behind feature flag

* chore: put files in autofill folder

* fix: obj-c code not recompiling on changes

* feat: add `namespace` to commands

* fix: linting complaining about flag

* feat: add autofill as owner of their objc code

* chore: make autofill owner of run_command in core crate

* fix: re-add napi annotation

* fix: remove dev bypass
2024-12-06 16:31:30 +01:00
Andreas Coroiu
62112b99a9 [PM-9022] scaffold the extension and build pipeline (#9948)
* feat: add macos xcode project

* feat: add extension to mas build

* feat: use `after-sign` to avoid issues

Electron builder modifies the .plist in the extension which causes issues with the signing process. Copying and re-signing manually avoids this because it bypasses the electron builder for the extension

* feat: always clean build and add better error handling

* chore: add some logging to after-sign

* feat: automatically cleanup xcode build to avoid duplicate extensions

* docs: add information about managing extensions

* feat: add missing safari extension logging

* lint: allow macos filenames

* chore: add macos to platform ownership

* lint: add some additional allowed files

* feat: don't build autofill extension for MAS

* chore: ignore capital letters linting for all macos files

* chore: replace gulpfile with regular node script

* chore: add lint rules to script

* lint: fix remaining lint issues in script

* chore: tweak lint rule

* feat: remove desktop target

* fix: use new provisioning profile for dev extension

* Update to unblock CI builds

* chore: remove extension from masdev pack

This way we don't include the extension in any build and can avoid the signing issues it brings

* chore: add autofill as codeowner

* chore: remove xcuserdata

* chore: ignore xcuserdata

---------

Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Michał Chęciński <mchecinski@bitwarden.com>
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-13 15:54:35 +01:00