* Use typescript-strict-plugin to iteratively turn on strict
* Add strict testing to pipeline
Can be executed locally through either `npm run test:types` for full type checking including spec files, or `npx tsc-strict` for only tsconfig.json included files.
* turn on strict for scripts directory
* Use plugin for all tsconfigs in monorepo
vscode is capable of executing tsc with plugins, but uses the most relevant tsconfig to do so. If the plugin is not a part of that config, it is skipped and developers get no feedback of strict compile time issues. These updates remedy that at the cost of slightly more complex removal of the plugin when the time comes.
* remove plugin from configs that extend one that already has it
* Update workspace settings to honor strict plugin
* Apply strict-plugin to native message test runner
* Update vscode workspace to use root tsc version
* `./node_modules/.bin/update-strict-comments` 🤖
This is a one-time operation. All future files should adhere to strict type checking.
* Add fixme to `ts-strict-ignore` comments
* `update-strict-comments` 🤖
repeated for new merge files
Enables one of the recommended rules of @angular-eslint. Since this rule was fairly trivial to fix and has no QA effects it seemed reasonable to migrate all code.
* Creating a landing page for SM, where user can request access from admins
* moving files to better folder, also fixing UI
* updating file paths
* cleaning up the code
* Updating API request to be the new one, and fixing HTML
* Adding coowners
* Updating OrganizaitonId in the request model to be a Guid
* Update apps/web/src/app/secrets-manager/secrets-manager-landing/request-sm-access.component.ts
Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
* Update apps/web/src/app/layouts/product-switcher/navigation-switcher/navigation-switcher.component.ts
Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
* Update apps/web/src/app/layouts/product-switcher/navigation-switcher/navigation-switcher.component.ts
Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
* Suggested changes from Maceij and Thomas
* fixing merge issues
* fixing issues
* Fixing logic to match top bar
* updating file name to not start with a capital letter
* renaming folder
* updating names
* Getting around the lint issue
* fixing lint issues
* Changes requested by Vicky
* Maciej suggested changes
* Fixing comments
* Update apps/web/src/app/secrets-manager/secrets-manager-landing/sm-landing-api.service.ts
Thomas's suggested improvement
Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
* ui fixes
* New awesome changes, to include the scenario where a Provider user is logged in, and to handle if an admin needs instructions to enable SM for themselves
* renaming fuctions and variables
---------
Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
