1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-06 00:13:28 +00:00
Commit Graph

19334 Commits

Author SHA1 Message Date
Andreas Coroiu
b957a0c28f [PM-24646] Add licensed browser builds (#16252)
* feat: create separate bit licensed browser

* feat: refactor webpack config

* fix: mv2 build not working

* feat: add bit versions of all commands

* feat: add bit CI builds

* fix: scss missing from build
2025-09-04 08:21:50 +02:00
Nick Krantz
54eb54483f [PM-24797] Hidden custom fields for new ciphers (#16198)
* allow for hidden fields to be moved/edited when adding a cipher

* disable drag when the field cannot be edited
2025-09-03 21:16:56 -05:00
Patrick-Pimentel-Bitwarden
281918a7b9 feat(inactive-user-server-notification): [PM-25130] Inactive User Server Notify (#16151)
* feat(inactive-user-server-notification): [PM-25130] Inactive User Server Notify - Adds in tests and feature for notifying inactive users.

* feat(inactive-user-server-notification): [PM-25130] Inactive User Server Notify - Added feature flag.

* fix(inactive-user-server-notification): [PM-25130] Inactive User Server Notify - Implemented trackedMerge.
2025-09-03 17:01:45 -04:00
Stephon Brown
363d6bea44 [PM-24550] Remove Feature Flag Code for PM-12276 (#16173)
* tests: remove feature flag use in tests

* tests: remove breadcrumbingPolicyTests and add service tests

* refactor: remove event log use of flag from org-layout component

* refactor: remove new policy code from org-layout component

* refactor: remove event log use of flag from events component

* refactor: remove event log use from collection dialog component

* refactor: remove event log use from vault-header component

* refactor: remove event-log route logic for org-reporting

* refactor: remove logic from org-settings routing

* refactor: remove breadcrumbing function and from billing service

* refactor: remove ConfigService from DI for billing service

* refactor: remove new policy code from policy-edit component

* refactor: remove new policy code from policies component

* refactor: remove feature flag

* fix(Admin Console): revert to use of reactive observables pattern

* fix(Admin Console): remove type artifact from reversion
2025-09-03 19:28:15 +00:00
Maciej Zieniuk
3a62e9c2f1 [PM-21772] Show key connector domain for new sso users (#15381)
* Passed in userId on RemovePasswordComponent.

* Added userId on other references to KeyConnectorService methods

* remove password component refactor, test coverage, enabled strict

* explicit user id provided to key connector service

* redirect to / instead when user not logged in or not managing organization

* key connector service explicit user id

* key connector service no longer requires account service

* key connector service missing null type

* cli convert to key connector unit tests

* remove unnecessary SyncService

* error toast not showing on ErrorResponse

* bad import due to merge conflict

* bad import due to merge conflict

* missing loading in remove password component for browser extension

* error handling in remove password component

* organization observable race condition in key-connector

* usesKeyConnector always returns boolean

* unit test coverage

* key connector reactive

* reactive key connector service

* introducing convertAccountRequired$

* cli build fix

* moving message sending side effect to sync

* key connector service unit tests

* fix unit tests

* move key connector components to KM team ownership

* new unit tests in wrong place

* key connector domain shown in remove password component

* type safety improvements

* convert to key connector command localization

* key connector domain in convert to key connector command

* convert to key connector command unit tests with prompt assert

* organization name placement change in the remove password component

* unit test update

* show key connector domain for new sso users

* confirm key connector domain page does not require auth guard

* confirm key connector domain page showing correctly

* key connector url required to be provided when migrating user

* missing locales

* desktop styling

* have to sync and navigate to vault after key connector keys exchange

* logging verbosity

* splitting the web client

* splitting the browser client

* cleanup

* splitting the desktop client

* cleanup

* cleanup

* not necessary if condition

* key connector domain tests fix for sso componrnt and login strategy

* confirm key connector domain base component unit tests coverage

* confirm key connector domain command for cli

* confirm key connector domain command for cli unit tests

* design adjustments

removed repeated text, vertical buttons on desktop, wrong paddings on browser extension

* key connector service unit test coverage

* new linting rules fixes

* accept invitation to organization called twice results in error.

Web vault remembers it's original route destination, which we do not want in case of accepting invitation and Key Connector, since provisioning new user through SSO and Key Connector, the user is already accepted.

* moved required key connector domain confirmation into state

* revert redirect from auth guard

* cleanup

* sso-login.strategy unit test failing

* two-factor-auth.component unit test failing

* two-factor-auth.component unit test coverage

* cli unit test failing

* removal of redundant logs

* removal of un-necessary new lines

* consolidated component

* consolidated component css cleanup

* use KdfConfig type

* consolidate KDF into KdfConfig type in identity token response

* moving KC requiresDomainConfirmation lower in order, after successful auth

* simplification of trySetUserKeyWithMasterKey

* redirect to confirm key connector route when locked but can't unlock yet

---------

Co-authored-by: Todd Martin <tmartin@bitwarden.com>
2025-09-03 21:16:40 +02:00
Tom
4027b78e20 [PM-24101] Switching to use the orgKeys$ from the key service instead of getOrgKey (#15781)
* Switching to use the orgKeys$ from the key service instead of getOrgKey

* Using account service instead of state provider

* First try for fixing test cases

* fixing test cases

* PM-24101 fix identified by failing test

* Error checking on the orgId

* Private method did not need error check

* Setting OrganizationId type

* Fixing test cases for setting org id

* Moving the get of critical apps to the init

* The critical apps component was being set again

---------

Co-authored-by: voommen-livefront <voommen@livefront.com>
2025-09-03 14:18:50 -04:00
Shane Melton
b6ef7716da [PM-24243] Load config service feature flag into SDK client (#15855)
* [PM-24243] Load config service feature flag into SDK client during initialization

* [PM-24243] Bump sdk version

* [PM-24243] Update load_flags to use generic Map instead of strongly typed object

* [PM-24243] Pass entire feature states object into SDK

* [PM-24243] Bump SDK version

* [PM-24243] Fix failing test
2025-09-03 13:56:55 -04:00
Shane Melton
2de321d6e8 [PM-24796] Ensure the CipherView prototype is not lost within the cache Signal (#16267) 2025-09-03 09:34:35 -07:00
Justin Baur
73e8532ecc feat(tokens): Allow Inactive user authenticated API calls 2025-09-03 10:09:02 -04:00
Andy Pixley
bcd7eb746a [BRE-1006] Removing unused workflow: release-desktop-beta (#16263) 2025-09-03 09:58:49 -04:00
Nick Krantz
5967cf0539 [PM-14571] At Risk Passwords - Badge Update (#15983)
* add exclamation badge for at risk passwords on tab

* add berry icon for the badge when pending tasks are present

* remove integration wtih autofill for pending task badge

* add ability to override Never match strategy
- This is helpful for non-autofill purposes but cipher matching is still needed. This will default to the domain.

* add at-risk-cipher badge updater service

* Revert "add exclamation badge for at risk passwords on tab"

This reverts commit a9643c03d5.

* remove nullish-coalescing

* ensure that all user related observables use the same user.id

---------

Co-authored-by: Shane Melton <smelton@bitwarden.com>
2025-09-02 15:09:20 -05:00
Stephon Brown
a4fca832f3 [PM-22312] Resolve TS 5.8 errors (#16108)
* refactor: remove ts-strict-ignore and update

* refactor: remove ts-strict-ignore and update

* refactor: simplify if statement

* refactor: remove ts-strict-ignore and update

* refactor: add nullable union for interfaces
2025-09-02 15:15:38 -04:00
Nik Gilmore
232dd89814 [PM-19998] Add arrow icons to vault carousel component (#16041)
* Add arrow icons to vault carousel component

* Fix carousel next button and update tests

* Add new unit tests for back/next buttons

* Copy 'next' string from web/src/locales to browser/src/_locales

* Fix layout / spacing on carousel arrows

* Remove 'next' string from non-en locales

* Fix lint errors on carousel tests

* Add I18n provider to storybook for carousel

* Fix spacing for carousel button row

* Update carousel arrows to use small icon variant

* Add label attr to carousel buttons

* Add next string to locales  for Desktop
2025-09-02 11:48:46 -07:00
neuronull
048d8a5f79 Remove UseTreeWalkerApiForPageDetailsCollection feature flag (#16130)
* remove flag and instances of use

* feedback jprusik: additional removals of pageContainsShadowDomElements

* feedback jprusik: remove a stray logic branch
2025-09-02 08:46:30 -06:00
Brandon Treston
1ae5a7798d fix model creation (#16257) 2025-09-02 10:36:39 -04:00
Bernd Schoolmann
45d0e90607 Disallow biometric key over IPC (#16161) 2025-09-02 13:09:03 +02:00
Vincent Salucci
789d66ce88 [PM-22840] Update collection management settings copy (#16142)
* chore: update collection management settings, refs PM-22840

* Split the item deletion restriction description message into three parts to allow for italicized text in the middle.

---------

Co-authored-by: Rui Tome <rtome@bitwarden.com>
Co-authored-by: Rui Tomé <108268980+r-tome@users.noreply.github.com>
2025-09-01 17:19:36 +01:00
bw-ghapp[bot]
50849917b4 Autosync the updated translations (#16242)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-09-01 11:37:26 +00:00
bw-ghapp[bot]
a50a17005e Autosync the updated translations (#16244)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-09-01 11:37:11 +00:00
bw-ghapp[bot]
92661ed558 Autosync the updated translations (#16243)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-09-01 11:36:56 +00:00
bw-ghapp[bot]
215107e141 Autosync the updated translations (#16237)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-09-01 12:39:46 +02:00
bw-ghapp[bot]
852935b6a1 Autosync the updated translations (#16239)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-09-01 12:39:27 +02:00
bw-ghapp[bot]
9805f09cc8 Autosync the updated translations (#16238)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-09-01 12:39:22 +02:00
Nick Krantz
e4c75b3c49 Revert "PM-23386 Display autofill options after sync (#15906)" (#16222)
This reverts commit 8c51050eda.
2025-08-29 14:57:19 -05:00
Nick Krantz
de928e9ba1 Fix SDK typings (#16223)
* fix SDK typings for `uuidAsString`

* add `load_flags` to mock SDK instance
2025-08-29 14:27:49 -05:00
rr-bw
ec950853bc fix(2fa-recovery-code-error): [Auth/PM-19885] Better error handling when 2FA recovery code is invalid (#16145)
Implements better error handling when a user enters an invalid 2FA recovery code. Upon entering an invalid code:
- Keep the user on the `/recover-2fa` page (This also makes it so the incorrect code remains in the form field so the user can see what they entered, if they mistyped the code, etc.)
- Show an inline error: "Invalid recovery code"
2025-08-29 12:25:31 -07:00
Oscar Hinton
e0da2671b4 [PM-13374] Update all SDK uuids (#14962)
* fix: broken SDK interface

* Fix all compile errors related to uuids

* Fix browser desktop

* Fix tests

---------

Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
2025-08-29 13:09:33 -04:00
Github Actions
d57d653551 Bumped client version(s) 2025-08-29 15:40:20 +00:00
Thomas Rittson
381adf9305 Move max-old-space-size to .npmrc (#16192)
* Move max-old-space-size to .npmrc

* Remove redundant environment variables

* Add comment
2025-08-29 14:49:28 +02:00
Oscar Hinton
97ee61db00 Configure clippy (#16194)
Apply the same clippy configuration as we have in sdk-internal. bitwarden/sdk-internal@49f84e6/Cargo.toml#L91-L94

Adds FIXME comments to all existing violations. unwrap is bad as those will resullt in panics and crash the application. Unused async is ignored in napi since that would require changes to the js side which I don't want to deal with.
2025-08-29 08:27:50 -04:00
bw-ghapp[bot]
2b2912b1be Autosync the updated translations (#16207)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-29 11:16:03 +00:00
bw-ghapp[bot]
c2c57546ac Autosync the updated translations (#16209)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-08-29 11:00:17 +00:00
bw-ghapp[bot]
756169e572 Autosync the updated translations (#16208)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-08-29 10:51:31 +00:00
Oscar Hinton
63af0ad711 [CL-836] Extract base css variables (#14733)
* Extract base variables

* Get tw to consume font css variables
2025-08-29 10:43:38 +02:00
Github Actions
774505a89a Bumped Desktop client to 2025.8.3 2025-08-28 21:52:41 +00:00
Matt Andreko
5176fab8a0 Added explicit permissions to check-run (#15135) 2025-08-28 16:11:19 -04:00
Patrick-Pimentel-Bitwarden
c828b3c4f4 Auth/pm 23620/auth request answering service (#15760)
* feat(notification-processing): [PM-19877] System Notification Implementation - Implemented auth request answering service.

* test(notification-processing): [PM-19877] System Notification Implementation - Added tests.
2025-08-28 13:47:05 -04:00
Github Actions
3b5342dfb3 Bumped client version(s) 2025-08-28 16:58:09 +00:00
Jonathan Prusik
8aba7757ab [PM-25122] Top-layer inline menu population (#16175)
* cleanup inline menu content service

* move inline menu button and listElement to top-layer popovers

* update tests

* do not hidePopover on teardown

* watch all top layer candidates and attach event listeners to ensure they stay below the owned experience

* add extra guards to top page observers

* fix checks and cleanup logic

* fix typing issues

* include dialog elements in top layer candidate queries

* send extension message before showing popover
2025-08-28 12:50:57 -04:00
neuronull
2fe9f4b138 Fix copy labels and toasts for ssh key items in web and browser (#16154) 2025-08-28 10:42:29 -06:00
aj-bw
3202b56614 [bre-1089] mac desktop publish automation using fastlane (#16091)
* Use Fastlane to publish to Apple App Store

* Publish MacOS build number as artifact

* Download and source build number from artifact

* Refactor Fastlane file to use already existing builds in TestFlight

* fastfile changes, release workflow changes, gitignore addition

* reorder steps to after dist dir is created

* resolve pathing issue

* upload step path fix

* make comments more clear

* enable phased rollout, add auto-submit checkbox

* move logic from release to publish workflow

* configure dry run properly for MAS

* edit file for testing

* workflow testing

* verbose logging for debugging

* update to look at releases

* remove verbose flag for next test

* add verbose logging back

* disable precheck

* hardcode app v for test

* hardcode app v for testing

* additional test

* log build numbers

* remove testing values, prep for draft PR

* flip metadata bool for testing

* comment out branch check

* hardcode locales

* add metadata and locales change

* lane change

* more logging for finding build

* address logs feedback

* edit_live false

* testing

* extra logging from apple api

* testing

* workaround for attaching build attempt

* workaround patch update

* simplify and retest skip metadata true

* turn precheck true

* remove autosubmit checkbox, add live edit true for testing release notes formatting

* re-org dispatch, rename dir to release_notes, flip live edit to false

* another formatting attempt

* additional formatting changes

* account for double space, add dash to beginning

* different formatting approach

* format test

* simplified notes formatting test, double line after each period

* proper formatting

* rename file for rust linter

* remove testing comments

* remove default string from notes, logic to check for empty release notes in mas_publish, formatting

* add validation logic after publishing

---------

Co-authored-by: Micaiah Martin <github@sourcecodemt.com>
2025-08-28 10:53:17 -04:00
Ike
7bc04e2218 fix: do not fetch refresh token on sync during CLI login (#16155)
fix: fetching a refresh token on a full sync during api key login on cli caused rate limit issues. we no longer fetch a refresh token on login since we shouldn't need it.
2025-08-28 09:54:16 -04:00
Andreas Coroiu
ff64cf5063 Fix a cache race condition in local backed session storage (#16177)
* fix: cache race condition

* fix: typo and order

* feat: tweak log message
2025-08-28 13:30:57 +02:00
Jeffrey Holland
8c51050eda PM-23386 Display autofill options after sync (#15906)
* PM-23386 Display autofill options after sync

* Clear the cipher state instead of changing caching

* Fix `true` param that isn't needed anymore
2025-08-28 10:55:18 +02:00
Daniel Riera
cde4890e5e PM-24791 [Defect] White box behind Save login notification UI (#16112)
* PM-24791

* update snapshots
2025-08-27 19:34:35 +00:00
cd-bitwarden
1d5115f190 Making accessing a project only use one api call to getbyprojectid (#15854) 2025-08-27 13:51:02 -04:00
Alex
4dd7e0cafa Messages: unmark critical (#16146)
* Unmark as critical

* Revert "Unmark as critical"

This reverts commit 3fa79fc498.

* rename unmarkAsCriticalApp -> unmarkAsCritical
2025-08-27 09:41:42 -07:00
Vicki League
38f62a0149 [PM-25222] Fix svg alignment issues caused by new preflight defaults (#16181) 2025-08-27 12:40:16 -04:00
Addison Beck
5f7c0ae999 build: ensure new libraries are added to the root jest.config (#16166)
* Add missing libs to jest.config.js

Added 15 missing libraries to the jest projects array:
- libs/assets
- libs/client-type
- libs/core-test-utils
- libs/dirt/card
- libs/guid
- libs/logging
- libs/messaging-internal
- libs/messaging
- libs/serialization
- libs/state-test-utils
- libs/state
- libs/storage-core
- libs/storage-test-utils
- libs/tools/export/vault-export/vault-export-ui
- libs/user-core

This ensures all existing libraries with jest.config.js files are included in CI test runs.

* Update basic-lib generator to add new libs to jest.config.js

- Added updateJestConfig function that automatically adds new libraries to jest.config.js
- Function finds the appropriate alphabetical position for the new library
- Added comprehensive tests for the new functionality
- Ensures new libraries are included in CI test runs from creation

This prevents the issue where new libraries are created but their tests
are not run in CI because they are missing from the jest configuration.

* Fix import statements in state-definitions and deserialization-helpers tests

- Fixed ClientLocations import in state-definitions.spec.ts to use @bitwarden/storage-core instead of relative import
- Simplified deserialization-helpers.spec.ts import to use library root @bitwarden/serialization
2025-08-27 11:56:42 -04:00
Maciej Zieniuk
4c960906fa Account Recovery with Key Connector enabled not working prior to removal of Master Password (#15616) 2025-08-27 16:32:18 +02:00