1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 21:33:27 +00:00
Commit Graph

244 Commits

Author SHA1 Message Date
SmithThe4th
10c8a2101a [PM-12049] Remove usage of ActiveUserState from folder service (#11880)
* Migrated folder service from using active user state to single user state

Added extra test cases for encrypted folder and decrypted folders

Updated derived state to use decrypt with key

* Update callers in the web

* Update callers in the browser

* Update callers in libs

* Update callers in cli

* Fixed test

* Fixed folder state test

* Fixed test

* removed duplicate activeUserId

* Added takewhile operator to only make calls when userId is present

* Simplified to accept a single user id instead of an observable

* Required userid to be passed from notification service

* [PM-15635] Folders not working on desktop (#12333)

* Added folders memory state definition

* added decrypted folders state

* Refactored service to remove derived state

* removed combinedstate and added clear decrypted folders to methods

* Fixed test

* Fixed issue with editing folder on the desktop app

* Fixed test

* Changed state name

* fixed ts strict issue

* fixed ts strict issue

* fixed ts strict issue

* removed unnecessasry null encrypteed folder check

* Handle null folderdata

* [PM-16197] "Items with No Folder" shows as a folder to edit name and delete (#12470)

* Force redcryption anytime encryption state changes

* Fixed text file

* revert changes

* create new object with nofolder instead of modifying exisiting object

* Fixed failing test

* switched to use memory-large-object

* Fixed ts sctrict issue

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
Co-authored-by: bnagawiecki <107435978+bnagawiecki@users.noreply.github.com>
2025-01-02 17:16:33 -05:00
✨ Audrey ✨
b2af12ab24 [PM-15872] fix username generation character limit (#12329) 2024-12-10 11:08:01 -05:00
Matt Gibson
9c1e2ebd67 Typescript-strict-plugin (#12235)
* Use typescript-strict-plugin to iteratively turn on strict

* Add strict testing to pipeline

Can be executed locally through either `npm run test:types` for full type checking including spec files, or `npx tsc-strict` for only tsconfig.json included files.

* turn on strict for scripts directory

* Use plugin for all tsconfigs in monorepo

vscode is capable of executing tsc with plugins, but uses the most relevant tsconfig to do so. If the plugin is not a part of that config, it is skipped and developers get no feedback of strict compile time issues. These updates remedy that at the cost of slightly more complex removal of the plugin when the time comes.

* remove plugin from configs that extend one that already has it

* Update workspace settings to honor strict plugin

* Apply strict-plugin to native message test runner

* Update vscode workspace to use root tsc version

* `./node_modules/.bin/update-strict-comments` 🤖

This is a one-time operation. All future files should adhere to strict type checking.

* Add fixme to `ts-strict-ignore` comments

* `update-strict-comments` 🤖

repeated for new merge files
2024-12-09 20:58:50 +01:00
Daniel James Smith
98702d9f50 Fix the new send dropdown showing premium when it should not (#12242)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-12-04 09:59:06 -05:00
cd-bitwarden
0ff48aa345 [PM-12743] a11y changes to make new drop down list for send and vault accessible (#11717)
* updating new menus to allow tab + enter to submit the link/button

* Updating New actions to use button instead of a for accessibiity purposes

* refactor

* refactor

* test fix

* fixes

* fixing tests

* fixing test

* fixing tests

---------

Co-authored-by: --global <>
2024-12-02 10:30:38 -06:00
✨ Audrey ✨
ab21b78c53 [PM-15061] extract encryptors from generator service (#12068)
* introduce legacy encryptor provider
* port credential generation service to encryptor provider
2024-11-28 11:02:21 +01:00
Michal Vaněk
06b3c37f03 [PM-15167] Fix password generator ascii ambiguous sets (#12143)
Co-authored-by:  Audrey  <ajensen@bitwarden.com>
2024-11-25 10:46:17 -05:00
Daniel James Smith
03aa4fd4d8 [PM-13667] Add button to open credential history on web (#12100)
* Create CredentialGeneratorHistoryDialogComponent to be re-used on web and desktop

* Add button to open credential histpry on web

* Add button to open credential history on desktop (#12101)

- Register route to open new CredentialGeneratorHistoryDialogComponent when FeatureFlag/GeneratorToolsModernization is enabled
- Add button to credential generator
- Add missing keys to en/messages.json

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-11-22 18:29:30 +01:00
Daniel James Smith
a9f570be06 Fix toggle entry not displaying correctly on non-English clients (#12088)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-11-21 18:37:29 +00:00
Bernd Schoolmann
38c4eeb27d [PM-14542] Move kdf to km ownership (#11877)
* Move kdf to km ownership

* Fix duplicate import

* Remove whitespace

* Fix double imports

* Fix desktop build

* Fix test error

* Fix imports

* Move ownership of kdftype to km

* Fix imports

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-21 13:45:28 +01:00
✨ Audrey ✨
3521c54672 [PM-14964] revert passphrase minimum (#12019)
* revert passphrase minimum
* add recommendation text to browser refresh;  hide hint text when value exceeds recommendation
* migrate validators to generator configuration
2024-11-18 13:43:03 -06:00
✨ Audrey ✨
48294aac86 invert ambiguous character flag (#12004) 2024-11-14 15:55:19 -05:00
✨ Audrey ✨
642b8d2e6b [PM-14838] upgrade generator account storage to ObjectKey storage (#11975) 2024-11-14 10:09:59 -05:00
Daniel James Smith
e341a66a2e Add autofocus to search field on Send page (#11979)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-11-13 15:15:48 +01:00
✨ Audrey ✨
ba82a31851 [PM-14001] do not store last value when it is 0 (#11964) 2024-11-11 15:43:50 -05:00
✨ Audrey ✨
a5294bed3d [PM-12338] fix length hint on passphrase num words field (#11963) 2024-11-11 14:23:02 -05:00
✨ Audrey ✨
888b9e346c fix length allowing negative values on Chrome extension (#11926) 2024-11-11 16:48:32 +01:00
✨ Audrey ✨
b2811e07ce [PM-14198] zero minimums when the character category is disabled (#11906) 2024-11-07 21:23:01 +01:00
Daniel James Smith
872f36752f [PM-13876] Generator PR review follow up (#11885)
* Remove unused regex

* Remove viewChild reference from markup

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-11-07 09:03:54 -05:00
✨ Audrey ✨
414bdde232 [PM-13876] replace angular validation with html constraints validation (#11816)
* rough-in passphrase validation failure handling

* trigger valid change from settings

* fix `max` constraint enforcement

* add taps for generator validation monitoring/debugging

* HTML constraints validation rises like a phoenix

* remove min/max boundaries to fix chrome display issue

* bind settings components as view children of options components

* remove defunct `okSettings$`

* extend validationless generator to passwords

* extend validationless generator to catchall emails

* extend validationless generator to forwarder emails

* extend validationless generator to subaddress emails

* extend validationless generator to usernames

* fix observable cycle

* disable generate button when no algorithm is selected

* prevent duplicate algorithm emissions

* add constraints that assign email address defaults
2024-11-06 17:54:29 +01:00
✨ Audrey ✨
8af0b6e380 [PM-14190] Replace history card with item component (#11775) 2024-10-30 09:43:18 -04:00
✨ Audrey ✨
9a83509183 add boundary help text to credential settings (#11757) 2024-10-28 15:55:16 -04:00
Jordan Aasen
b5e509409b fix remove password icon (#11752) 2024-10-28 20:27:59 +01:00
✨ Audrey ✨
a9d667900f colorize password history (#11754) 2024-10-28 15:19:17 -04:00
✨ Audrey ✨
71db154856 default subaddress email to active account email (#11755) 2024-10-28 15:18:57 -04:00
Jordan Aasen
2e3ad82b60 fix icon placement in password input (#11720) 2024-10-28 10:20:55 +01:00
Jordan Aasen
e3f9035564 [PM-14022] - change send link to disabled (#11721)
* change send link to disabled

* change send link to disabled
2024-10-28 10:17:15 +01:00
✨ Audrey ✨
c780cbc77e use valueLabel with appCopyClick directive (#11718)
* add `valueLabel` to `appCopyClick` directives 
* move generated value description to the configuration
2024-10-25 23:43:49 +02:00
Jordan Aasen
ad7fa71e76 [PM-13931] - UI - All applications report table (#11678)
* add remaining components to access intelligence page

* Revert "add remaining components to access intelligence page"

This reverts commit cb8e826656.

* add remaining access intelligence table components
2024-10-25 13:04:36 -07:00
Daniel James Smith
10a662cc35 [PM-14002] Fix username generator from vault item (#11714)
* Fix "Forwarded email alias" not showing in drop-down

* Fixed username and forwarder options not showing
Options were being translated twice

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-25 12:15:48 -04:00
Daniel James Smith
3b82a82416 [PM-13658] Update copy of password history to generator history (#11710)
* Update copy from password history to generator history

* Update copy on empty state

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-25 11:04:39 -04:00
Jordan Aasen
adabc59c03 show New password after removing a password (#11697) 2024-10-25 13:33:04 +02:00
✨ Audrey ✨
0254550b07 increase minimum number of words on passphrases to 6 (#11675) 2024-10-24 15:16:10 -04:00
Bernd Schoolmann
b486fcc689 [Pm-13097] Rename cryptoservice to keyservice and move it to km ownership (#11358)
* Rename cryptoservice to keyservice

* Rename cryptoservice to keyservice

* Move key service to key management ownership

* Remove accidentally added file

* Fix cli build

* Fix browser build

* Run prettier

* Fix builds

* Fix cli build

* Fix tests

* Fix incorrect renames

* Rename webauthn-login-crypto-service

* Fix build errors due to merge conflicts

* Fix linting
2024-10-24 19:41:30 +02:00
✨ Audrey ✨
d5643f42b3 [PM-13723] track history in generator components (#11673)
* add history support to generator components
* increase generator history length
2024-10-23 21:38:26 +02:00
✨ Audrey ✨
a2a15d42d5 add test ids (#11674) 2024-10-23 20:58:49 +02:00
✨ Audrey ✨
22be52d2f3 [PM-12303] fix password state spurious emissions (#11670)
* trace generation requests
* eliminate spurious save caused by validator changes
* fix emissions caused by setting bounds attrbutes
---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-23 14:23:28 -04:00
✨ Audrey ✨
a8299e7040 fix generate a11y binding (#11671) 2024-10-23 14:17:24 -04:00
✨ Audrey ✨
eff9a423da [PM-8280] email forwarders (#11563)
* forwarder lookup and generation support
* localize algorithm names and descriptions in the credential generator service
* add encryption support to UserStateSubject
* move generic rx utilities to common
* move icon button labels to generator configurations
2024-10-23 18:11:42 +02:00
Nick Krantz
c4fcd53ad2 [PM-13776] Generator Icon Button labels (#11623)
* update aria labels for generate and copy buttons within the generator components

- Using the `appA11yTitle` across all icon buttons
- Updated all labels to be targeted towards the credential type rather than just "password"

* add copy/generate passphrase translations to desktop

* add fixme comments for translations

* remove reference to JIRA ticket
2024-10-23 10:23:51 -05:00
Jordan Aasen
ecc597110b [PM-13809] - add remove password button (#11641)
* add remove password button

* adjust comment

* use bitAction directive
2024-10-21 22:36:27 +02:00
Jordan Aasen
c89d8a00a1 fix voiceover on send created screen (#11628) 2024-10-21 20:50:50 +02:00
Daniel James Smith
d298ac6edf [PM-13189] Send copy updates (#11619)
* Add more descriptive header text

* Update hint under optional password field

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-21 10:10:57 -04:00
Nick Krantz
80a4fba787 Allow for the web generation dialog to disable the margin of the tools generation components (#11565) 2024-10-18 15:57:34 -05:00
Jordan Aasen
288b0cff2f fix send options viewsLeft (#11594) 2024-10-17 15:28:02 +02:00
Daniel James Smith
783305696a Fix stories title for card-component (#11562)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-17 09:22:56 -04:00
Jordan Aasen
6e37047776 account for possible null value (#11589) 2024-10-16 21:11:43 +02:00
Jordan Aasen
87545e4d21 fix logic for displaying hide email in send options (#11561) 2024-10-15 20:48:51 +02:00
Nick Krantz
e5ca6fd460 wrap generate & copy buttons in a flex container, flex containers do not wrap by default (#11558) 2024-10-15 11:06:36 -05:00
Nick Krantz
15e5a6d747 update heading level on password generator (#11556) 2024-10-15 17:16:00 +02:00