1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-17 09:59:41 +00:00
Commit Graph

2899 Commits

Author SHA1 Message Date
Patrick Pimentel
aa9bae6146 fix(extension-device-approval): [PM-14943] Answering Service Full Implementation - Active user id will no longer throw. 2025-09-02 15:58:33 -04:00
Patrick Pimentel
d283c7e10d Merge remote-tracking branch 'origin/inactive-account-api-calls' into auth/pm-14943/auth-request-extension-dialog-approve 2025-08-29 16:07:15 -04:00
Justin Baur
115351e650 Allow Inactive user authenticated API calls 2025-08-29 15:32:12 -04:00
Patrick Pimentel
ce5a16f686 fix(extension-device-approval): [PM-14943] Answering Service Full Implementation - Added Justin's change and things seem to be working better. Still broken on new account. 2025-08-29 15:29:05 -04:00
Patrick Pimentel
43fe8f36d9 Merge branch 'auth/pm-25130/inactive-user-server-notification' into auth/pm-14943/auth-request-extension-dialog-approve 2025-08-29 11:48:08 -04:00
Oscar Hinton
63af0ad711 [CL-836] Extract base css variables (#14733)
* Extract base variables

* Get tw to consume font css variables
2025-08-29 10:43:38 +02:00
Patrick Pimentel
5eea93228b fix(inactive-user-server-notification): [PM-25130] Inactive User Server Notify - Renamed file to match linting pattern. 2025-08-28 16:44:00 -04:00
Patrick Pimentel
865ffa2739 fix(inactive-user-server-notification): [PM-25130] Inactive User Server Notify - Fixed tests and updated with Justin's comments. 2025-08-28 16:35:19 -04:00
Patrick Pimentel
38aaf2ba86 fix(extension-device-approval): [PM-14943] Answering Service Full Implementation - Lots of debug statements added. Seeing unknown error closing connection. 2025-08-28 16:18:08 -04:00
Patrick Pimentel
83faf0a8b2 Merge remote-tracking branch 'origin' into auth/pm-14943/auth-request-extension-dialog-approve 2025-08-28 15:40:34 -04:00
Patrick Pimentel
d944ae12ca fix(extension-device-approval): [PM-14943] Answering Service Full Implementation - Minor changes to default server notifications service. 2025-08-28 15:35:26 -04:00
Patrick Pimentel
7d853aa5c9 fix(extension-device-approval): [PM-14943] Answering Service Full Implementation - Minor changes to default server notifications service. 2025-08-28 15:34:28 -04:00
Patrick Pimentel
805d58ad30 Merge remote-tracking branch 'origin' into auth/pm-25130/inactive-user-server-notification 2025-08-28 14:57:36 -04:00
Patrick Pimentel
e04daf3a9c fix(extension-device-approval): [PM-14943] Answering Service Full Implementation - Restructuring some code, adding comments. 2025-08-28 14:55:17 -04:00
Patrick-Pimentel-Bitwarden
c828b3c4f4 Auth/pm 23620/auth request answering service (#15760)
* feat(notification-processing): [PM-19877] System Notification Implementation - Implemented auth request answering service.

* test(notification-processing): [PM-19877] System Notification Implementation - Added tests.
2025-08-28 13:47:05 -04:00
neuronull
2fe9f4b138 Fix copy labels and toasts for ssh key items in web and browser (#16154) 2025-08-28 10:42:29 -06:00
Jeffrey Holland
8c51050eda PM-23386 Display autofill options after sync (#15906)
* PM-23386 Display autofill options after sync

* Clear the cipher state instead of changing caching

* Fix `true` param that isn't needed anymore
2025-08-28 10:55:18 +02:00
Vicki League
38f62a0149 [PM-25222] Fix svg alignment issues caused by new preflight defaults (#16181) 2025-08-27 12:40:16 -04:00
Addison Beck
5f7c0ae999 build: ensure new libraries are added to the root jest.config (#16166)
* Add missing libs to jest.config.js

Added 15 missing libraries to the jest projects array:
- libs/assets
- libs/client-type
- libs/core-test-utils
- libs/dirt/card
- libs/guid
- libs/logging
- libs/messaging-internal
- libs/messaging
- libs/serialization
- libs/state-test-utils
- libs/state
- libs/storage-core
- libs/storage-test-utils
- libs/tools/export/vault-export/vault-export-ui
- libs/user-core

This ensures all existing libraries with jest.config.js files are included in CI test runs.

* Update basic-lib generator to add new libs to jest.config.js

- Added updateJestConfig function that automatically adds new libraries to jest.config.js
- Function finds the appropriate alphabetical position for the new library
- Added comprehensive tests for the new functionality
- Ensures new libraries are included in CI test runs from creation

This prevents the issue where new libraries are created but their tests
are not run in CI because they are missing from the jest configuration.

* Fix import statements in state-definitions and deserialization-helpers tests

- Fixed ClientLocations import in state-definitions.spec.ts to use @bitwarden/storage-core instead of relative import
- Simplified deserialization-helpers.spec.ts import to use library root @bitwarden/serialization
2025-08-27 11:56:42 -04:00
Maciej Zieniuk
4c960906fa Account Recovery with Key Connector enabled not working prior to removal of Master Password (#15616) 2025-08-27 16:32:18 +02:00
Nick Krantz
fcc2bc96d1 [PM-21024] Use Server for Password Change URLs (#14912)
* migrate change login password service to use bitwarden server rather than fetch directly

- avoids CSP entirely

* add `HelpUsersUpdatePasswords` policy to policy type

* add `HelpUsersUpdatePasswordsPolicy` components

* allow list description override for policy description

* add `HelpUsersUpdatePasswordsPolicy` when the feature flag is enabled

* apply `HelpUsersUpdatePasswords` to everyone in an org

* use policy to guard the well known password API

* fix tests

* refactor to use `policyAppliesToUser$`

* remove policy work for change password - this was removed from scope

* update copy for show favicon setting - it now handles both favicons and change password urls

* remove favicon setting description - no longer needed

* only call change password service when the setting is enabled

* add popover for permitting cipher details

* import permit popover directly into the settings component

* replace `nativeFetch` with `fetch`

* use string literal to construct URL rather than `URL` class
- The `getIconsUrl` can return with an appended path which the new URL constructor will strip when passed as the base parameter

* use string literal to construct URL rather than `URL` class instance (#16045)

- The `getIconsUrl` can return with an appended path which the new URL constructor will strip when passed as the base parameter

* [PM-24716] UI changes for Change URI work (#16043)

* use platform service to launch the URI
- this allows desktop to open a separate browser instance rather than use electron

* fix spacing on web app

* add bitLink for focus/hover states

* remove spacing around links
2025-08-27 09:03:44 -05:00
Patrick Pimentel
e96ff92053 Merge branch 'auth/pm-23620/auth-request-answering-service' into auth/pm-14943/auth-request-extension-dialog-approve 2025-08-26 17:53:35 -04:00
Patrick Pimentel
1300a03091 Merge branch 'auth/pm-25130/inactive-user-server-notification' into auth/pm-14943/auth-request-extension-dialog-approve 2025-08-26 17:52:17 -04:00
Patrick Pimentel
978906d156 Merge remote-tracking branch 'origin' into auth/pm-23620/auth-request-answering-service 2025-08-26 17:09:00 -04:00
Patrick Pimentel
82a053358f Merge remote-tracking branch 'origin' into auth/pm-25130/inactive-user-server-notification 2025-08-26 16:46:22 -04:00
neuronull
34cd41988a Remove EnableNewCardCombinedExpiryAutofill feature flag (#16131) 2025-08-26 12:44:08 -06:00
Brandon Treston
28b5a2bb5e [PM-22717] Expose DefaultUserCollectionEmail to clients (#15643)
* enforce restrictions based on collection type, set default collection type

* fix ts strict errors

* fix default collection enforcement in vault header

* enforce default collection restrictions in vault collection row

* enforce default collection restrictions in AC vault header

* enforce default collection restriction for select all

* fix ts strict error

* switch to signal, fix feature flag

* fix story

* clean up

* remove feature flag, move check for defaultCollecion to CollecitonView

* fix test

* remove unused configService

* fix test: coerce null to undefined for collection Id

* clean up leaky abstraction for default collection

* fix ts-strict error

* fix parens

* add new property to models, update logic, refactor for ts-strict

* fix type

* rename defaultCollection getter

* clean up

* clean up

* clean up, add comment, fix submit

* add comment

* add feature flag

* check model for name

* cleanup readonly logic, remove featureflag logic

* wip

* refactor CollectionRequest into Create and Update models

* fix readonly logic

* cleanup

* set defaultUserCollectionEmail in decryption from Collection

* split save into update/create methods

* fix readonly logic

* fix collections post and put requests

* add defaultUserCollection email to model when submitting collection dialog
2025-08-26 11:42:52 -04:00
Todd Martin
ad2dfe1e99 feat(notifications): [PM-19388] Enable push notifications on locked clients
* Add back notifications connection on locked accounts

* Updated tests.

* Make sure web push connection service is started synchronously

* Fixed merge conflicts.

---------

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
2025-08-26 11:41:15 -04:00
Jordan Aasen
9ed69ef4b8 [PM-24304][PM-24305] - [Defect] Some fields are not disabled when editing an item from My Vault (#15982)
* disable all remaining form fields for editing personally owned My Items

* fix failing tests

* ensure collection field is also properly disabled

* clean up logic

* fix failing test

* fix test

* refactor variable to avoid using `is` prefix

* directly reference parent form for status rather than subscribe to it

* refactor subscription for form status changes

* use observable as an Output

* disable attachment button on desktop vault when the form

* disable custom field components when custom fields already exist and parent form is disabled

* disable attachments button in the browser when the edit form is disabled

* grab icon button instance for disabled state

---------

Co-authored-by: Nick Krantz <nick@livefront.com>
2025-08-25 15:48:00 -07:00
Patrick Pimentel
5b94a80d5b feat(browser-approval): [PM-23620] Auth Request Answering Service - Moved implementation of the tags for server notifications. 2025-08-25 17:17:28 -04:00
Jordan Aasen
ae2259db2f [PM-17723] - [Web | Browser | Desktop] Cannot search for port in vault login item URI (#15962)
* add port search in uriExtractor

* revert to original check
2025-08-25 14:07:22 -07:00
Patrick Pimentel
bd028cce47 fix(inactive-user-server-notification): [PM-25130] Inactive User Server Notify - Fixed dep. 2025-08-25 16:31:39 -04:00
Patrick Pimentel
6f1661e247 feat(inactive-user-server-notification): [PM-25130] Inactive User Server Notify - Added feature flag. 2025-08-25 16:24:04 -04:00
Patrick Pimentel
aa7984cfb7 feat(inactive-user-server-notification): [PM-25130] Inactive User Server Notify - Adds in tests and feature for notifying inactive users. 2025-08-25 15:37:09 -04:00
Justin Baur
5f7f1d1924 Resolve state <-> state-test-utils circular dependency (#16093)
* Resolve state <-> state-test-utils circular dependency

* Fix type errors
2025-08-25 12:38:28 -04:00
Patrick Pimentel
23859e96ee test(extension-device-approval): [PM-14943] Answering Service Full Implementation - Added tests for default server notification service. 2025-08-25 12:32:52 -04:00
Vicki League
777b92660a [CL-706] Display all svg icons in Storybook (#16111) 2025-08-25 12:09:20 -04:00
Maciej Zieniuk
5b402d9c38 cleanup remove password on start for desktop (#15957) 2025-08-22 23:14:02 +02:00
Patrick Pimentel
854a2333c2 feat(extension-device-approval): [PM-14943] Answering Service Full Implementation - Can respond to requests that came in from the background now. 2025-08-22 15:49:14 -04:00
Shane Melton
65230a9c3e [PM-24229] Preserve existing cipher date fields when using CipherExport.toView (#15993)
* [PM-24229] Ensure existing dates are persisted when using CipherExport.toView

* [PM-24229] Test both null and undefined

* [PM-24229] Add test for copied date values
2025-08-22 12:21:23 -07:00
Vicki League
dd4ec9c5d9 [CL-735][CL-743] Finish migrating form control components to signals (#15927) 2025-08-22 15:17:14 -04:00
Nick Krantz
9ecf2686e5 [PM-22987] Hide download for corrupt attachments (#16023)
* spelling fix

* hide download button for corrupt attachments

* add missing translations for desktop
2025-08-22 12:38:35 -05:00
Jason Ng
6e9da95230 [PM-22371] remove end user activation flag (#16067) 2025-08-22 12:56:16 -04:00
Shane Melton
4676a122da [PM-24143] Search performance improvements (#16070)
* [PM-24143] Add perUserCache$ to SearchService index$

* [PM-24143] Cleanup and optimize isSearchable

* [PM-24143] Remove unused search flags and subscription from the vault-items component

* [PM-24143] Add search text for desktop vault items. Consolidate SearchTextDebounceInterval constant to SearchService

* [PM-24143] Ensure cipher search indexing is non-blocking

* [PM-24143] Remove redundant index ciphers operation

* [PM-24143] Add search performance measurements

* [PM-24143] Remove artificial delay

* [PM-24143] Remove startWith from index$ to avoid basic search with lunr queries

* [PM-24143] Re-organize isSearchable to check long lunr queries for index existence
2025-08-22 09:32:36 -07:00
Bryan Cunningham
eb84faaf99 [CL-825] Provide dimensions to checkbox to fix ios rendering bug (#16109)
* absolutely position checkbox to fix ios rendering bug

* remove absolute positioning. Dimensions fix it
2025-08-22 10:01:23 -04:00
Daniel García
92c9aa7b3e Use FakeStateProvider in SdkService tests (#16126) 2025-08-22 15:19:18 +02:00
Daniel García
12df7def61 [PM-19479] Client-Managed SDK state definition (#14839)
* [PM-19479] Client-Managed SDK state definition

* Remove test code

* Update based on latest sdk

* Add DB config

* Remove uuid conversion step

* Move mapper into separate file

* Revert to client managed state

* Move mapper to Cipher

* Typo

---------

Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
2025-08-22 14:21:52 +02:00
Thomas Avery
a6e7efddeb [PM-23627] Require publicKey for keyService getFingerprint (#15933)
* require public key on keyService getFingerprint

* Update consumers and add error handling & logging
2025-08-21 15:49:19 -05:00
Vicki League
805b6fe7aa [CL-573] Move all svg icons to new libs/assets (#16020)
* create libs/assets

* treeshake lib and filter out non-icons from icon story

* update docs

* fix icon colors in browser and desktop

* better name for vault icon

* move illustrations
2025-08-21 11:35:59 -05:00
Kyle Denney
f07518084f [PM-24554] remove code for feature flag (#16092) 2025-08-21 09:36:57 -05:00