1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 16:53:34 +00:00
Commit Graph

11725 Commits

Author SHA1 Message Date
Addison Beck
83305313f9 [bug] Properly define stored window state (#638) 2022-01-27 10:44:09 -05:00
Joseph Flinn
f0c47252e4 Updating the base Docker image for testing purposes (#1411) 2022-01-27 07:25:13 -08:00
Oscar Hinton
0186610ca4 Change the icon baseline to 14% (#637) 2022-01-27 15:31:13 +01:00
Vincent Salucci
0a2ebf6e50 [Icons] Fix source paths (#636)
Co-authored-by: Hinton <oscar@oscarhinton.com>
2022-01-27 11:21:32 +01:00
Daniel James Smith
5353cf03b5 BEEEP: Add importer for Keeper in json format (#608)
* Add testdata, create types for keeperjson import

* Create keeperjson importer and tests

* Register, Create instance of keeperjson importer

* Move keeperCsvImporter to keeperImporters folder

* Fixed import of BaseImporter

* Removed unnecessary check for key

* Move instantiation of importer into beforeEach

* Fixed the second import with a wrong path

* Adjust types based on new test export

* Add test case for empty notes and custom fields

* Implement logic for failed test case

* Removed test expectation
2022-01-26 23:04:55 +01:00
Addison Beck
058be7e895 [bug] Disable the preferences screen if there is no active unlocked vault (#1270) 2022-01-26 12:32:00 -05:00
Matt Gibson
1b409653a2 Fix/bitwarden serve (#454)
* Handle null passedOptions

* Require authentication to use `bs serve`
2022-01-26 10:28:56 -06:00
Addison Beck
ff7dd4ad8f [bug] Don't monitor vault timeout action valueChanges until after init (#1271) 2022-01-26 09:33:37 -05:00
Danny Murphy
2ffe3bd6ad Cleanup of the SCSS Variables (#1255)
* Clean up variable names and comments

* Fix Option Colour - issue #1338

* Update old scss variable name

Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
2022-01-26 14:54:15 +10:00
Addison Beck
9271ec37b9 [bug] Ensure remembering email always happens for desktop (#1269)
* [bug] Ensure remembering email always happens for desktop

* update jslib
2022-01-25 19:00:49 +01:00
Addison Beck
4722a287ec [bug] Ensure clients that always remember emails have an avenue to do so (#635) 2022-01-25 12:34:11 -05:00
Vincent Salucci
946fc20674 [Icons] Global variable update (#632)
* [Icons] Global variable update

* Reverted to base class in order to reduce redundant css

* Adjusted comment
2022-01-25 09:58:53 -06:00
Addison Beck
d80fdc8a78 Adjust an iterator used to check for locked vaults on reloadProcess (#1268) 2022-01-25 09:49:57 -05:00
Oscar Hinton
e1d4c4c903 Expose getKeyFromStorage with userId (#633) 2022-01-25 15:45:02 +01:00
Addison Beck
555ee1c230 [bug] Checkout all vaults before reloading process (#1267) 2022-01-25 09:36:30 -05:00
Daniel James Smith
aa8fe04a28 [UX] Change menu items for unauthed and locked vault (#2285)
* Change menu items for unauthed and locked vault

* Use 'Log in' instead of 'Login'
2022-01-25 08:17:01 +01:00
Daniel James Smith
71913a5eb5 Update badge number when saving a new entry (#2284)
* Rename message to changePasswordMessage

* Rename message variable to addLoginMessage

* Add early return and remove unneeded if below

* Update badge and menu after adding an entry

* Adjusted casing of enum properties

* Add explicit check for queueMessageType

* Turn NotificationQueueMessageType into simple enum
2022-01-25 08:16:36 +01:00
Vincent Salucci
a985621bb9 [Icons] Update font sheet (#582)
* Initial commit for icon update

* Updated lg to reflect current usage

* Created BitwardenIconsService

* Prettier updates

* More prettier updates

* Updated font

* Prettier

* Added new icons to service map

* Removed variables and converted css to use scss maps and exported list

* Updated font sheet (130)

* Removed base class and replaced bolt icon

* Added 3x icon size

* Added sm text size helper

* Added rotate 270 helper

* Prettier

* Updated font sheet

* Requested Changes

* Removed BitwardenIcons Util - obsolete
2022-01-24 15:40:04 -06:00
Daniel James Smith
af7da0e942 Ensure that initialization and migration only run once (#631) 2022-01-24 20:37:52 +01:00
Addison Beck
c458b4d8a9 [bug] Move enableBrowserIntegration to global settings (#1265)
* [bug] Move enableBrowserIntegration to global settings

* [style] Ran prettier

* [chore] Update jslib
2022-01-24 11:35:24 -05:00
Addison Beck
e5cc3de46d [bug] Move enableBrowserIntegration to global state (#630) 2022-01-24 10:47:41 -05:00
Oscar Hinton
7d46e5c145 Add explicit init to native messaging service (#1262) 2022-01-24 16:10:32 +01:00
Addison Beck
ca41cdf8b5 [chore] Update jslib (#1264) 2022-01-24 08:45:35 -05:00
Addison Beck
4436e5fb60 [bug] Ensure globals set before migration is run are not lost (#629)
* [bug] Ensure globals set before migration is run are not lost

Some fields, like biometrics, are set before we can run the state migration
For some use cases, like initial install, this can lead to migration clearing those fields when it doesn't find them in storage.
This commit sets up an order of checks for migrating globals that considers fields that may already have been set.

* [style] Ran prettier
2022-01-24 08:22:21 -05:00
Addison Beck
1747f4d9e7 [bug] Set all urls when setting urls from storage (#628) 2022-01-24 07:28:51 -05:00
Addison Beck
d211b3fcd2 Unset active account when adding additional accounts (#1258) 2022-01-24 07:28:39 -05:00
Addison Beck
ef48ba1ae2 [bug] Correct DI setup for SystemService (#1257)
The DI refactor created a bad initlizer for SystemService that left out the reload callback.
This callback is null in prod, so I just set up a factory initlizer that used null for the callback value.

This fixes a bug causing clipboard clearing to not function, as platformUtilsService was not correctly injected.
2022-01-22 15:24:12 -05:00
Robyn MacCallum
07a3a1ea06 Merge pull request #2282 from bitwarden/beeep/remove-sad-faces
Replace sad face with searching image
2022-01-21 14:37:45 -05:00
Robyn MacCallum
33704b016f Beeep/remove sad faces (#1255)
* Replace sad face with searching image

* Change css variable name

* Added aria-hidden="true" to images

* Run prettier
2022-01-21 14:37:28 -05:00
Addison Beck
074f1ee7b7 [bug] Set envUrls after assigning defaults during scaffolding (#627) 2022-01-21 13:35:14 -05:00
Addison Beck
9b0e5ae456 [bug] Address existing data & defaults when migrating from an unauthenticated state (#626) 2022-01-21 12:41:15 -05:00
Oscar Hinton
a64273f829 Hide account switcher border if no accounts (#1254) 2022-01-21 17:57:09 +01:00
Matt Gibson
21e8db9636 Create testing framework for CLI (#453)
* Create testing framework for CLI

- Need to add tsconfig for specs to convert module format and add spec
dir to output
- Use jasmine-ts to test

expected dev cycle would be to have two watchers, one for jslib
and one for CLI tests. We could add jslib tests to this jasmine config,
but it feels wrong to test a submodule

* Run prettier

* Add tests to build pipeline

* Include required package

* Add placeholder test

* Run prettier

* Add nodemon and fix watch
2022-01-21 10:28:36 -06:00
Robyn MacCallum
4d63769d42 Run prettier 2022-01-21 11:23:01 -05:00
Robyn MacCallum
5c4bcf86a7 Added aria-hidden="true" 2022-01-21 11:21:23 -05:00
Addison Beck
69fe7b8339 [bug] Always set environementUrls from client when scaffolding an account (#624)
There is a use case that overrides locally set environmentUrls: an initial boot of a logged out application.
We override environmentUrls with whatever the tempory settings store has, even if different urls are added before authenticating.
This commit ensures we always use input environmentUrls.
2022-01-21 11:14:34 -05:00
Matt Gibson
e1bdd2a95c watch ts files and source directly (#623) 2022-01-21 10:11:00 -06:00
Robyn MacCallum
879b983818 Replace sad face with searching image 2022-01-21 10:31:01 -05:00
Oscar Hinton
f387a4d469 Remove old u2f connector (#1406) 2022-01-21 15:00:53 +01:00
Daniel James Smith
cb4e6debf3 Fix display of account limit (#1253) 2022-01-21 14:15:24 +01:00
github-actions[bot]
a0f1b4dd0d Autosync the updated translations (#1404)
Co-authored-by: github-actions <>
2022-01-21 11:53:09 +01:00
github-actions[bot]
f0dc5aa458 Autosync the updated translations (#2278)
Co-authored-by: github-actions <>
2022-01-21 11:52:06 +01:00
github-actions[bot]
2e7f8a127d Autosync the updated translations (#1250)
Co-authored-by: github-actions <>
2022-01-21 11:51:41 +01:00
Thomas Rittson
84a65edc08 Move keyConnectorService call to syncService (#1405) 2022-01-21 19:33:09 +10:00
Thomas Rittson
c6eaf3a31e Move KeyConnector call from client to syncService (#1252) 2022-01-21 19:32:44 +10:00
Daniel James Smith
37b03b09a1 [Account Switching] Design changes to settings menu (#1244)
* Design changes to settings menu

* Remove black border on settings headers

* Pull in jslib

* Only load account related settings when authed

* Hide account related settings when not authed

* Change settings titles

* Changes discussed with Danielle
2022-01-20 22:56:15 +01:00
Addison Beck
025a4a5e38 [bug] Index search service when setting decrypted ciphers (#620)
With the move to a central StateService we erroniously cut out search indexing from the process of setting decrypted ciphers to memory.
This commit calls the method responsible for setting decrypted ciphers and indexing when decrypting, instead of setting decrypted ciphers directly.
2022-01-20 16:25:04 -05:00
Matt Gibson
19bf7c75a3 Use node-ts and jasmine-ts to run tests (#621)
* Use node-ts and jasmine-ts to run tests

* prettier

* Add tsconf-paths module
2022-01-20 14:07:13 -06:00
Thomas Rittson
8b650666c5 Fix migration to Key Connector (#452)
* Move Key Connector check to subclass

* Move authService.logout call to main program

* Move Key Connector migration check to unlock command

* Use get/setConvertAccountRequired flag

* Move Key Connector convert to own command, set usesKeyConnector after conversion

* Remove KC conversion check from syncCommand, fix callback

* Make class service private

* Fix naming convention

* Update jslib and deps
2022-01-21 06:03:37 +10:00
Addison Beck
cf1e483c7f [bug] Account for entityId as a userId alternative during state migration (#622)
Some clients, like Directory Connector, use different key for their user identifier: entityId
We currently only check for userId in the migration service, but need to account for both.
2022-01-20 14:00:58 -05:00