1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 13:23:34 +00:00
Commit Graph

4707 Commits

Author SHA1 Message Date
cd-bitwarden
d57050f1da [PM-18767] Using new dialog for adding/editing name of folder in Desktop (#14049)
* Using new dialog for adding/editing name of folder in Desktop

* removing unecessary changes

* removing the template for AppFolderAddEdit

* Fixing the issue where it doesn't know the nested folder info

* lint fixes and removing uneeded param

* removing uneeded messages.json entry

* Updating the vault-v2 file to use the new folder dialog component

* Fixing the merge commit
2025-05-15 16:50:49 -04:00
renovate[bot]
de03e3ef25 [deps]: Update Rust crate tokio to v1.45.0 (#14506)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-15 13:22:54 -07:00
sportshead
0d19432f14 fix(browser): use appCopyField instead of appCopyClick for singleCopiableLogin (#14692)
Fixes #14167

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-05-15 15:54:41 -04:00
Jason Ng
ee4c3cfd94 [PM-21663] nudge service name refactor (#14789)
* update names of vault nudge service and their corresponding files, convert components using showNudge$ to instead target spotlight and badges directly with new observables. Core logic for dismiss remains the same
2025-05-15 15:10:38 -04:00
Daniel Riera
82d0925f4e PM-21620 finalize a11y UX concerns for option selection (#14777)
* PM-21620 finalize a11y UX concerns for option selection

* SR should announce that the button has a menu popup collapsed and expanded when they open it

* support up and down keys -close menu when other menu expanded

* dynamic aria label

* type safety

* instanceOf to replace as Node for type

* default aria hidden prop that can be overridden

* update mock and make message more descriptive

* Update apps/browser/src/autofill/content/components/icons/collection-shared.ts

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>

---------

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
2025-05-15 13:32:05 -04:00
Jordan Aasen
b30faeb62b [PM-21554] - Creating a new item while editing edits the item (#14770)
* fix adding new cipher while editing a cipher

* don't set updatedCipherView if the cached cipher has an id and the new one doesn't

* fix cipher form config
2025-05-15 10:09:51 -07:00
Oscar Hinton
ac49e594c1 Add standalone false to all non migrated (#14797)
Adds standalone: false to all components since Angular is changing the default to true and we'd rather not have the angular PR change 300+ files.
2025-05-15 10:44:07 -04:00
Will Martin
a0429d7d09 [CL-622][CL-562][CL-621][CL-632] various drawer improvements (#14120)
- add focus trap to drawers
- add config to open existing dialogs as drawers
- make drawer take up fill width/height on smaller screens
2025-05-15 10:32:52 -04:00
Daniel García
0b65861cb1 [PM-8297][PM-955] Improve updater behavior (#14732)
* [PM-8297] Improve updater behavior

* Remove logs

* Unused args

* Test version number

* Revert "Test version number"

This reverts commit 39ef057662.
2025-05-15 13:28:04 +02:00
Y
5b864e4a73 [PM-20588] Fixed app description (#14395)
* Update electron-builder.json

* Update according to change given by trmartin4

https://github.com/bitwarden/clients/pull/14395#issuecomment-2836796307
2025-05-14 21:31:44 -04:00
renovate[bot]
6e5a1f184e [deps] Platform: Update Rust crate widestring to v1.2.0 (#14488)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-14 09:30:51 -07:00
renovate[bot]
b611fdfb62 [deps] Platform: Update Rust crate windows-registry to v0.5.1 (#14489)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-14 08:52:14 -07:00
cyprain-okeke
1a1481bbd6 Resolve the tiny line issue (#14758) 2025-05-14 16:01:03 +01:00
SmithThe4th
ad3121f535 [PM-12423] Migrate Cipher Decryption to Use SDK (#14206)
* Created mappings for client domain object to SDK

* Add abstract decrypt observable

* Added todo for future consideration

* Added implementation to cipher service

* Added adapter and unit tests

* Created cipher encryption abstraction and service

* Register cipher encryption service

* Added tests for the cipher encryption service

* changed signature

* Updated feature flag name

* added new function to be used for decrypting ciphers

* Added new encryptedKey field

* added new function to be used for decrypting ciphers

* Manually set fields

* Added encrypted key in attachment view

* Fixed test

* Updated references to use decrypt with feature flag

* Added dependency

* updated package.json

* lint fix

* fixed tests

* Fixed small mapping issues

* Fixed test

* Added function to decrypt fido2 key value

* Added function to decrypt fido2 key value and updated test

* updated to use sdk function without prociding the key

* updated localdata sdk type change

* decrypt attachment content using sdk

* Fixed dependency issues

* updated package.json

* Refactored service to handle getting decrypted buffer using the legacy and sdk implementations

* updated services and component to use refactored version

* Updated decryptCiphersWithSdk to use decryptManyLegacy for batch decryption, ensuring the SDK is only called once per batch

* Fixed merge conflicts

* Fixed merge conflicts

* Fixed merge conflicts

* Fixed lint issues

* Moved getDecryptedAttachmentBuffer to cipher service

* Moved getDecryptedAttachmentBuffer to cipher service

* ensure CipherView properties are null instead of undefined

* Fixed test

* ensure AttachmentView properties are null instead of undefined

* Linked ticket in comment

* removed unused orgKey
2025-05-14 07:30:01 -07:00
Vincent Salucci
3e0cc7ca7f [PM-18627] Remove customization settings popover (#14713)
* chore: remove customization popover strings, refs PM-18627

* chore: delete new settings callout ts/html component, refs PM-18627

* chore: remove new customization code from vault-v2 component, refs PM-18627:
:q

* chore: delete vault-page service, refs PM-18627

* chore: add state migration to remove data, refs PM-18627
2025-05-14 09:26:47 -05:00
Jason Ng
d68574fc40 [PM-21395] Vault Nudges Bugs (#14737)
* updates to empty vault and has items nudges
2025-05-13 16:49:41 -04:00
Daniel Riera
393926beec PM-21605 Remove Login text from error notification (#14767) 2025-05-13 20:10:33 +00:00
Daniel Riera
d50db0d0dd [PM-21441] Defect - Notification bar sometimes gets cut off in fill dev (#14764)
* PM-21441

* revert default value
2025-05-13 20:08:43 +00:00
Oscar Hinton
bacd1fb999 [PM-17407] [CL-665] Remove jQuery and Popper.js (#14621)
Now that the last usages of ModalService is removed from the web portions we can finally remove jQuery and Popper.js. This PR also removes bootstrap js imports since it would drag in jQuery as a peer dependency.

Note: Both dependencies still exists in the lockfile as they are peer dependencies of boostrap.
2025-05-13 21:36:26 +02:00
Vijay Oommen
1cc06fd3b9 [PM-20999] Styling corrections to Access Intelligence - Part 2 (#14552) 2025-05-13 14:29:23 -05:00
Vijay Oommen
896c9bd583 [PM-20997] Part 1 of PM-20117 - Styling Changes (#14527) 2025-05-13 13:59:03 -05:00
Vicki League
b3df8a6c13 [PM-17091][PM-17043] Support system zoom in browser extension (#14435) 2025-05-13 14:16:18 -04:00
cyprain-okeke
5fb46df341 [PM 21106]Remove button not responsive for admin Console Remove Sponorship (#14743)
* Resolve the remove button inactive

* Resolve the lint error
2025-05-13 16:49:06 +01:00
Jason Ng
1f72dd7710 PM-21286 add aria label to nudge settings badge (#14750) 2025-05-13 11:30:36 -04:00
SmithThe4th
0750ff38f5 Route to vault page when user doesn't have access (#14633) 2025-05-13 11:21:07 -04:00
Oscar Hinton
9a7089594e [PM-19878] Add core-js to cli (#14696)
* Add core-js to cli

* Add core-js to bit-cli
2025-05-13 16:59:56 +02:00
Todd Martin
4c68f61d47 feat(CLI-SSO-Login): [Auth/PM-21116] CLI - SSO Login - Add SSO Org Identifier option (#14605)
* Add --identifier option for SSO on CLI

* Add option for identifier

* Moved auto-submit after the setting of client arguments

* Adjusted comment

* Changed to pass in as SSO option

* Renamed to orgSsoIdentifier for clarity

* Added more changes to orgSsoIdentifier.
2025-05-13 10:58:48 -04:00
Patrick-Pimentel-Bitwarden
0b0397c3f0 fix(enums-eslint): Enum Rule for ESLint (#14650)
* fix(enums-eslint): Enum Rule for ESLint - Added enums in the warnings for eslint.

* fix(enums-eslint): Enum Rule for ESLint - Updated to error in both places for enums.

* fix(enums-eslint): Enum Rule for ESLint - Added new eslint plugin for warning on enums.

* fix(enums-eslint): Enum Rule for ESLint - Changed based on suggestion.

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* refactor(browser-platform-utils): Remove Deprecation and Fix Code - Changed usages of firefox to private and moved the usages to the preferred public method and removed the deprecations.

* fix(enums-eslint): Enum Rule for ESLint - Updated to error and added disable rules for all other places.

* fix(enums-eslint): Enum Rule for ESLint - Undid other changes by accident
2025-05-13 10:07:38 -04:00
Bernd Schoolmann
b2c118d607 Move admin-console code to new encrypt service interface (#14547) 2025-05-13 15:41:57 +02:00
Alex Morask
992b1456a8 Send SkipTrial = true to organization create when trial length is 0 (#14701) 2025-05-13 09:31:47 -04:00
Alex Morask
4cf6e19b30 Estimate tax for trial initiation flow when trial length is 0 (#14674) 2025-05-13 09:28:25 -04:00
Oscar Hinton
7a51161d50 Move selectable avatar to auth (#14704) 2025-05-13 12:43:26 +02:00
Daniel Riera
02cbc37ac5 PM-20397 Misc notification bar UI tweaks (#14558)
* PM-20637

* turncate save button
2025-05-12 21:23:06 +00:00
Daniel Riera
63b224f3dd PM-21454 Firefox - "null" text is showing in Add/Update Confirmation notification (#14745)
* PM-21454

* Update apps/browser/src/autofill/content/components/lit-stories/mock-data.ts

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>

* Update apps/browser/src/autofill/content/components/lit-stories/mock-data.ts

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>

* Update apps/browser/src/autofill/content/components/notification/confirmation/container.ts

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>

* run lint

---------

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
2025-05-12 17:03:09 -04:00
renovate[bot]
9af7963609 [deps] Vault: Update @koa/multer to v3.1.0 (#14495)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Nick Krantz <125900171+nick-livefront@users.noreply.github.com>
2025-05-12 14:58:48 -05:00
renovate[bot]
7d01c42e37 [deps] Vault: Update multer to v1.4.5-lts.2 (#14469)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
2025-05-12 15:42:21 -04:00
Jordan Aasen
ce8e123c44 [PM-21480] - check for privacy granted in isBrowserAutofillSettingOverridden (#14748)
* check for privacy granted in isBrowserAutofillSettingOverridden

* check for privacy granted in browserAutofillSettingsOverridden
2025-05-12 12:17:15 -07:00
Todd Martin
eed18c9294 chore(view-cache): [PM-21154] Move view-cache its own feature package and adjust imports
* Moved view-cache services to directory

* Fixed DI for browser extension.

* Fixed tests.
2025-05-12 14:26:52 -04:00
cyprain-okeke
a10b9530af changes to sponsorship is showing in individual vault (#14627) 2025-05-12 18:20:56 +01:00
Jonathan Prusik
2487e9b98d [PM-20637] Trigger password reprompt when updating a reprompt cipher via notification (#14575)
* reprompt user on cipher update when enabled

Co-authored-by: Daniel Riera <driera@livefront.com>

* update tests

* add test

---------

Co-authored-by: Daniel Riera <driera@livefront.com>
2025-05-12 11:13:49 -04:00
renovate[bot]
89b9ba21ca [deps] Platform: Update Rust crate arboard to v3.5.0 (#14484)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-12 07:15:06 -07:00
renovate[bot]
57ed1e7285 [deps] Platform: Update @types/node to v22.15.3 (#14723)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-12 10:09:40 -04:00
Bernd Schoolmann
aca8ab8e40 [PM-21001] Move autofill code to new encrypt service interface (#14548)
* Move autofill code to new encrypt service interface

* Fix test runner
2025-05-12 15:31:03 +02:00
Patrick-Pimentel-Bitwarden
87b875c48b docs(update-auth-approving-clients): [PM-17111] Add Browser to List of Approving Clients - Updated comments. (#14707) 2025-05-12 09:29:11 -04:00
Bryan Cunningham
4d15f2d43c [PM-16057] use Roboto as primary font (#14553)
* swap to using roboto variable font
2025-05-12 09:00:01 -04:00
Matt Andreko
fcaf5e63c5 Duo URL redirect enhancements (#14640)
* Provide additional scrutiny on Duo redirect filtering

* Address review feedback from Jared

* Add documentation to redirectToDuoFrameless method
2025-05-12 07:56:50 -04:00
Bernd Schoolmann
5408a62b7d [PM-21001] Move KM usage of encrypt service (#14541)
* Add new encrypt service functions

* Undo changes

* Cleanup

* Fix build

* Fix comments

* Move KM usage of encrypt service

* Fix build
2025-05-12 11:41:45 +02:00
Jordan Aasen
23d4f04b22 set cipher form to partial edit for non edit permission (#14639) 2025-05-09 17:51:34 -07:00
Justin Baur
1b756df749 [PM-14484] ApiService showing html in error message (#14658)
* Make ApiService more testable

* Add ApiService tests

* Switch to only reading text/plain content
2025-05-09 20:21:25 -04:00
Miles Blackwood
5470d6a6d9 Fix i18n key mis-entry. (#14711) 2025-05-09 17:30:32 -04:00