* Simplify if to reduce nesting
* Start subscribing to changes of the vaultSelector as soon as possible during ngOnInit
---------
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* Completed feature flag grouping
* Added organization of default value section.
* Clarified comment.
* Removed flag
* Removed merge error that duplicated comment.
* Update TestFlight deployment to use Fastlane for app uploads
* Update TestFlight deployment to use Fastlane for app uploads
* Fix
* Fix create secret for fastlane
* Fix create secret for fastlane
* Fix create secret for fastlane
* Install gsed to use sed on macos runner
* Create test file
* Fix test
* Use actual token
* Add TestFlight distribution option for QA testing
* Update .github/workflows/build-desktop.yml
Co-authored-by: MtnBurrit0 <77340197+mimartin12@users.noreply.github.com>
* Add if to secret construction for fastlane
---------
Co-authored-by: MtnBurrit0 <77340197+mimartin12@users.noreply.github.com>
* docs: fix a typo
* fix(browser): restore timer-based background syncs
The browser extension was not performing scheduled background syncs every 30 minutes as expected. This was due to missing task scheduling code that was accidentally removed during the web push implementation (PR #11346).
This commit:
- Creates a new BackgroundSyncService to manage sync scheduling
- Properly initializes the sync interval in main.background.ts
- Adds a test to ensure the sync initialization code isn't accidentally removed again
- Organizes platform module structure to support the new service
Fixes PM-19396
* review: remove unecassary await keyword
Remove deprecated TwoFactorComponentsV1 and TwoFactorOptionsComponentV1 components, related functionality (unauthUiRefreshSwap) and orphaned styles/translation messages.
* vault filter use SingleUserState
* fixing tests
* Changes so that userId is passed to service, instead of access in service
* passing activeUserId from the components to service
* Sugggested changes
* updating functions to be abstract on vault-filter.service
* updating all functions to be abstract on vault filter service
* do not import ssh keys when rehydrating exported data
* Remove import_ssh_key sdk function from toView
---------
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* [CL-550] Fix popup layout padding and adjust views with extra bottom space
* simplify css
* fix add/edit item page
* cr changes
* fix failing test
---------
Co-authored-by: Will Martin <contact@willmartian.com>
Recently the policy service was refactored and some method signatures were
changed. One of these changes involved renaming the `getAll` observable to
`policiesByType`.
This was not merged into the metadata provider work before it was merged, so
those changes were committed using removed method signatures.
This commit updates these references.
* Add new export format: zip
* Restrict zip export to just individual vaults
* Add tests
* Remove unused import
* Fix build error
* Fix tests
* Fix test
* Fix retrieval of ciphers by passing in activeUserId
* Guard feature behind `export-attachments`-feature-flag
* Extend cipher filter to also filter out any ciphers that are assigned to an organization
* Added apiService to retrieve AttachmentData (metaData) and then download the attachment
- Added ApiService as a depdency within DI for VaultExportService/IndividualVaultExportService
- Added unit tests for filtering ciphers
- Added unit test for downloading attachment metadata and attachments
* Moved attachment decryption into a separate method and added unit tests
* Added null check for creating the base attachment folder
* Move format check for zip within Org export into an early return/throw
* Add feature flag guard on the CLI
* Extend ExportScopeCallout to display an individual export will contain attachment when zip-format is selected
* Fix adding/removing the zip-export option based on selected vault and state of `export-attachments` feature-flag
* Separate AAA visually using whitespace within tests
* Remove unused error var
* Write test that verifies different http request failures when retrieving attachment data
* Remove uneeded ignore lint rule
* Rewrite test to actually check that ciphers assigned to an org are filtered out
* Introduce ExportedVault return type (#13842)
* Define ExportedVault type unioned by 2 new types that describe a plain-text export vs a blob-based zip-export
* Extend static getFileName to handle formats and add unit-tests
* Introduce new export return type throughout the vault export module
- Update abstractions
- Update return types within implementations
- Update callers/consumers to handle the new return value
- Fix all unit tests
* Add support for new export return type and fix download of blobs via CLI
* Add documentation to public methods
---------
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
---------
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>