1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-06 00:13:28 +00:00
Commit Graph

18063 Commits

Author SHA1 Message Date
Brandon Treston
6037c583eb remove feature flag (#13677) 2025-03-04 14:53:02 -05:00
Todd Martin
fb4fff09e1 [PM-17933] Improve Github Actions dependency update process in Renovate (#13234)
* Renamed to JSON5

* Renovate config to group actions by team.

* Corresponding CODEOWNERS changes.

* Updated linting script to use new file name.

* Added note to check CODEOWNERS before changing.

* Added json5 dependency.

* Updated comments for package grouping.

* A few comment adjustments.

* Removed minor-only grouping and Platform cargo prefix.

* Added comments.

* Added back new line to remove extra change in PR.

* Removed package rule for patch to move to base config.
2025-03-04 14:37:59 -05:00
Jared Snider
17393050b5 fix(NewUIExtensionTitleTranslation): [Auth/PM-18710] Fix extension having incorrect verifyIdentity (#13667) 2025-03-04 13:30:46 -05:00
Daniel James Smith
2b29bf8c23 Move SendAddEditDialog from web to bitwarden/send-ui (#13679)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-03-04 13:24:00 -05:00
Colton Hurst
3bd60786b1 Move SSH Agent Files to Autofill Ownership (#13473)
* Move SSH agent files to Autofill ownership

* Fix ssh-agent.service.ts imports
2025-03-04 12:31:36 -05:00
Jason Ng
f7642aa0c6 [PM-14423] item view security task (#13485)
* show pending change password tasks for ciphers in extension
2025-03-04 12:18:40 -05:00
Daniel James Smith
bfbad99fb7 [PM-12681] Enable new Send Add/Edit Dialog on web (#13361)
* Create web-specific new-send-dropdown component

* Create web-specifc Send Add/Edit dialog

* Use new-send-dropdown and replace old Send Add/Edit with new Add/Edit dialog

* Delete old Send Add/Edit component

* Remove unused entries from en/messages.json

* Add cancel button to close dialog

* Remove unused RouterLink

* Fix typechecking issue

* Use observable to show/hide premium badge

* Add documentation

* Move assignment of observable into ctor, as it no longer requires a promise for assignment

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-03-04 10:09:37 -05:00
Bernd Schoolmann
0d68d22b98 Prevent password from being used on safari biometric unlock (#13289) 2025-03-04 12:06:57 +01:00
Thomas Rittson
56c8c2ccc8 [PM-13326] Move Collections tab to AC Team (#13529) 2025-03-03 22:18:42 +00:00
Jordan Aasen
13213585b2 [PM-17820] - Browser/Web - update button and label state in username generator (#13189)
* add event handling for username generator

* fix specs. change function name to not be of an event type

* update specs

* rename function

* revert name change

* fix spec

* bubble algorithmSelected up to generator components. add disabled button tests

* add typeSelected event

* revert addition of onType.

* apply same logic in onAlgorithmSelected to web and desktop
2025-03-03 11:44:34 -08:00
Matt Andreko
d01f0c6bc4 Replace secret checking logic with branch detection logic (#13642) 2025-03-03 14:19:43 -05:00
Zihad
0c61a44d33 [PM-18413] Fix SSH agent initial prompt issues (#13468)
* fix: set `needs_unlock` default value to true on unix

closes #13323

* fix: ssh prompt not appearing right after unlocking vault

---------

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
Co-authored-by: Colton Hurst <colton@coltonhurst.com>
2025-03-03 14:05:18 -05:00
✨ Audrey ✨
e10b5af9d3 [PM-16791] introduce generator profile provider (#13588) 2025-03-03 12:43:34 -05:00
Jared Snider
92f027af5e fix(LoginComp + LoginStrategies): [Auth/PM-18654] Refreshed UI - Desktop TDE JIT provisioned user creation errors with missing org SSO id (#13619)
* PM-18654 - State Service & Login Strategy Refactor - move env seeding into login strategy so that new accounts always load w/ the correct environment

* PM-18654 - SSO Comp - just use user id from auth result

* PM-18654 - Config Service - (1) don't allow cascading calls to the renewConfig by using a private promise (2) Replace shareReplay with share configured with manual timer

* PM-18654 - LoginComponents - detail issue and possible fix

* PM-18654 - DesktopLoginV1Comp - use correct destroy hook

* PM-18654 - LoginComp - clean up no longer correct comment

* PM-18654 - New Device Verification Component - Remove unused PasswordLoginStrategy dependency

* PM-18654 - Browser Home Component - fix qParam logic

* PM-18654 - DefaultConfigService - revert changes as they aren't necessary to fix the bug.

* PM-18654 - DefaultConfigService - remove commented code

* PM-18654 - LoginStrategy - add comment

* PM-18654 - Fix login strat tests
2025-03-03 12:09:35 -05:00
Daniel Riera
b5b791f414 PM-18471-migrated all messages to catalog (#13618)
* PM-18471-migrated all messages to catalog

* updated error message
2025-03-03 11:36:31 -05:00
Shane Melton
5b215cf193 [PM-18707] Fix desktop live sync (#13624)
* [PM-18707] Remove redundant cipherService subscription

* [PM-18707] Add artificial tick delay to cipherService to allow for ElectronStore storage service to fully save before continuing
2025-03-03 08:33:48 -08:00
Oscar Hinton
325fdc3f3a [PM-18659] Remove console logs from importers unit tests (#13583)
* Remove console logs from importers unit tests

* Add fixme
2025-03-03 15:59:50 +00:00
Oscar Hinton
a7a5a2771e Remove runOnlyPendingTimers (#13581) 2025-03-03 16:51:08 +01:00
renovate[bot]
08b6da3f4e [deps]: Update dtolnay/rust-toolchain digest to c5a29dd (#13659)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
2025-03-03 12:26:38 +01:00
cyprain-okeke
98008149ae resolve the tailwind css class issue (#13629) 2025-03-01 07:18:12 +01:00
Daniel Riera
45fa07c89b PM-18522 Adjust Confirmation UI text to accommodate truncating (#13639)
* PM-18522 adjust styling

* add text to action button

* address type errors and fix storybook
2025-02-28 14:21:27 -05:00
Oscar Hinton
37cf88d041 [CL-604] Add ngPreserveWhitespace to fix badge padding (#13626) 2025-02-28 14:02:03 -05:00
Daniel Riera
f12456bd3e Pm 18493 pass relevant cipher name into confirmation UI (#13570)
* PM-18276-wip

* update typing

* dynamically retrieve messages, resolve theme in function

* five second timeout after save or update

* adjust timeout to five seconds

* negligible performance gain-revert

* sacrifice contorl for to remove event listeners-revert

* PM-18493 initial wip commit

* fix types and story

* edit tests to account for sendmessagewithdata

* add tests and return id on new add/save

* function name
2025-02-28 13:14:15 -05:00
Matt Gibson
40f7a0d73f Parse web push payload JSON (#13594) 2025-02-28 17:53:43 +00:00
Alec Rippberger
7da329da45 fix(ui): [PM-18719] fix endless spinner on read key button
This resolves an issue where the WebAuthn setup component's read key button would show a loading spinner indefinitely. The fix addresses problems with Signal handling for the bitButton component's disabled/loading states.

JIRA: PM-18719
2025-02-28 11:39:50 -06:00
Brandon Treston
24410cd672 replace icon buttons with text buttons (#13615) 2025-02-28 12:03:54 -05:00
Bernd Schoolmann
7ba8dd98e6 Validate parameters in encrypt service tests (#13630) 2025-02-28 17:15:06 +01:00
Jared Snider
c9e20687ef fix(ExtensionAnonLayoutWrapperComponent): [Auth/PM-18574] add inline flex to logo so it vertically centers (#13546) 2025-02-28 10:51:15 -05:00
Jared Snider
a3f692ee59 Fix(ExtensionAccountSwitcherComponent): [Auth/PM-11684] Fix missing typography import (#13544) 2025-02-28 10:46:16 -05:00
Jared Snider
f12e8ed583 feat(ExtensionCurrentAccountComponent): [Auth/PM-12766] adjust screen reader text per ticket (#13541) 2025-02-28 10:44:48 -05:00
Todd Martin
a4ff5436bf [PM-18617] Revert Firefox back to build Mv2 (#13620)
* Revert changes to build Mv3 on Firefox.

* Revert script changes.
2025-02-28 10:14:36 -05:00
Jake Fink
43f5423e78 [PM-12606] Move Vault Timeout and Vault Timeout Settings to KM (#13405)
* move vault timeout and vault timeout settings to km

* move browser vault timeout service to km

* fix cli import

* fix imports

* fix some relative imports

* use relative imports within common

* fix imports

* fix new imports

* Fix new imports

* fix spec imports
2025-02-28 09:55:03 -05:00
Bernd Schoolmann
0ee2e0bf93 [PM-18697] Increase test coverage for encrypt service and symmetric crypto key (#13628)
* Increase coverage for EncryptService and SymmetricCryptoKey

* Re-add missing test
2025-02-28 14:20:31 +01:00
Maciej Zieniuk
c80019e919 [PM-18680] biometric's no client key half provided for user (#13609)
* biometric's no client key half provided for user

Biometric's client key half can be optional (null) when the password is not required on start of the application

* improved unit test coverage

* ipc setClientKeyHalf can be null
2025-02-28 14:05:16 +01:00
bw-ghapp[bot]
8176515c57 Autosync the updated translations (#13623)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-02-28 12:57:17 +01:00
bw-ghapp[bot]
f3c0389d42 Autosync the updated translations (#13622)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-02-28 12:08:05 +01:00
bw-ghapp[bot]
90d66b93b1 Autosync the updated translations (#13621)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-02-28 10:31:23 +01:00
Vijay Oommen
0b6828a72b [PM-18456] Display unassigned items in reports (#13612) 2025-02-27 14:49:13 -06:00
Daniel James Smith
eaeea195e4 Added permission check for organizational unsecure website (#13611)
Only display the cipher's name if the user running the report does not have permissions to view/edit the cipher

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-02-27 20:55:38 +01:00
Daniel James Smith
407368b3ea [PM-18706] Added permission check for organizational inactive 2fa report (#13610)
* Added permission check for organizational inactive 2fa report

Only display the cipher's name if the user running the report does not have permissions to view/edit the cipher

* Add appropiate access modifiers to newly added members/methods

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-02-27 20:55:24 +01:00
Todd Martin
319a4dd1cc Remove checks of device verification flags on client (#13604) 2025-02-27 13:17:47 -05:00
Vicki League
1da7f2052c [PM-18663] Fix calls to bit-button loading states (#13592) 2025-02-27 11:39:46 -05:00
Jared Snider
e6aaa65563 fix(New-UI-Login-SSO): [Auth/PM-18693] LoginComp - fix form validation not showing up on SSO click (#13601) 2025-02-27 10:53:24 -05:00
Todd Martin
ec488e4f84 [PM-18664] Prevent display of Auth Request notification on triggering device (#13597)
* Send device identifier in header.

* Added null to apiUrl property for strict typing.

* Added null to apiUrl for strict typing.
2025-02-27 10:00:52 -05:00
Todd Martin
182ff6481d Remove early return from redirect initialization. (#13585) 2025-02-26 21:49:48 -05:00
Jordan Aasen
a2b9844fa4 [PM-18623][PM-18621][PM-18615] fix defects for new settings popover (#13572)
* fix defects for new settings popover

* also check for "click items to autofill" setting
2025-02-26 15:57:29 -08:00
Shane Melton
16ffedc06b [PM-18463] [PM-18465] At-risk Password Page Fixes (#13573)
* [PM-18463] Add hyphen and fix description pluralization

* [PM-18463] Add spacing between buttons

* [PM-18463] Ensure callout does not flash
2025-02-26 13:45:57 -08:00
Shane Melton
b9ebf0704a [PM-14426] At-risk password Getting Started Carousel (#13383)
* [PM-14426] Add hideIcon input to simple dialog component

* [PM-14426] Introduce dark-image-source.directive.ts

* [PM-14426] Tweaks to the Vault Carousel component
- Create a Carousel NgModule so that the carousel component and carousel slide component are exported
- Update barrel files
- Adjust min height calculation logic to wait for ;hidden slides to finish rendering before calculating height

* [PM-14426] Introduce at risk password getting started carousel component and images

* [PM-14426] Refactor at-risk-password-page.service.ts to use the same state definition for banner and carousel dismissal

* [PM-14426] Open the getting started carousel on page load

* [PM-14426] Add tests

* [PM-14426] Use booleanAttribute

* [PM-14426] Fix failing type checking
2025-02-26 13:24:35 -08:00
Daniel Riera
9aee5f16c4 PM-18276-Connect confirmation UI (#13498)
* PM-18276-wip

* update typing

* dynamically retrieve messages, resolve theme in function

* five second timeout after save or update

* adjust timeout to five seconds

* negligible performance gain-revert

* sacrifice contorl for to remove event listeners-revert
2025-02-26 16:13:27 -05:00
Patrick-Pimentel-Bitwarden
d999d91f19 fix(sso-routing): [Auth/PM-13458] Fixes for routing flow on TDE login (#13479)
* fix(sso-routing): [PM-13458] Fixes for routing flow on TDE login - Fixed routing flow and added comments.

* fix(sso-routing): [PM-13458] Fixes for routing flow on TDE login - Undid the old sso component flow because we determined it's not worth fixing.

* fix(sso-routing): [PM-13458] Fixes for routing flow on TDE login - Removed flow entirely.
2025-02-26 14:54:06 -05:00