bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-24 04:04:24 +00:00
Code Issues Releases Wiki Activity
19,399 Commits 1,214 Branches 572 Tags
d9d8050998cb35f0f20a968f3dc620f56b56722d
Commit Graph

1648 Commits

Author SHA1 Message Date
neuronull
177481935f Fix desktop windows autotype disabled on first login (#16669) 2025-10-01 07:30:03 -06:00
neuronull
c2fbd3eb7e More robust error handling for desktop autotype windows implementation (#16501) 
* Desktop autotype windows error handling

* create a subdir

* extract window handle to separate file

* remove println in case tracing doesn't make it in

* touchups

* reduce scope of unsafe call

* use tracing

* Fix comparison on GetLastError result

* Remove the WindowHandle wrapper and save it for the unit testing PR

* restore apps/browser/src/platform/system-notifications/browser-system-notification.service.ts

* use the human readable message for GetLastError debug

* don't call GetLastError outside of error path

* add some more debug statements

* feedback coltonhorst: nits, fix false positive when len zero, re-add handle validation

* lint

* feedback coltonhurst: add comments and update var names
 2025-09-30 22:22:30 +00:00
neuronull
54a53a1c34 Use tracing in ssh_agent (#16455) 
* [BEEEP][PM-255518] Use tracing for improved observability

* feedback dani-garcia: use DefaultVisitor

* set default log level

* convert printlns in objc crate

* convert printlns in autotype crate

* convert printlns in autostart crate

* convert printlns in core/password crate

* convert printlns in core/biometric crate

* convert printlns in napi crate

* convert log usage in macos provider crate

* convert existing log macros to tracing

* fix the cargo.toml sort lint errors

* Revert "fix the cargo.toml sort lint errors"

This reverts commit fd149ab697.

* fix the sort lint using correct cargo sort version

* feedback coltonhurst: more comments/clarity on behavior

* revert changes to ssh_agent

* Use tracing in ssh_agent
 2025-09-30 06:33:32 -06:00
rr-bw
5f7e1f99bf chore(flag-removal): [Auth/PM20439] Remove flagging logic and flag (BrowserExtensionLoginApproval) (#16568) 2025-09-29 13:29:56 -07:00
Colton Hurst
fc53eae4c5 [PM-22758] Configurable Keyboard Shortcut for Autotype (#16613) 
* [PM-22785] Initial push with configuration and ipc changes for the configurable autotype keyboard shortcut

* [PM-22785] Add messy code with working configurable hotkey

* [PM-22785] Add more messy rust code

* [PM-22785] Add temp changes with configurable hotkey ui

* Add shortcut display to settings

* [PM-22785] Logic updates. Ran npm run prettier and lint:fix.

* [PM-22785] Add back disableAutotype with refactors.

* [PM-22785] Clean up Rust code

* [PM-22785] Clean up Rust code v2

* [PM-22785] Add unicode bounds in Rust code

* [PM-22785] Update rust code comments

* [PM-22785] Add unicode_value byte length check post-encoding

* [PM-22785] Extract encoding to a separate function

* Various fixes for the autotype setting label

* Misc component fixes

* Disallow nunmbers and allow Win key

* Themify edit shortcut

* Change display of Super to Win

* Create autotype format method

* Autotpe modal cleanup

* [PM-22785] Some cleanup

* Add unit tests and adjust error handling

* [PM-22785] Fix build issues on Mac and Linux

* [PM-22785] Linting fix

* Remove unused message

* [PM-22785] Linting fix

* [PM-22785] More linting fix

* [PM-22785] Address initial PR comments

* [PM-22785] Comment change

* [PM-22785] If statement change

* [PM-22785] Update with fixes from PR comments

* [PM-22785] Update with fixes from PR comments version ?

* add unit tests for get_alphabetic_hot_key()

* Fix tests

* Add missing mock to tests

* [PM-22785] Update with small fixes via PR comments

---------

Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>
Co-authored-by: neuronull <9162534+neuronull@users.noreply.github.com>
 2025-09-29 14:20:15 +00:00
renovate[bot]
adbf80dd39 [deps] Platform: Update Rust crate security-framework to v3.5.0 (#16628) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
 2025-09-29 11:31:31 +02:00
bw-ghapp[bot]
99d7097378 Autosync the updated translations (#16637) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-29 08:53:04 +00:00
Colton Hurst
7baf250288 [PM-26192] Integrate the new Autotype Default Policy (#16604) 
* Add current WIP autotype policy integration work

* [PM-26192] Add working code that fully integrates the autotype default policy

* [PM-26192] Add comments

* Update apps/desktop/src/autofill/services/desktop-autotype.service.ts

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>

---------

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
 2025-09-26 15:31:31 +00:00
bw-ghapp[bot]
82b75b72af Autosync the updated translations (#16606) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-26 12:07:56 +02:00
Daniel Riera
2f34c6b9c6 [PM-26053] Create Autotype Desktop Default Setting Policy for use within the desktop autotype service (#16537) 
* add policy type enum

* desktop autotype service which emits an observable

* add desktop autotype default setting policy to the app constructor

* update service module to include DesktopAutotypeDefaultSettingPolicy

* flag the service

* add tests

* address comments, switch to null remove false, update tests
 2025-09-25 18:09:53 -04:00
adudek-bw
f66413e653 Upgrade rusqlite to 0.37.0 (#16530) 2025-09-25 16:54:57 +02:00
Oscar Hinton
87119f9758 Remove allow(clippy::question_mark) (#16565) 
Remove the allow(clippy::question_mark) exception by reworking the code to use ?.
 2025-09-25 13:31:22 +02:00
Bernd Schoolmann
4b73198ce5 [PM-23230] Implement KDF Change Service (#15748) 
* Add new mp service api

* Fix tests

* Add test coverage

* Add newline

* Fix type

* Rename to "unwrapUserKeyFromMasterPasswordUnlockData"

* Fix build

* Fix build on cli

* Fix linting

* Re-sort spec

* Add tests

* Fix test and build issues

* Fix build

* Clean up

* Remove introduced function

* Clean up comments

* Fix abstract class types

* Fix comments

* Cleanup

* Cleanup

* Update libs/common/src/key-management/master-password/types/master-password.types.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/services/master-password.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/types/master-password.types.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Add comments

* Fix build

* Add arg null check

* Cleanup

* Fix build

* Fix build on browser

* Implement KDF change service

* Deprecate encryptUserKeyWithMasterKey

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Add tests for null params

* Fix builds

* Cleanup and deprecate more functions

* Fix formatting

* Prettier

* Clean up

* Update libs/key-management/src/abstractions/key.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Make emailToSalt private and expose abstract saltForUser

* Add tests

* Add docs

* Fix build

* Fix tests

* Fix tests

* Address feedback and fix primitive obsession

* Consolidate active account checks in change kdf confirmation component

* Update libs/common/src/key-management/kdf/services/change-kdf-service.spec.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Add defensive parameter checks

* Add tests

* Add comment for follow-up epic

* Move change kdf service, remove abstraction and add api service

* Fix test

* Drop redundant null check

* Address feedback

* Add throw on empty password

* Fix tests

* Mark change kdf service as internal

* Add abstract classes

* Switch to abstraction

* use sdk EncString in MasterPasswordUnlockData

* fix remaining tests

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
Co-authored-by: Jake Fink <jfink@bitwarden.com>
 2025-09-23 16:10:54 -04:00
Jordan Aasen
6024f6eef2 [PM-25879][PM-25881] - [Defect] Premium badges missing reusable component (#16461) 
* clean up premium badge component

* add provider to desktop settings

* rename prop.

* add provider to send component

* fix storybook

* fix test

* move dependency to new send dropdown component

* Revert "move dependency to new send dropdown component"

This reverts commit f134526279.

* remove hasPremium
 2025-09-23 09:32:45 -07:00
Jordan Aasen
7313a5f2a3 [PM-825] - Desktop not minimizing on right click password when first opened (#16464) 
* minimize item when copying regardless of action

* remove unused import
 2025-09-23 08:57:33 -07:00
Colton Hurst
3ca1395472 Separate Autotype Setting Observable (#16521) 
* Update the default autotype user setting to be separately represented

* rxjs update

* settings.component.spec.ts update
 2025-09-22 19:08:11 -04:00
neuronull
3f14fdc62d [BEEEP][PM-255518] Use tracing for improved observability (#16321) 
* [BEEEP][PM-255518] Use tracing for improved observability

* feedback dani-garcia: use DefaultVisitor

* set default log level

* convert printlns in objc crate

* convert printlns in autotype crate

* convert printlns in autostart crate

* convert printlns in core/password crate

* convert printlns in core/biometric crate

* convert printlns in napi crate

* convert log usage in macos provider crate

* convert existing log macros to tracing

* fix the cargo.toml sort lint errors

* Revert "fix the cargo.toml sort lint errors"

This reverts commit fd149ab697.

* fix the sort lint using correct cargo sort version

* feedback coltonhurst: more comments/clarity on behavior

* revert changes to ssh_agent
 2025-09-22 09:56:23 -06:00
Jason Ng
dbec02cf8d [PM-24533] Initialize Archive Feature (#16226) 
* [PM-19237] Add Archive Filter Type (#13852)
* Browser can archive and unarchive items
* Create Archive Cipher Service
* Add flag and premium permissions to Archive 

---------

Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
Co-authored-by: Shane <smelton@bitwarden.com>
Co-authored-by: Patrick Pimentel <ppimentel@bitwarden.com>
 2025-09-22 11:06:02 -04:00
Mick Letofsky
c9501fec30 [PM-21812][PM-21813] Tech debt removal of legacy stylings no longer required nor used (#16466) 2025-09-22 11:24:32 +02:00
bw-ghapp[bot]
75a042e6f0 Autosync the updated translations (#16517) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-21 11:39:19 +00:00
Colton Hurst
51ed3d8aed [PM-26013] Small Autotype Updates (#16498) 
* [PM-26013] Update the default hotkey and change the uri scheme for autotype.

* [PM-26013] Edit the matching logic for the autotype uri prefix.
 2025-09-19 13:04:47 -04:00
bw-ghapp[bot]
14ae9a2b34 Autosync the updated translations (#16493) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-19 13:28:16 +00:00
Konrad
0ab6a28042 [PM-25984] Delete unused strings (#15907) 
* Delete unused strings

* Remove recoveryCodeDesc string

* Remove unnecessary strings
 2025-09-19 11:46:39 +00:00
bw-ghapp[bot]
3917c62fe3 Autosync the updated translations (#16486) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-19 09:53:21 +02:00
Jared Snider
42ec956782 feat(PlatformUtils): [Auth/PM-25817] New PlatformUtilsService.isChromium() method (#16468) 2025-09-18 14:36:35 -04:00
Github Actions
73a9bd81e7 Bumped Desktop client to 2025.9.1 2025-09-18 17:55:51 +00:00
adudek-bw
6a7f437b1f Add unit tests to chromium importer (#16462) 
* Add unit tests to chromium importer
 2025-09-18 13:00:52 -04:00
renovate[bot]
fb2fe703a2 [deps] Platform: Update Rust crate zbus to v5.11.0 (#15289) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2025-09-18 14:11:08 +02:00
renovate[bot]
7b248fb481 [deps] Platform: Update macOS/iOS bindings (#12971) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2025-09-18 14:10:47 +02:00
Colton Hurst
961cbbe91d Add generated update to index.d.ts (#16408) 2025-09-17 11:22:02 +02:00
Jordan Aasen
3a6088c187 clear orgId when switching to a personal vault (#16396) 2025-09-16 11:52:46 -07:00
bw-ghapp[bot]
d33fd5ff68 Autosync the updated translations (#16393) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-12 09:57:04 +02:00
Jordan Aasen
db9061d120 [PM-25633] - [Defect] Fix premium badge in totp (#16373) 
* fixes to premium upgrade

* revert change to dialog

* handle premium upgrade prompt redirect in AC

* use new input/output api
 2025-09-11 12:15:29 -07:00
Andreas Coroiu
a2e36c4489 feat: add folder.clear warning (#16376) 2025-09-11 16:05:32 +02:00
Nick Krantz
840e6a9ae2 Reapply "[PM-21024] Use Server for Password Change URLs (#14912)" (#16322) (#16372) 
This reverts commit 0040c857ec.
 2025-09-11 08:40:11 -05:00
Vicki League
926f587ea2 [CL-581] Update svgs to new designs and make responsive (#16219) 2025-09-10 17:23:53 -04:00
Jordan Aasen
8aa9f986f5 [PM-24935] - [Desktop] Fix loading state in cipher form save button (#16368) 
* use bitButton for handling loading state

* remove unecessary code
 2025-09-09 16:23:27 -07:00
Jared Snider
52642056d8 fix(DesktopRoutingModule): [Auth/PM-25604] Restore set-initial-password route definition (#16361) 2025-09-09 13:13:05 -04:00
Nick Krantz
62aad469b9 add missing translations for missing website banner (#16348) 2025-09-08 14:53:25 -05:00
Daniel James Smith
b728e58749 Add tamil language support to desktop and web (#16334) 
* Add tamil language support for desktop

* Add tamil language support for web

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
 2025-09-08 10:45:41 -04:00
bw-ghapp[bot]
b7e6af441a Autosync the updated translations (#16330) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-08 13:38:21 +02:00
Github Actions
91490de0b6 Bumped client version(s) 2025-09-08 10:48:22 +00:00
Nick Krantz
0040c857ec Revert "[PM-21024] Use Server for Password Change URLs (#14912)" (#16322) 
This reverts commit fcc2bc96d1.
 2025-09-06 08:57:55 -07:00
Justin Baur
7eb89eb45a chore(dev): Switch to using build constant for isDev check 2025-09-05 19:12:21 -04:00
Daniel James Smith
ee772703fe When using assistive technology announce that a dialog is opened when the generator history link is clicked (#15815) 
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
 2025-09-05 12:58:57 +02:00
bw-ghapp[bot]
d5eaba4b9e Autosync the updated translations (#16303) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-05 10:26:50 +02:00
renovate[bot]
da70fa541c [PM-25443] [deps] Platform: Update electron to v36.8.1 [SECURITY] (#16278) 
* [deps] Platform: Update electron to v36.8.1 [SECURITY]

* fix: update electron-builder.json

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
 2025-09-05 09:14:06 +02:00
Bernd Schoolmann
ea1c3252e8 [BEEEP | PM-25358] Add process isolation on windows and mac desktop main process (#16156) 
* Prevent memory dumping and debugger on windows and mac main process

* Fix clippy

* Only isolate process when isdev is false

* Clean up

* Add backticks around link
 2025-09-04 21:40:25 +02:00
Colton Hurst
896f54696b [PM-24158] Add Premium Check (#16042) 
* [PM-24158] Add initial premium check

* [PM-24158] Add premium membership dialog fix

* [PM-24158] Small updates

* [PM-24158] Set hasPremium to false upon initialization

* [PM-24158] Partial update to settings component tests

* [PM-24158] Fix billing mocked return value and add mac OS autotype test

* [PM-24158] Add missing premium checks

* [PM-24158] Update provider

* [PM-24158] Renamed autotype resolved value

* [PM-24158] Update missed resolvedAutotypeEnabled refactor

* [PM-24158] Fix tests
 2025-09-04 12:33:39 -04:00
Bernd Schoolmann
10a5eba05f Remove limitation on ssh agent + collections (#15441) 2025-09-04 18:05:18 +02:00