1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-18 18:33:50 +00:00
Commit Graph

3203 Commits

Author SHA1 Message Date
Bryan Cunningham
1e7107379d [CL-761] Enable strict template typechecking (#17334)
* enable strict template typechecking

* add callout component to module

* fixing popup action types

* fixing cipher item copy types

* fix archive cipher type

* fixing trash list items types

* fix remaining trash list item type errors

* use CipherViewLike as correct type

* change popup back directive to attribute selector

* allow undefined in popupBackAction handler

* Remove undefined from type

* fix error with firefox commercial build

---------

Co-authored-by: Vicki League <vleague@bitwarden.com>
2026-02-17 09:24:23 -08:00
SmithThe4th
ffe67f1ead Fixed invalid cipher remprompt values (#17513) 2026-02-17 09:24:22 -08:00
Bryan Cunningham
a93978ce79 fix disabled cursor styles (#17656) 2026-02-17 09:24:22 -08:00
Todd Martin
3f12b48dbb chore(docs) Add comments from contributing docs to master password types in code
* Added comments from contributing docs.

* Grammatical changes.
2026-02-17 09:24:22 -08:00
Andreas Coroiu
acc7451100 [PM-27530] Rename BitwardenClient to PasswordManagerClient (#17578)
* fix: compilation issues with PM client rename

* fix: jest compilation

* feat: rename all non-breaking platform instances

* feat: update SDK
2026-02-17 09:24:22 -08:00
Jordan Aasen
4f96a142d8 [PM-24722][PM-27695] - add persistent callout in settings for non-premium users (#17246)
* add persistent callout in settings for non-premium users

* remove premium v2 component

* add spec

* remove premium-v2.component.html

* fix title

* fix typo

* conditionally render h2

* re-add pemiumv2component. change class prop to observable

* change from bold to semibold

* remove unecessary tw classes. use transform: booleanAttribute

* add spotlight specs

* code cleanup
2026-02-17 09:24:21 -08:00
Bryan Cunningham
dffca387d4 [CL-925] add filled danger button (#17633)
* add dangerPrimary button variant

* add dangerPrimary to small story
2026-02-17 09:24:21 -08:00
Oscar Hinton
67af777d76 Enable directive-class-suffix (#17385) 2026-02-17 09:24:20 -08:00
Todd Martin
49ea6f8c5a chore(feature-flag): Removed pm-28325-remove-pm-22110-disable-alternate-login-methods flag 2026-02-17 09:24:19 -08:00
Dave
fa0a26ecbb fix(two-factor) [PM-21204]: Users without premium cannot disable premium 2FA (#17134)
* refactor(two-factor-service) [PM-21204]: Stub API methods in TwoFactorService (domain).

* refactor(two-factor-service) [PM-21204]: Build out stubs and add documentation.

* refactor(two-factor-service) [PM-21204]: Update TwoFactorApiService call sites to use TwoFactorService.

* refactor(two-fatcor) [PM-21204]: Remove deprecated and unused formPromise methods.

* refactor(two-factor) [PM-21204]: Move 2FA-supporting services into common/auth/two-factor feature namespace.

* refactor(two-factor) [PM-21204]: Update imports for service/init containers.

* feat(two-factor) [PM-21204]: Add a disabling flow for Premium 2FA when enabled on a non-Premium account.

* fix(two-factor-service) [PM-21204]: Fix type-safety of module constants.

* fix(multiple) [PM-21204]: Prettier.

* fix(user-verification-dialog) [PM-21204]: Remove bodyText configuration for this use.

* fix(user-verification-dialog) [PM-21204]: Improve the error message displayed to the user.
2026-02-17 09:24:18 -08:00
Addison Beck
927e81249a chore: create eslint rule to catch insecure page script injection (#17437)
* chore: create eslint rule to catch insecure page script injection

* chore: ignore existing lints

* review: tighten rule scope

* review: add tests
2026-02-17 09:24:15 -08:00
Kyle Spearrin
4032301eb8 [PM-27766] Add policy for blocking account creation from claimed domains (#17211)
* Added policy for blocking account creation for claimed domains.

* add feature flag

* fix desc

* learn more link

* fix localization key to learnMore

* onpush change detection
2026-02-17 09:24:13 -08:00
Nick Krantz
69a4740c2f [PM-26688][PM-27710] Delay skeletons from showing + search (#17394)
* add custom operator for loading skeleton delays

* add `isCipherSearching$` observable to search service

* prevent vault skeleton from showing immediately

* add skeleton for search + delay to sends

* update fade-in-out component selector

* add fade-in-out component for generic use

* address memory leak by using defer to encapsulate `skeletonShownAt`

* add missing provider
2026-02-17 09:24:13 -08:00
rr-bw
dedbe3cb2c feat(marketing-initiated-premium): Auth [PM-27542] Write fromMarketing value to state (#17470) 2026-02-17 09:24:13 -08:00
Kyle Denney
ff24743989 [PM-28370] fix defect for self-hosted metadata (#17464) 2026-02-17 09:24:08 -08:00
Jason Ng
7447ed096c [PM-27103] Add URL Check to Send (#17056)
* add dangerousPatters check to api service
2026-02-17 09:24:07 -08:00
Vicki League
a50ced4466 [CL-928] Set link component to semibold weight (#17395) 2026-02-17 09:24:04 -08:00
Oscar Hinton
f232192ad2 [PM-28231] Enable component-class-suffix (#17384)
* Enable component-class-suffix

* Rename file
2026-02-17 09:24:03 -08:00
Jordan Aasen
1d46719282 [PM-23384] - Browser extension spotlight directing to Premium signup in web (#17343)
* premium upgrade nudge

* add specs

* clean up vault template and specs

* fix date comparison. add more specs for date

* fix spec

* fix specs

* make prop private
2026-02-17 09:24:02 -08:00
Nick Krantz
5670e30991 persist archive date when cloning a cipher (#16986) 2026-02-17 09:24:02 -08:00
SmithThe4th
5b1ff21e24 handle empty strings in identity view for sdk cipher encryption (#17423) 2026-02-17 09:24:01 -08:00
Jared Snider
b6e580cc35 Auth/PM-22661 - SendTokenService - improve expired token scenario docs on abstraction (#17371)
* PM-22661 - SendTokenService - improve expired token scenario docs on abstraction

* PM-22661 - SendTokenService - further clarification
2026-02-17 09:23:58 -08:00
Mike Amirault
0b3d0bceb1 Remove import page banner when under org policy (#17348) 2026-02-17 09:23:58 -08:00
Brandon Treston
f9b7763d6d [PM-28216] Add org ability check for one time dialog (#17372)
* add org ability check for one time dialog

* exclude providers (cautionary step) and add tests
2026-02-17 09:23:57 -08:00
Andreas Coroiu
73bc7bb76b [PM-18046] Implement session storage (#17346)
* feat: add support for IPC client managed session storage

* feat: update SDK

* fix: using undecorated service in jslib module directly

* feat: add test case for web

* chore: document why we use any type

* fix: `ipc` too short

* typo: omg

* Revert "typo: omg"

This reverts commit 559b05eb5a.

* Revert "fix: `ipc` too short"

This reverts commit 35fc99e10b.

* fix: use camelCase
2026-02-17 09:23:54 -08:00
Mark Youssef
b7c8469256 [CL-672] update mobile design of dialog (#14828)
---------

Co-authored-by: Vicki League <vleague@bitwarden.com>
2026-02-17 09:23:54 -08:00
Oscar Hinton
a4d9f6ec66 [CL-738] Migrate disclosure component (#17206) 2026-02-17 09:23:53 -08:00
Bryan Cunningham
db902969c1 [CL-736] migrate chip select to use signals (#17136)
* migrate chip select to use signals

* Have Claude address feedback and create spec file

* remove eslint disable comment

* fix failing tests

* remove unnecessary tests

* improved documentation

* remove unnecessary test logic

* consolidate tests and remove fragile selectors
2026-02-17 09:23:53 -08:00
Thomas Avery
8a7bfefad3 [PM-26498] Add proofOfDecryption method to MasterPasswordUnlockService (#17322)
* Add proofOfDecryption method to MasterPasswordUnlockService
2026-02-17 09:23:52 -08:00
Thomas Avery
27b7372553 [PM-24107] Migrate KM's usage of getUserKey from the key service (#17117)
* Remove internal use of getUserKey in the key service

* Move ownership of RotateableKeySet and remove usage of getUserKey

* Add input validation to createKeySet
2026-02-17 09:23:50 -08:00
Maciej Zieniuk
418d03ce78 moving ownership of Auth vault timeout input component to KM (#17180)
(cherry picked from commit 5e595dabf71cdb312ae9e1e3bcc3121b3aebf19f)
2026-02-17 09:23:48 -08:00
Oscar Hinton
3db1a7ae02 [CL-905] Migrate CL/Badge to OnPush (#16959) 2026-02-17 09:23:48 -08:00
cyprain-okeke
65bea1a00f [PM-26682] [Milestone 2d] Display discount on subscription page (#17229)
* The discount badge implementation

* Use existing flag

* Added the top spaces as requested

* refactor: move discount-badge to pricing library and consolidate discount classes

* fix: add CommonModule import to discount-badge component and simplify discounted amount calculation

- Add CommonModule import to discount-badge component for *ngIf directive
- Simplify discountedSubscriptionAmount to use upcomingInvoice.amount from server instead of manual calculation

* Fix the lint errors

* Story update

---------

Co-authored-by: Alex Morask <amorask@bitwarden.com>
2026-02-17 09:23:48 -08:00
Vicki League
e630dcda03 [CL-806] Use header as autofocus target for dialog component (#17336) 2026-02-17 09:23:46 -08:00
Stephon Brown
e0bac2e4fe [PM-28034] Pre-Launch Payment Defect Solution (#17331)
* fix(billing): update to password manager to signal

* fix(billing): take first value so the dialog doesn't show again

* fix(billing): add families plan to request builder

* fix(billing): feedback and type update

* fix(billing): fix selectedplan call
2026-02-17 09:23:46 -08:00
Nick Krantz
f7538a7be4 add skeleton loader feature flag (#17337) 2026-02-17 09:23:45 -08:00
Oscar Hinton
75bbf819ac Log actual import error (#17327) 2026-02-17 09:23:45 -08:00
Maciej Zieniuk
6cf791c753 [PM-26056] Consolidated session timeout component (#16988)
* consolidated session timeout settings component

* rename preferences to appearance

* race condition bug on computed signal

* outdated header for browser

* unnecessary padding

* remove required on action, fix build

* rename localization key

* missing user id

* required

* cleanup task

* eslint fix signals rollback

* takeUntilDestroyed, null checks

* move browser specific logic outside shared component

* explicit input type

* input name

* takeUntilDestroyed, no toast

* unit tests

* cleanup

* cleanup, correct link to deprecation jira

* tech debt todo with jira

* missing web localization key when policy is on

* relative import

* extracting timeout options to component service

* duplicate localization key

* fix failing test

* subsequent timeout action selecting opening without dialog on first dialog cancellation

* default locale can be null

* unit tests failing

* rename, simplifications

* one if else feature flag

* timeout input component rendering before async pipe completion
2026-02-17 09:23:44 -08:00
Andreas Coroiu
ce885071dd Update sdk-internal to 374 (fix breaking changes) (#17325)
* feat: update sdk-internal

* fix: symbol.dispose breaking change

* fix: TextEncoder/Decoder breaking change

* fix: move polyfills to a global setup script

* typo
2026-02-17 09:23:44 -08:00
Vicki League
874fa41ee0 [PM-26984] Use medium instead of semibold or bold, and for headings (#17184) 2026-02-17 09:23:43 -08:00
Bryan Cunningham
1fef5525f3 [CL-924] fix nested nav indentation (#17317)
* fix nav indentation

* move padding logic to component

* add jsdoc for padding calculation

* access open value correctly
2026-02-17 09:23:43 -08:00
Jordan Aasen
b684f4d7f3 Merge branch 'PM-25685' into PM-25686 2025-11-24 09:44:34 -08:00
jaasen-livefront
9122a8fd40 fix test 2025-11-22 13:13:40 -08:00
jaasen-livefront
8ac7d17c99 add Address3 to identity export 2025-11-21 16:23:00 -08:00
jaasen-livefront
a4fec9e172 fix folder 2025-11-20 22:35:05 -08:00
jaasen-livefront
e09cab210c remove optional param to folder constructor 2025-11-20 21:58:12 -08:00
jaasen-livefront
cfb3218065 initialize id in folder constructor. fix failing tests 2025-11-20 21:56:15 -08:00
jaasen-livefront
ab47d10038 fixes to folder 2025-11-20 16:48:33 -08:00
jaasen-livefront
1d5da940a7 check for empty name in folder toDomain 2025-11-20 10:31:33 -08:00
jaasen-livefront
7a8ec65c54 no need to check for presence 2025-11-20 10:29:08 -08:00