1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-18 10:23:52 +00:00
Commit Graph

1858 Commits

Author SHA1 Message Date
Brandon Treston
2912bf05e1 [PM-26901] Add notification handler for auto confirm (#18886)
* add notification handler for auto confirm

* add missing state check

* fix test

* isolate angular specific code from shared lib code

* clean up

* use autoconfirm method

* fix test
2026-02-13 14:36:11 -05:00
Jared
b567fea7e7 [PM-29506] Rid of old feature flag for members feature flag (#18884)
* [PM-31750] Refactor members routing and user confirmation logic

* Simplified user confirmation process by removing feature flag checks.
* Updated routing to directly use the new members component without feature flagging.
* Removed deprecated members component references from routing modules.
* Cleaned up feature flag enum by removing unused entries.

* trigger claude

* [PM-31750] Refactor members component and remove deprecated files

* Renamed vNextMembersComponent to MembersComponent for consistency.
* Removed deprecated_members.component.ts and associated HTML files.
* Updated routing and references to use the new MembersComponent.
* Cleaned up related tests to reflect the component name change.

* Refactor import statements in security-tasks.service.ts for improved readability

* Update apps/web/src/app/admin-console/organizations/manage/user-confirm.component.ts

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* Remove BaseMembersComponent and related imports from the admin console, streamlining member management functionality.

* Remove unused ConfigService import from UserConfirmComponent to clean up code.

* Implement feature flag logic for user restoration in MemberDialogComponent, allowing conditional restoration based on DefaultUserCollectionRestore flag.

---------

Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
2026-02-13 11:38:35 -05:00
Jordan Aasen
2a72d2e74d [PM-25685][PM-31077] - Migrate all Folder models (#17077)
* enforce strict types on folders

* fix folder api service

* fix tests

* fix test

* fix type issue

* fix test

* add extra checks for folders. add specs

* fix folder.id checks

* fix id logic

* remove unecessary check

* name name and id optional in folder model

* fix tests

* Update folder and folderview

* fix folder with id export

* fix tests

* fix tests

* more defensive typing

* fix tests

* no need to check for presence

* check for empty name in folder toDomain

* fixes to folder

* initialize id in folder constructor. fix failing tests

* remove optional param to folder constructor

* fix folder

* fix test

* remove remaining checks for null folder id

* fix logic

* pass null for empty folder ids

* make id more explicit

* fix failing test

* fix failing test

* fix "No Folder" filter
2026-02-12 13:52:29 -08:00
Bernd Schoolmann
9d69b15798 [PM-32063] Disable cipher-key-downgrading (#18911)
* Proposal: Disable cipher-key-downgrading

* Cleanup
2026-02-12 10:31:48 +01:00
Jordan Aasen
396286ff9a [PM-26703] - Update Item Action Behavior for Extension (#18921)
* Revert "Revert "[PM-26703]- Browser - Update autofill Behavior (#18467)" (#18723)"

This reverts commit 5d17d9ee71.

* fix title in non-autofill list

* add feature flag

* add old logic. add specs

* revert changes

* remove comments

* update language in spec

* update appearance spec

* revert change to security-tasks

* fix logic for blocked uri. add deprecated notice.

* fix test

* fix type error
2026-02-11 16:54:05 -08:00
Rui Tomé
5cf4678838 [PM-28300] Remove BlockClaimedDomainAccountCreation feature flag and related logic from policy component (#18720) 2026-02-11 22:10:55 +00:00
Nick Krantz
f20686cdf4 [PM-24978] Corrupt Attachment Keys (#17790)
* display translated content for attachments that cannot be downloaded

* consume decryption failure from the sdk for attachments

* add decryption errors from sdk

* only show fix attachment issues for when key is null and it does not have a decryption failure

* separate decryption failure state in view
2026-02-11 10:31:38 -06:00
Jon David Schober
29e2be0d2b [PM-30529][PM-31279] Webauthn: Support Related Origin Requests (#18242)
* Webauthn: Support Related Origin Requests

* review changes

* PM-31279 Add feature flag to guard executing ROR checks

* Fix fido2-client.service tests

* Set ROR_MAX_LABELS to 5

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Addison Beck <github@addisonbeck.com>
2026-02-11 10:32:22 -05:00
Brandon Treston
1aef83b6e3 [PM-28262] Bulk re-invite UI improvements (#18754)
* implement dilogs and logic

* clean up, add tests

* add feature flag key

* product requested changes

* more product changes

* edit error message
2026-02-10 16:20:39 -05:00
Bernd Schoolmann
d37e173ee3 [BEEEP] Add deprecation notices to encstring encrypt API (#18811)
* Add deprecation notices to encstring encrypt API

* Cleanup comment

* Run prettier
2026-02-09 17:29:45 -06:00
Bernd Schoolmann
9856902688 Make hazmat warnings more bold (#18813) 2026-02-09 15:56:24 -06:00
Jason Ng
322ff6b70b [PM-31675] remove archive from web edit (#18764)
* refactor default cipher archive service, update archive/unarchive in vault-item-dialog, remove archive/unarchive items in edit form
2026-02-09 16:17:46 -05:00
Alex Dragovich
e485623ed8 [PM-31685] Removing email hashes (#18744)
* [PM-31685] Removing email hashes

* [PM-31685] fixing tests, which are now passing

* [PM-31685] removing anon access emails field and reusing emails field

* [PM-31685] fixing missed tests

* [PM-31685] fixing missed tests

* [PM-31685] code review changes

* [PM-31685] do not encrypt emails by use of domain functionality

* [PM-31685] test fixes
2026-02-09 12:59:17 -08:00
SmithThe4th
48d18df285 Revert "[PM-31668] Race condition in cipher cache clearing causes stale faile…" (#18846)
This reverts commit bf13194b9c.
2026-02-09 14:32:49 -06:00
Bernd Schoolmann
ea04b0562f Prevent SDK from disposing withit debounce period (#18775) 2026-02-09 20:19:38 +00:00
SmithThe4th
d02886ba8d Revert "[PM-30580] Add encryptMany to SDK for batch cipher encryption (#18803)" (#18840)
This reverts commit a637983305.
2026-02-09 10:31:26 -05:00
Bernd Schoolmann
f7a5ad712f [PM-29208] Remove individual cryptographic-key states & migrate key service (#18164)
* Remove inividual user key states and migrate to account cryptographic state

* Fix browser

* Fix tests

* Clean up migration

* Remove key-pair creation from login strategy

* Add clearing for the account cryptographic state

* Add migration

* Cleanup

* Fix linting
2026-02-09 12:39:55 +01:00
Daniel James Smith
03a60a61cb Revert "[PM-29149] Add ServerCommunicationConfigService (#18815)" (#18821)
This reverts commit f1b9408e3f.
2026-02-06 21:15:12 +00:00
Daniel James Smith
f1b9408e3f [PM-29149] Add ServerCommunicationConfigService (#18815)
* Add state- and key-definitions for persisting serverCommunicationConfig(s)

* Add implementation of the SDK-defined ServerCommunicationConfigRepository

* Add ServerCommunicationConfigService

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-02-06 21:40:03 +01:00
SmithThe4th
a637983305 [PM-30580] Add encryptMany to SDK for batch cipher encryption (#18803)
* Migrated encrypt many to the sdk

* removed comment

* updated sdk package
2026-02-06 19:56:38 +00:00
Brad
b6ff3a110e [PM-18855] Add edit Cipher permission check to Cipher Authorization Service and use in Vault dialog (#18375)
Centralize edit permission checks in CipherAuthorizationService instead of using the disableForm parameter passed to VaultItemDialogComponent. This refactoring improves consistency with how delete and restore permissions are handled, establishes a single source of truth for authorization logic, and simplifies caller components.

This change also fixes the bug in ticket, which allows Users to properly edit Ciphers inside of the various Admin Console report types.
2026-02-06 12:18:20 -06:00
SmithThe4th
bf13194b9c [PM-31668] Race condition in cipher cache clearing causes stale failed decryption state after leaving organization (#18751)
* Refactored the search index to index with the cipherlistview

* Fixed comment

* clear encrypted cipher state to prevent stale emissions during sync
2026-02-06 11:10:16 -06:00
Alex Dragovich
1b812d2274 Revert "Remove feature flag check from password generation (#18003)" (#18794)
This reverts commit 7c6d98b50e.
2026-02-05 13:33:44 -08:00
Nick Krantz
b5d865e8f2 move clearCache before updateWithServer (#18790) 2026-02-05 13:42:50 -06:00
Daniel James Smith
446f35791e [PM-29127] Improve subdomain parsing for fido2 (#18383)
* Add check and test for empty inputs into isValidRpId

* Ensure the origin's scheme is https

* Improve parsing and validation of rpId

* Move https requirement check further down as we accept http for localhost

* Add documentation

* Remove ts-strict-ignore

* ts-strict: Fix possibly null on parsedOrigin.hostname

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-02-05 17:45:09 +01:00
adudek-bw
7c6d98b50e Remove feature flag check from password generation (#18003)
* Remove feature flag check from password generation
2026-02-05 09:46:31 -05:00
Thomas Avery
f457abf60b Add contact info to HAZMAT (#18759) 2026-02-05 10:57:10 +01:00
Nik Gilmore
3f5ca7155b [PM-31282] Bugfix: Pass orgId to Admin Bulk Delete API 2026-02-03 12:35:13 -08:00
Jonathan Prusik
5a397fb44e [PM-29236] Refactor of post-submit notification triggering logic (#18395)
* refactor triggerChangedPasswordNotification logic

* improve triggerChangedPasswordNotification and test coverage to handle scenarios more comprehensively

* restore triggerChangedPasswordNotification logic and move new logic and testing to triggerCipherNotification

* add branching qualification logic for cipher notifications

* add and implement undetermined-cipher-scenario-logic feature flag

* add optional chaining to username comparison of existing login ciphers

* cleanup

* update tests

* prefer explicit length comparisons
2026-02-02 15:01:24 -05:00
Mike Amirault
7f1c68a24d [PM-30675] Fix certain data fields being incorrect in account-restricted exports (#18531) 2026-02-02 13:10:28 -05:00
Jordan Aasen
5d17d9ee71 Revert "[PM-26703]- Browser - Update autofill Behavior (#18467)" (#18723)
This reverts commit 7b583aa0ec.
2026-02-02 09:37:02 -08:00
rr-bw
1f0e0ca098 refactor(input-password-flows): [Auth/PM-27086] JIT MP org user flow - remove masterKey generation from InputPasswordComponent (#18006)
- Updates `InputPasswordComponent` to emit raw data instead of generating cryptographic properties (`newMasterKey`, `newServerMasterKeyHash`, `newLocalMasterKeyHash`).
  - This helps us in moving away from using the deprecated `makeMasterKey()` method in the component (which takes email as salt) as we seek to eventually separate the email from the salt.
- Updates the `JIT_PROVISIONED_MP_ORG_USER` case of the switch to handle the flow when the `PM27086_UpdateAuthenticationApisForInputPassword` flag is on.

Feature Flag: `PM27086_UpdateAuthenticationApisForInputPassword`
2026-01-30 15:11:59 -08:00
Ike
4a45414f4a [PM-30563] Improve Send Access enumeration protection (#18620)
* feat: sync changes with SDK and server

* Update libs/common/src/auth/send-access/types/invalid-request-errors.type.ts

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* feat: sync changes with SDK and Server projects
sync: sdk version

* chore: update sdk

* chore: update sdk

* chore: prettier

---------

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
2026-01-30 17:16:32 -05:00
sven-bitwarden
9e36c19515 Separates policy response model for individual policy data (#18377) 2026-01-29 14:11:31 -06:00
Jared McCannon
ae64706256 [PM-30891] - Create My Items On Restore (#18454)
* Added encrypted default collection name to new feature flagged restore user methods/endpoint.

* corrected filter to use null check with imperative code
2026-01-29 13:56:35 -06:00
John Harrington
0740c037a6 [PM-30922] Client changes to encrypt send access email list (#18486) 2026-01-28 14:31:48 -07:00
Vijay Oommen
9d8f1af62b PM-30539 created new component and added a filter (#18630) 2026-01-28 15:19:39 -06:00
Nik Gilmore
c07beb3b10 [PM-31282] Pass orgId through to API call when SDK feature flag is off (#18619) 2026-01-28 09:38:15 -08:00
Mike Amirault
65b224646d Tools/pm 29918/implement send auth flows (#18270)
* [PM-29918] Implement new Send auth flows

* [PM-29918] Fix types

* Trigger Claude code review

* [PM-29918] Address PR review comments

* [PM-29918] Remove duplicate AuthType const
2026-01-28 09:32:02 -05:00
Brandon Treston
c2da621663 [PM-28413] Remove feature flagged logic (#18566)
* clean up flagged logic

* fix test
2026-01-28 09:31:55 -05:00
Todd Martin
a04566ae11 chore(flags): [PM-31326] Rename ipc-channel-framework feature flag
* Rename feature flag

* Not sure what happened here.  Renaming the class.
2026-01-28 08:25:10 -05:00
Jordan Aasen
7b583aa0ec [PM-26703]- Browser - Update autofill Behavior (#18467)
* apply changes to autofill

* fix tests

* fix and simplify logic
2026-01-27 12:41:33 -08:00
Dave
c82ac0f574 feat(account-switching) [PM-5594]: Enabling account switching causes performance issues on safari (#18339)
* refactor(account-switching) [PM-5594]: Move account switching enabled flag to AccountSwitcherService to accommodate server-side feature flag.

* test(account-switching) [PM-5594]: Update tests to include ConfigService dependency for feature flag.

* refactor(account-switching) [PM-5594]: Remove compile-time account switching flags from browser.

* refactor(account-switching) [PM-5594]: Move initialization to ctor for strict.
2026-01-27 14:27:13 -05:00
Jeffrey Holland
00cf24972d [PM-28079] Add attributes to filter for the mutationObserver (#17832)
* [PM-28079] Add attributes to filter for the mutationObserver

* Update attributes based on Claude suggestions

* Updated remaining attributes

* Adjust placeholder check in `updateAutofillFieldElementData`

* Update ordering of constants and add comment

* Remove `tagName` and `value` from mutation logic

* Add new autocomplete and aria attributes to `updateActions`

* Fix autocomplete handlers

* Fix broken test for `updateAttributes`

* Order attributes for readability in `updateActions`

* Fix tests

---------

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
2026-01-27 11:28:02 -05:00
Maciej Zieniuk
9454189df5 [PM-27283] [BEEEP] Reactive availableVaultTimeoutActions$ in vault timeout settings (#17731)
* reactive `availableVaultTimeoutActions$` in vault timeout settings

* cleanup

* deprecation docs

* explicitly provided user id

* clearer mocking

* better docs
2026-01-27 10:28:13 +00:00
Nik Gilmore
748c7c5446 [PM-30303] Migrate Cipher Delete Operations to use SDK (#18275) 2026-01-26 15:55:49 -08:00
Nick Krantz
ad577860be [PM-28060] Remove Skeleton Feature Flag (#18456)
* remove skeleton ff

* remove unneeded templates
2026-01-26 14:01:53 -06:00
Nik Gilmore
06c8c7316d [PM-30301][PM-30302] Use SDK for Create and Update cipher operations (#18149)
* Migrate create and edit operations to use SDK for ciphers

* WIP: Adds admin call to edit ciphers with SDK

* Add client version to SDK intialization settings

* Remove console.log statements

* Adds originalCipherId and collectionIds to updateCipher

* Update tests for new cipehrService interfaces

* Rename SdkCipherOperations feature flag

* Add call to Admin edit SDK if flag is passed

* Add tests for SDK path

* Revert changes to .npmrc

* Remove outdated comments

* Fix feature flag name

* Fix UUID format in cipher.service.spec.ts

* Update calls to cipherService.updateWithServer and .createWithServer to new interface

* Update CLI and Desktop to use new cipherSErvice interfaces

* Fix tests for new cipherService interface change

* Bump sdk-internal and commercial-sdk-internal versions to 0.2.0-main.439

* Fix linting errors

* Fix typescript errors impacted by this chnage

* Fix caching issue on browser extension when using SDK cipher ops.

* Remove commented code

* Fix bug causing race condition due to not consuming / awaiting observable.

* Add missing 'await' to decrypt call

* Clean up unnecessary else statements and fix function naming

* Add comments for this.clearCache

* Add tests for SDK CipherView conversion functions

* Replace sdkservice with cipher-sdk.service

* Fix import issues in browser

* Fix import issues in cli

* Fix type issues

* Fix type issues

* Fix type issues

* Fix test that fails sporadically due to timing issue
2026-01-26 11:43:35 -08:00
Nick Krantz
87555eaabd remove risk insights for premium feature flag (#18446) 2026-01-26 12:07:31 -06:00
Rui Tomé
71db33d45d [PM-28842] Add max length validation to master password policy form (#18237)
* Update master password policy dialog to limit the minimum length to 128

* Update master password policy to use dynamic maximum length from Utils

* Add unit tests for MasterPasswordPolicyComponent to validate password length constraints and scoring
2026-01-26 11:38:10 +00:00