mirror of
https://github.com/bitwarden/browser
synced 2025-12-19 09:43:23 +00:00
* Add `disk-local` option for web * Fix `web` DI * Update libs/common/src/platform/state/state-definition.ts Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Rely On Default Implementation for Most of Cache Key --------- Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
61 lines
2.7 KiB
TypeScript
61 lines
2.7 KiB
TypeScript
import { ClientLocations, StateDefinition } from "./state-definition";
|
|
import * as stateDefinitionsRecord from "./state-definitions";
|
|
|
|
describe.each(["web", "cli", "desktop", "browser"])(
|
|
"state definitions follow rules for client %s",
|
|
(clientType: keyof ClientLocations) => {
|
|
const trackedNames: [string, string][] = [];
|
|
|
|
test.each(Object.entries(stateDefinitionsRecord))(
|
|
"that export %s follows all rules",
|
|
(exportName, stateDefinition) => {
|
|
// All exports from state-definitions are expected to be StateDefinition's
|
|
if (!(stateDefinition instanceof StateDefinition)) {
|
|
throw new Error(`export ${exportName} is expected to be a StateDefinition`);
|
|
}
|
|
|
|
const storageLocation =
|
|
stateDefinition.storageLocationOverrides[clientType] ??
|
|
stateDefinition.defaultStorageLocation;
|
|
|
|
const fullName = `${stateDefinition.name}_${storageLocation}`;
|
|
|
|
const exactConflictingExport = trackedNames.find(
|
|
([_, trackedName]) => trackedName === fullName,
|
|
);
|
|
if (exactConflictingExport !== undefined) {
|
|
const [conflictingExportName] = exactConflictingExport;
|
|
throw new Error(
|
|
`The export '${exportName}' has a conflicting state name and storage location with export ` +
|
|
`'${conflictingExportName}' please ensure that you choose a unique name and location for all clients.`,
|
|
);
|
|
}
|
|
|
|
const roughConflictingExport = trackedNames.find(
|
|
([_, trackedName]) => trackedName.toLowerCase() === fullName.toLowerCase(),
|
|
);
|
|
if (roughConflictingExport !== undefined) {
|
|
const [conflictingExportName] = roughConflictingExport;
|
|
throw new Error(
|
|
`The export '${exportName}' differs its state name and storage location ` +
|
|
`only by casing with export '${conflictingExportName}' please ensure it differs by more than casing.`,
|
|
);
|
|
}
|
|
|
|
const name = stateDefinition.name;
|
|
|
|
expect(name).not.toBeUndefined(); // undefined in an invalid name
|
|
expect(name).not.toBeNull(); // null is in invalid name
|
|
expect(name.length).toBeGreaterThan(3); // A 3 characters or less name is not descriptive enough
|
|
expect(name[0]).toEqual(name[0].toLowerCase()); // First character should be lower case since camelCase is required
|
|
expect(name).not.toContain(" "); // There should be no spaces in a state name
|
|
expect(name).not.toContain("_"); // We should not be doing snake_case for state name
|
|
|
|
// NOTE: We could expect some details about the export name as well
|
|
|
|
trackedNames.push([exportName, fullName]);
|
|
},
|
|
);
|
|
},
|
|
);
|