mirror of
https://github.com/bitwarden/browser
synced 2025-12-06 00:13:28 +00:00
fdfcee4bc5
* max init * add mp4 and organize code better * fix lint errors * move empty state logic into risk insights component * replace getter logic * sub for org name * checkForVaultItems fix - need to use cipherservice instead of report results from data service * fix all critical issues mentioned by claude bot * resolve empty state logic bug and memory leaks - Handle zero-results case in empty state logic - Add takeUntil cleanup to _setupUserId subscription - Guard console.warn with isDevMode() check * use tuple arrays for benefits to prevent XSS risk Replace pipe-separated strings with typed tuple arrays [string, string][] for benefits data in empty state component. This eliminates potential XSS risk from string splitting, provides compile-time type safety, and improves performance by removing runtime string parsing on every change detection. * fix(dirt): hide empty states during report generation and fix memory leak Add isGeneratingReport$ to combineLatest, update empty state conditions to check !isGenerating, simplify run report logic, and fix memory leak in route.queryParams subscription. Addresses Claude bot feedback on PR #16832 * refactor(dirt): use signals and OnPush in empty state card component Convert @Input() to readonly input signals and add OnPush change detection strategy. Update template to call signals as functions. Fixes ESLint compliance issues. * refactor(dirt): remove unused shouldShowRunReportState variable The shouldShowRunReportState variable was calculated but never used. The template already uses @else for the run report state, making this variable redundant. * refactor(dirt): consolidate duplicate if statements in empty state logic Merge 5 separate if/else blocks checking shouldShowImportDataState into single consolidated block. Move constant benefits assignment outside conditional. Improves readability and reduces duplication. * remove unnecessary getOrganizationName wrapper method * remove duplicate runReport method Remove runReport arrow function and use generateReport consistently. Both methods called dataService.triggerReport(), but generateReport includes an organizationId check for defensive programming.
Bitwarden Licensed Code
All source code under this directory is licensed under the Bitwarden License Agreement.