mirror of
https://github.com/bitwarden/browser
synced 2025-12-11 05:43:41 +00:00
* Revert "[PM-5277] Migrate Sync Service to State Provider (#7680)"
This reverts commit 78008a9e1e.
Includes a noop migration builder that allows us to bridge over the deleted migration
* Prefer revert migrations to noop
this revert avoids the need to change behavior between released vs unreleased migrations and keeps some dangerous code out of the repo :success:
* Update ordering of badge settings migrator to be consistent with `rc`, which was cut with only up to version 25
* Fix missing type import
121 lines
3.1 KiB
TypeScript
121 lines
3.1 KiB
TypeScript
import { MockProxy, any } from "jest-mock-extended";
|
|
|
|
import { MigrationHelper } from "../migration-helper";
|
|
import { mockMigrationHelper } from "../migration-helper.spec";
|
|
|
|
import {
|
|
BIOMETRIC_UNLOCK_ENABLED,
|
|
MoveBiometricUnlockToStateProviders,
|
|
} from "./28-move-biometric-unlock-to-state-providers";
|
|
|
|
function exampleJSON() {
|
|
return {
|
|
global: {
|
|
otherStuff: "otherStuff1",
|
|
},
|
|
authenticatedAccounts: ["user-1", "user-2", "user-3"],
|
|
"user-1": {
|
|
settings: {
|
|
biometricUnlock: true,
|
|
otherStuff: "otherStuff2",
|
|
},
|
|
otherStuff: "otherStuff3",
|
|
},
|
|
"user-2": {
|
|
otherStuff: "otherStuff4",
|
|
},
|
|
};
|
|
}
|
|
|
|
function rollbackJSON() {
|
|
return {
|
|
"user_user-1_biometricSettings_biometricUnlockEnabled": true,
|
|
global: {
|
|
otherStuff: "otherStuff1",
|
|
},
|
|
authenticatedAccounts: ["user-1", "user-2", "user-3"],
|
|
"user-1": {
|
|
settings: {
|
|
otherStuff: "otherStuff2",
|
|
},
|
|
otherStuff: "otherStuff3",
|
|
},
|
|
"user-2": {
|
|
otherStuff: "otherStuff4",
|
|
},
|
|
};
|
|
}
|
|
|
|
describe("MoveBiometricPromptsToStateProviders migrator", () => {
|
|
let helper: MockProxy<MigrationHelper>;
|
|
let sut: MoveBiometricUnlockToStateProviders;
|
|
|
|
describe("migrate", () => {
|
|
beforeEach(() => {
|
|
helper = mockMigrationHelper(exampleJSON(), 27);
|
|
sut = new MoveBiometricUnlockToStateProviders(27, 28);
|
|
});
|
|
|
|
it("removes biometricUnlock from all accounts", async () => {
|
|
await sut.migrate(helper);
|
|
expect(helper.set).toHaveBeenCalledTimes(2);
|
|
expect(helper.set).toHaveBeenCalledWith("user-1", {
|
|
settings: {
|
|
otherStuff: "otherStuff2",
|
|
},
|
|
otherStuff: "otherStuff3",
|
|
});
|
|
expect(helper.set).toHaveBeenCalledWith("user-2", {
|
|
otherStuff: "otherStuff4",
|
|
});
|
|
});
|
|
|
|
it("sets biometricUnlock value for account that have it", async () => {
|
|
await sut.migrate(helper);
|
|
|
|
expect(helper.setToUser).toHaveBeenCalledWith("user-1", BIOMETRIC_UNLOCK_ENABLED, true);
|
|
});
|
|
|
|
it("should not call extra setToUser", async () => {
|
|
await sut.migrate(helper);
|
|
|
|
expect(helper.setToUser).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|
|
|
|
describe("rollback", () => {
|
|
beforeEach(() => {
|
|
helper = mockMigrationHelper(rollbackJSON(), 28);
|
|
sut = new MoveBiometricUnlockToStateProviders(27, 28);
|
|
});
|
|
|
|
it("nulls out new values", async () => {
|
|
await sut.rollback(helper);
|
|
|
|
expect(helper.setToUser).toHaveBeenCalledWith("user-1", BIOMETRIC_UNLOCK_ENABLED, null);
|
|
});
|
|
|
|
it("adds explicit value back to accounts", async () => {
|
|
await sut.rollback(helper);
|
|
|
|
expect(helper.set).toHaveBeenCalledTimes(1);
|
|
expect(helper.set).toHaveBeenCalledWith("user-1", {
|
|
settings: {
|
|
biometricUnlock: true,
|
|
otherStuff: "otherStuff2",
|
|
},
|
|
otherStuff: "otherStuff3",
|
|
});
|
|
});
|
|
|
|
it.each(["user-2", "user-3"])(
|
|
"does not restore values when accounts are not present",
|
|
async (userId) => {
|
|
await sut.rollback(helper);
|
|
|
|
expect(helper.set).not.toHaveBeenCalledWith(userId, any());
|
|
},
|
|
);
|
|
});
|
|
});
|