mirror of
https://github.com/bitwarden/browser
synced 2025-12-06 00:13:28 +00:00
7ac75a6c52
This change eliminates the circular dependency between messaging and messaging-internal libraries by merging them into a single messaging library. Previously, messaging-internal imported from @bitwarden/messaging while messaging tried to import from @bitwarden/messaging-internal, creating an unresolvable circular dependency. This also violated Nx best practices by using cross-library file includes in tsconfig.lib.json. Changes made: - Moved all messaging-internal code (SubjectMessageSender, helpers, tests) into libs/messaging/src/ - Updated all imports to use relative paths instead of @bitwarden/messaging imports - Removed the entire messaging-internal library and its configuration files - Updated external references in apps/browser to import from @bitwarden/messaging - Fixed libs/messaging/tsconfig.lib.json to use standard src/**/*.ts pattern - Updated libs/common internal.ts to re-export from messaging instead of messaging-internal The messaging library now exports both public APIs and internal implementations, which is a cleaner architecture than maintaining two separate libraries with circular dependencies. Fixes rootDir configuration issues identified in the Nx library systematic fix project.
219 lines
11 KiB
Plaintext
219 lines
11 KiB
Plaintext
# Please sort into logical groups with comment headers. Sort groups in order of specificity.
|
|
# For example, default owners should always be the first group.
|
|
# Sort lines alphabetically within these groups to avoid accidentally adding duplicates.
|
|
#
|
|
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
|
|
|
|
## Desktop native module ##
|
|
apps/desktop/desktop_native @bitwarden/team-platform-dev
|
|
apps/desktop/desktop_native/objc/src/native/autofill @bitwarden/team-autofill-desktop-dev
|
|
apps/desktop/desktop_native/core/src/autofill @bitwarden/team-autofill-desktop-dev
|
|
## No ownership for Cargo.lock and Cargo.toml to allow dependency updates
|
|
apps/desktop/desktop_native/Cargo.lock
|
|
apps/desktop/desktop_native/Cargo.toml
|
|
|
|
## Auth team files ##
|
|
apps/browser/src/auth @bitwarden/team-auth-dev
|
|
apps/cli/src/auth @bitwarden/team-auth-dev
|
|
apps/desktop/src/auth @bitwarden/team-auth-dev
|
|
apps/web/src/app/auth @bitwarden/team-auth-dev
|
|
libs/auth @bitwarden/team-auth-dev
|
|
libs/user-core @bitwarden/team-auth-dev
|
|
# web connectors used for auth
|
|
apps/web/src/connectors @bitwarden/team-auth-dev
|
|
bitwarden_license/bit-web/src/app/auth @bitwarden/team-auth-dev
|
|
libs/angular/src/auth @bitwarden/team-auth-dev
|
|
libs/common/src/auth @bitwarden/team-auth-dev
|
|
|
|
## Tools team files ##
|
|
apps/browser/src/tools @bitwarden/team-tools-dev
|
|
apps/cli/src/tools @bitwarden/team-tools-dev
|
|
apps/desktop/src/app/tools @bitwarden/team-tools-dev
|
|
apps/desktop/desktop_native/bitwarden_chromium_importer @bitwarden/team-tools-dev
|
|
apps/web/src/app/tools @bitwarden/team-tools-dev
|
|
libs/angular/src/tools @bitwarden/team-tools-dev
|
|
libs/common/src/models/export @bitwarden/team-tools-dev
|
|
libs/common/src/tools @bitwarden/team-tools-dev
|
|
libs/importer @bitwarden/team-tools-dev
|
|
libs/tools @bitwarden/team-tools-dev
|
|
|
|
## Dirt (Data Insights & Reporting) team files ##
|
|
apps/web/src/app/dirt @bitwarden/team-data-insights-and-reporting-dev
|
|
bitwarden_license/bit-common/src/dirt @bitwarden/team-data-insights-and-reporting-dev
|
|
bitwarden_license/bit-web/src/app/dirt @bitwarden/team-data-insights-and-reporting-dev
|
|
libs/dirt @bitwarden/team-data-insights-and-reporting-dev
|
|
|
|
## Localization/Crowdin (Platform and Tools team)
|
|
apps/browser/src/_locales @bitwarden/team-tools-dev @bitwarden/team-platform-dev
|
|
apps/browser/store/locales @bitwarden/team-tools-dev @bitwarden/team-platform-dev
|
|
apps/cli/src/locales @bitwarden/team-tools-dev @bitwarden/team-platform-dev
|
|
apps/desktop/src/locales @bitwarden/team-tools-dev @bitwarden/team-platform-dev
|
|
apps/web/src/locales @bitwarden/team-tools-dev @bitwarden/team-platform-dev
|
|
|
|
## Vault team files ##
|
|
apps/browser/src/vault @bitwarden/team-vault-dev
|
|
apps/cli/src/vault @bitwarden/team-vault-dev
|
|
apps/desktop/src/vault @bitwarden/team-vault-dev
|
|
apps/web/src/app/vault @bitwarden/team-vault-dev
|
|
libs/angular/src/vault @bitwarden/team-vault-dev
|
|
libs/common/src/vault @bitwarden/team-vault-dev
|
|
libs/vault @bitwarden/team-vault-dev
|
|
|
|
## Admin Console team files ##
|
|
apps/browser/src/admin-console @bitwarden/team-admin-console-dev
|
|
apps/cli/src/admin-console @bitwarden/team-admin-console-dev
|
|
apps/desktop/src/admin-console @bitwarden/team-admin-console-dev
|
|
apps/web/src/app/admin-console @bitwarden/team-admin-console-dev
|
|
bitwarden_license/bit-web/src/app/admin-console @bitwarden/team-admin-console-dev
|
|
bitwarden_license/bit-cli/src/admin-console @bitwarden/team-admin-console-dev
|
|
libs/angular/src/admin-console @bitwarden/team-admin-console-dev
|
|
libs/common/src/admin-console @bitwarden/team-admin-console-dev
|
|
libs/admin-console @bitwarden/team-admin-console-dev
|
|
|
|
## Billing team files ##
|
|
apps/browser/src/billing @bitwarden/team-billing-dev
|
|
apps/desktop/src/billing @bitwarden/team-billing-dev
|
|
apps/web/src/app/billing @bitwarden/team-billing-dev
|
|
libs/angular/src/billing @bitwarden/team-billing-dev
|
|
libs/common/src/billing @bitwarden/team-billing-dev
|
|
libs/billing @bitwarden/team-billing-dev
|
|
bitwarden_license/bit-web/src/app/billing @bitwarden/team-billing-dev
|
|
|
|
## Platform team files ##
|
|
apps/browser/src/platform @bitwarden/team-platform-dev
|
|
apps/cli/src/platform @bitwarden/team-platform-dev
|
|
apps/desktop/macos @bitwarden/team-platform-dev
|
|
apps/desktop/scripts @bitwarden/team-platform-dev
|
|
apps/desktop/src/platform @bitwarden/team-platform-dev
|
|
apps/desktop/resources @bitwarden/team-platform-dev
|
|
apps/web/src/app/platform @bitwarden/team-platform-dev
|
|
libs/angular/src/platform @bitwarden/team-platform-dev
|
|
libs/common/src/platform @bitwarden/team-platform-dev
|
|
libs/common/spec @bitwarden/team-platform-dev
|
|
libs/common/src/state-migrations @bitwarden/team-platform-dev
|
|
libs/platform @bitwarden/team-platform-dev
|
|
libs/storage-core @bitwarden/team-platform-dev
|
|
libs/logging @bitwarden/team-platform-dev
|
|
libs/storage-test-utils @bitwarden/team-platform-dev
|
|
libs/messaging @bitwarden/team-platform-dev
|
|
libs/serialization @bitwarden/team-platform-dev
|
|
libs/guid @bitwarden/team-platform-dev
|
|
libs/client-type @bitwarden/team-platform-dev
|
|
libs/core-test-utils @bitwarden/team-platform-dev
|
|
libs/state @bitwarden/team-platform-dev
|
|
libs/state-internal @bitwarden/team-platform-dev
|
|
libs/state-test-utils @bitwarden/team-platform-dev
|
|
# Web utils used across app and connectors
|
|
apps/web/src/utils/ @bitwarden/team-platform-dev
|
|
# Web core and shared files
|
|
apps/web/src/app/core @bitwarden/team-platform-dev
|
|
apps/web/src/app/shared @bitwarden/team-platform-dev
|
|
apps/web/src/translation-constants.ts @bitwarden/team-platform-dev
|
|
# Workflows
|
|
.github/workflows/automatic-issue-responses.yml @bitwarden/team-platform-dev
|
|
.github/workflows/automatic-pull-request-responses.yml @bitwarden/team-platform-dev
|
|
.github/workflows/build-browser-target.yml @bitwarden/team-platform-dev
|
|
.github/workflows/build-browser.yml @bitwarden/team-platform-dev
|
|
.github/workflows/build-cli-target.yml @bitwarden/team-platform-dev
|
|
.github/workflows/build-cli.yml @bitwarden/team-platform-dev
|
|
.github/workflows/build-desktop-target.yml @bitwarden/team-platform-dev
|
|
.github/workflows/build-desktop.yml @bitwarden/team-platform-dev
|
|
.github/workflows/build-web-target.yml @bitwarden/team-platform-dev
|
|
.github/workflows/build-web.yml @bitwarden/team-platform-dev
|
|
.github/workflows/crowdin-pull.yml @bitwarden/team-platform-dev
|
|
.github/workflows/enforce-labels.yml @bitwarden/team-platform-dev
|
|
.github/workflows/lint.yml @bitwarden/team-platform-dev
|
|
.github/workflows/locales-lint.yml @bitwarden/team-platform-dev
|
|
.github/workflows/repository-management.yml @bitwarden/team-platform-dev
|
|
.github/workflows/scan.yml @bitwarden/team-platform-dev
|
|
.github/workflows/stale-bot.yml @bitwarden/team-platform-dev
|
|
.github/workflows/test.yml @bitwarden/team-platform-dev
|
|
.github/workflows/version-auto-bump.yml @bitwarden/team-platform-dev
|
|
# ESLint custom rules
|
|
libs/eslint @bitwarden/team-platform-dev
|
|
libs/eslint/components @bitwarden/team-ui-foundation
|
|
# Typescript tooling
|
|
tsconfig.base.json @bitwarden/team-platform-dev
|
|
nx.json @bitwarden/team-platform-dev
|
|
|
|
## Autofill team files ##
|
|
apps/browser/src/autofill @bitwarden/team-autofill-dev
|
|
apps/desktop/src/autofill @bitwarden/team-autofill-dev
|
|
libs/common/src/autofill @bitwarden/team-autofill-dev
|
|
apps/desktop/macos/autofill-extension @bitwarden/team-autofill-desktop-dev
|
|
.github/workflows/test-browser-interactions.yml @bitwarden/team-autofill-dev
|
|
# Autofill desktop files
|
|
apps/desktop/src/app/components/fido2placeholder.component.ts @bitwarden/team-autofill-desktop-dev
|
|
apps/desktop/desktop_native/windows_plugin_authenticator @bitwarden/team-autofill-desktop-dev
|
|
apps/desktop/desktop_native/autotype @bitwarden/team-autofill-desktop-dev
|
|
# DuckDuckGo integration
|
|
apps/desktop/native-messaging-test-runner @bitwarden/team-autofill-desktop-dev
|
|
apps/desktop/src/services/duckduckgo-message-handler.service.ts @bitwarden/team-autofill-desktop-dev
|
|
apps/desktop/src/services/encrypted-message-handler.service.ts @bitwarden/team-autofill-desktop-dev
|
|
.github/workflows/alert-ddg-files-modified.yml @bitwarden/team-autofill-desktop-dev
|
|
# SSH Agent
|
|
apps/desktop/desktop_native/core/src/ssh_agent @bitwarden/team-autofill-desktop-dev @bitwarden/wg-ssh-keys
|
|
|
|
## UI Foundation ##
|
|
.github/workflows/chromatic.yml @bitwarden/team-ui-foundation
|
|
.storybook @bitwarden/team-ui-foundation
|
|
libs/components @bitwarden/team-ui-foundation
|
|
libs/assets @bitwarden/team-ui-foundation
|
|
libs/ui @bitwarden/team-ui-foundation
|
|
apps/browser/src/platform/popup/layout @bitwarden/team-ui-foundation
|
|
apps/browser/src/popup/app-routing.animations.ts @bitwarden/team-ui-foundation
|
|
apps/browser/src/popup/components/extension-anon-layout-wrapper @bitwarden/team-ui-foundation
|
|
apps/web/src/app/layouts @bitwarden/team-ui-foundation
|
|
|
|
## Key management team files ##
|
|
apps/desktop/src/key-management @bitwarden/team-key-management-dev
|
|
apps/web/src/app/key-management @bitwarden/team-key-management-dev
|
|
apps/browser/src/key-management @bitwarden/team-key-management-dev
|
|
apps/cli/src/key-management @bitwarden/team-key-management-dev
|
|
libs/key-management @bitwarden/team-key-management-dev
|
|
libs/key-management-ui @bitwarden/team-key-management-dev
|
|
libs/common/src/key-management @bitwarden/team-key-management-dev
|
|
# Node-cryptofunction service
|
|
libs/node @bitwarden/team-key-management-dev
|
|
|
|
apps/desktop/desktop_native/core/src/biometric/ @bitwarden/team-key-management-dev
|
|
apps/desktop/src/services/native-messaging.service.ts @bitwarden/team-key-management-dev
|
|
apps/browser/src/background/nativeMessaging.background.ts @bitwarden/team-key-management-dev
|
|
apps/desktop/src/services/biometric-message-handler.service.ts @bitwarden/team-key-management-dev
|
|
|
|
## Locales ##
|
|
apps/browser/src/_locales/en/messages.json
|
|
apps/browser/store/locales/en
|
|
apps/cli/src/locales/en/messages.json
|
|
apps/desktop/src/locales/en/messages.json
|
|
apps/web/src/locales/en/messages.json
|
|
|
|
## BRE team owns these workflows ##
|
|
.github/workflows/brew-bump-desktop.yml @bitwarden/dept-bre
|
|
.github/workflows/deploy-web.yml @bitwarden/dept-bre
|
|
.github/workflows/publish-cli.yml @bitwarden/dept-bre
|
|
.github/workflows/publish-desktop.yml @bitwarden/dept-bre
|
|
.github/workflows/publish-web.yml @bitwarden/dept-bre
|
|
.github/workflows/retrieve-current-desktop-rollout.yml @bitwarden/dept-bre
|
|
.github/workflows/staged-rollout-desktop.yml @bitwarden/dept-bre
|
|
.github/workflows/release-browser.yml @bitwarden/dept-bre
|
|
.github/workflows/release-cli.yml @bitwarden/dept-bre
|
|
.github/workflows/release-desktop-beta.yml @bitwarden/dept-bre
|
|
.github/workflows/release-desktop.yml @bitwarden/dept-bre
|
|
.github/workflows/release-web.yml @bitwarden/dept-bre
|
|
|
|
## Docker files have shared ownership ##
|
|
**/Dockerfile
|
|
**/*.Dockerfile
|
|
**/.dockerignore
|
|
**/entrypoint.sh
|
|
|
|
## Overrides
|
|
# For the time being platform owns tsconfig and jest config
|
|
# These overrides will be removed after Nx is implemented
|
|
# To track that effort please see https://bitwarden.atlassian.net/browse/PM-21636
|
|
**/tsconfig.json @bitwarden/team-platform-dev
|
|
**/jest.config.js @bitwarden/team-platform-dev
|
|
**/project.jsons @bitwarden/team-platform-dev
|
|
libs/pricing @bitwarden/team-billing-dev
|