mirror of
https://github.com/bitwarden/browser
synced 2025-12-16 00:03:56 +00:00
9c1e2ebd67
* Use typescript-strict-plugin to iteratively turn on strict * Add strict testing to pipeline Can be executed locally through either `npm run test:types` for full type checking including spec files, or `npx tsc-strict` for only tsconfig.json included files. * turn on strict for scripts directory * Use plugin for all tsconfigs in monorepo vscode is capable of executing tsc with plugins, but uses the most relevant tsconfig to do so. If the plugin is not a part of that config, it is skipped and developers get no feedback of strict compile time issues. These updates remedy that at the cost of slightly more complex removal of the plugin when the time comes. * remove plugin from configs that extend one that already has it * Update workspace settings to honor strict plugin * Apply strict-plugin to native message test runner * Update vscode workspace to use root tsc version * `./node_modules/.bin/update-strict-comments` 🤖 This is a one-time operation. All future files should adhere to strict type checking. * Add fixme to `ts-strict-ignore` comments * `update-strict-comments` 🤖 repeated for new merge files
72 lines
2.1 KiB
TypeScript
72 lines
2.1 KiB
TypeScript
// FIXME: Update this file to be type safe and remove this and next line
|
|
// @ts-strict-ignore
|
|
import { ValidatorFn, Validators } from "@angular/forms";
|
|
import { distinctUntilChanged, map, pairwise, pipe, skipWhile, startWith, takeWhile } from "rxjs";
|
|
|
|
import { AnyConstraint, Constraints } from "@bitwarden/common/tools/types";
|
|
import { UserId } from "@bitwarden/common/types/guid";
|
|
import { CredentialGeneratorConfiguration } from "@bitwarden/generator-core";
|
|
|
|
export function completeOnAccountSwitch() {
|
|
return pipe(
|
|
map(({ id }: { id: UserId | null }) => id),
|
|
skipWhile((id) => !id),
|
|
startWith(null as UserId),
|
|
pairwise(),
|
|
takeWhile(([prev, next]) => (prev ?? next) === next),
|
|
map(([_, id]) => id),
|
|
distinctUntilChanged(),
|
|
);
|
|
}
|
|
|
|
export function toValidators<Policy, Settings>(
|
|
target: keyof Settings,
|
|
configuration: CredentialGeneratorConfiguration<Settings, Policy>,
|
|
policy?: Constraints<Settings>,
|
|
) {
|
|
const validators: Array<ValidatorFn> = [];
|
|
|
|
// widen the types to avoid typecheck issues
|
|
const config: AnyConstraint = configuration.settings.constraints[target];
|
|
const runtime: AnyConstraint = policy[target];
|
|
|
|
const required = getConstraint("required", config, runtime) ?? false;
|
|
if (required) {
|
|
validators.push(Validators.required);
|
|
}
|
|
|
|
const maxLength = getConstraint("maxLength", config, runtime);
|
|
if (maxLength !== undefined) {
|
|
validators.push(Validators.maxLength(maxLength));
|
|
}
|
|
|
|
const minLength = getConstraint("minLength", config, runtime);
|
|
if (minLength !== undefined) {
|
|
validators.push(Validators.minLength(config.minLength));
|
|
}
|
|
|
|
const min = getConstraint("min", config, runtime);
|
|
if (min !== undefined) {
|
|
validators.push(Validators.min(min));
|
|
}
|
|
|
|
const max = getConstraint("max", config, runtime);
|
|
if (max !== undefined) {
|
|
validators.push(Validators.max(max));
|
|
}
|
|
|
|
return validators;
|
|
}
|
|
|
|
function getConstraint<Key extends keyof AnyConstraint>(
|
|
key: Key,
|
|
config: AnyConstraint,
|
|
policy?: AnyConstraint,
|
|
) {
|
|
if (policy && key in policy) {
|
|
return policy[key] ?? config[key];
|
|
} else if (config && key in config) {
|
|
return config[key];
|
|
}
|
|
}
|