mirror of
https://github.com/bitwarden/browser
synced 2026-02-27 10:03:23 +00:00
e66a1f37b5
Adds urlOriginsMatch to @bitwarden/platform, which compares two URLs by
scheme, host, and port. Uses `protocol + "//" + host` rather than
`URL.origin` because non-special schemes (e.g. chrome-extension://)
return the opaque string "null" from .origin, making equality comparison
unreliable. URLs without a host (file:, data:) are explicitly rejected
to prevent hostless schemes from comparing equal.
Refactors senderIsInternal to delegate to urlOriginsMatch and to derive
the extension URL via BrowserApi.getRuntimeURL("") rather than inline
chrome/browser API detection. Adds full test coverage for
senderIsInternal.
The previous string-based comparison used startsWith after stripping
trailing slashes, which was safe in senderIsInternal where inputs are
tightly constrained. As a general utility accepting arbitrary URLs,
startsWith can produce false positives (e.g. "https://example.com"
matching "https://example.com.evil.com"). Structural host comparison
is the correct contract for unrestricted input.
55 lines
2.4 KiB
TypeScript
55 lines
2.4 KiB
TypeScript
import { urlOriginsMatch } from "./util";
|
|
|
|
describe("urlOriginsMatch", () => {
|
|
it.each([
|
|
["string/string, same origin", "https://example.com", "https://example.com"],
|
|
["URL/URL, same origin", new URL("https://example.com"), new URL("https://example.com")],
|
|
["string canonical, URL suspect", "https://example.com", new URL("https://example.com/path")],
|
|
["URL canonical, string suspect", new URL("https://example.com/path"), "https://example.com"],
|
|
[
|
|
"paths and query differ but origin same",
|
|
"https://example.com/foo",
|
|
"https://example.com/bar?baz=1",
|
|
],
|
|
["explicit default port matches implicit", "https://example.com", "https://example.com:443"],
|
|
[
|
|
"non-special scheme with matching host",
|
|
"chrome-extension://abc123/popup.html",
|
|
"chrome-extension://abc123/bg.js",
|
|
],
|
|
])("returns true when %s", (_, canonical, suspect) => {
|
|
expect(urlOriginsMatch(canonical as string | URL, suspect as string | URL)).toBe(true);
|
|
});
|
|
|
|
it.each([
|
|
["hosts differ", "https://example.com", "https://evil.com"],
|
|
["schemes differ", "https://example.com", "http://example.com"],
|
|
["ports differ", "https://example.com:8080", "https://example.com:9090"],
|
|
[
|
|
"suspect is a subdomain of the canonical host",
|
|
"https://example.com",
|
|
"https://sub.example.com",
|
|
],
|
|
["non-special scheme hosts differ", "chrome-extension://abc123/", "chrome-extension://xyz789/"],
|
|
])("returns false when %s", (_, canonical, suspect) => {
|
|
expect(urlOriginsMatch(canonical, suspect)).toBe(false);
|
|
});
|
|
|
|
it.each([
|
|
["canonical is an invalid string", "not a url", "https://example.com"],
|
|
["suspect is an invalid string", "https://example.com", "not a url"],
|
|
])("returns false when %s", (_, canonical, suspect) => {
|
|
expect(urlOriginsMatch(canonical, suspect)).toBe(false);
|
|
});
|
|
|
|
it.each([
|
|
["canonical is a file: URL", "file:///home/user/a.txt", "https://example.com"],
|
|
["suspect is a file: URL", "https://example.com", "file:///home/user/a.txt"],
|
|
["both are file: URLs", "file:///home/user/a.txt", "file:///home/other/b.txt"],
|
|
["canonical is a data: URL", "data:text/plain,foo", "https://example.com"],
|
|
["suspect is a data: URL", "https://example.com", "data:text/plain,foo"],
|
|
])("returns false when %s (no host)", (_, canonical, suspect) => {
|
|
expect(urlOriginsMatch(canonical, suspect)).toBe(false);
|
|
});
|
|
});
|