bitwarden/desktop
1
0
Fork 0
mirror of https://github.com/bitwarden/desktop synced 2025-12-15 07:43:33 +00:00
Code Issues Releases Wiki Activity

adding a signing flag for electron builder

Browse Source
This commit is contained in:
Joseph Flinn
2021-01-06 18:58:44 +00:00
parent 048f3fed6f
commit c508c7cd05
2 changed files with 19 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
.github/workflows/build.yml vendored
View File

@@ -193,12 +193,7 @@ jobs:
shell: pwsh shell: pwsh
run: npm run dist:win:ci run: npm run dist:win:ci
env: env:
SIGNING_VAULT_URL: ${{ secrets.SIGNING_VAULT_URL }} ELECTRON_BUILDER_SIGN: false
SIGNING_CLIENT_ID: ${{ secrets.SIGNING_CLIENT_ID }}
SIGNING_TENANT_ID: ${{ secrets.SIGNING_TENANT_ID }}
SIGNING_CLIENT_SECRET: ${{ secrets.SIGNING_CLIENT_SECRET }}
SIGNING_CERT_NAME: ${{ secrets.SIGNING_CERT_NAME }}
SECRET_TEST: ${{ secrets.SECRET_TEST }}
- name: Rename appx files for store - name: Rename appx files for store
shell: pwsh shell: pwsh
@@ -252,6 +247,7 @@ jobs:
run: | run: |
npm run pack:win npm run pack:win
env: env:
ELECTRON_BUILDER_SIGN: true
SIGNING_VAULT_URL: ${{ secrets.SIGNING_VAULT_URL }} SIGNING_VAULT_URL: ${{ secrets.SIGNING_VAULT_URL }}
SIGNING_CLIENT_ID: ${{ secrets.SIGNING_CLIENT_ID }} SIGNING_CLIENT_ID: ${{ secrets.SIGNING_CLIENT_ID }}
SIGNING_TENANT_ID: ${{ secrets.SIGNING_TENANT_ID }} SIGNING_TENANT_ID: ${{ secrets.SIGNING_TENANT_ID }}

2
sign.js
View File

@@ -1,4 +1,5 @@
exports.default = async function(configuration) { exports.default = async function(configuration) {
if (process.env.ELECTRON_BUILDER_SIGN) {
require("child_process").execSync( require("child_process").execSync(
`azuresigntool sign ` + `azuresigntool sign ` +
`-kvu ${process.env.SIGNING_VAULT_URL} ` + `-kvu ${process.env.SIGNING_VAULT_URL} ` +
@@ -14,4 +15,5 @@ exports.default = async function(configuration) {
stdio: "inherit" stdio: "inherit"
} }
); );
}
}; };