bitwarden/directory-connector
1
0
Fork 0
mirror of https://github.com/bitwarden/directory-connector synced 2025-12-10 13:23:18 +00:00
Code Issues Releases Wiki Activity

Update gui builds to use nvmrc (#838)

Browse Source 
- use .nvmrc node version in GUI build jobs (matches CLI build jobs)
- has the effect of upgrading from node 18 -> 20 in these jobs
(but note Electron uses its own version of node not this one)
This commit is contained in:
Thomas Rittson
2025-07-24 23:52:53 +10:00
committed by GitHub
parent 3013e5f06f
commit 926202f80a
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
.github/workflows/build.yml vendored
View File

@@ -267,6 +267,7 @@ jobs:
env: env:
NODE_OPTIONS: --max_old_space_size=4096 NODE_OPTIONS: --max_old_space_size=4096
_PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }} _PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }}
_NODE_VERSION: ${{ needs.setup.outputs.node_version }}
HUSKY: 0 HUSKY: 0
steps: steps:
- name: Checkout repo - name: Checkout repo
@@ -277,7 +278,7 @@ jobs:
with: with:
cache: 'npm' cache: 'npm'
cache-dependency-path: '**/package-lock.json' cache-dependency-path: '**/package-lock.json'
node-version: '18' node-version: ${{ env._NODE_VERSION }}
- name: Update NPM - name: Update NPM
run: | run: |
@@ -364,6 +365,7 @@ jobs:
env: env:
NODE_OPTIONS: --max_old_space_size=4096 NODE_OPTIONS: --max_old_space_size=4096
_PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }} _PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }}
_NODE_VERSION: ${{ needs.setup.outputs.node_version }}
HUSKY: 0 HUSKY: 0
steps: steps:
- name: Checkout repo - name: Checkout repo
@@ -374,7 +376,7 @@ jobs:
with: with:
cache: 'npm' cache: 'npm'
cache-dependency-path: '**/package-lock.json' cache-dependency-path: '**/package-lock.json'
node-version: '18' node-version: ${{ env._NODE_VERSION }}
- name: Update NPM - name: Update NPM
run: | run: |
@@ -421,6 +423,7 @@ jobs:
env: env:
NODE_OPTIONS: --max_old_space_size=4096 NODE_OPTIONS: --max_old_space_size=4096
_PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }} _PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }}
_NODE_VERSION: ${{ needs.setup.outputs.node_version }}
HUSKY: 0 HUSKY: 0
steps: steps:
- name: Checkout repo - name: Checkout repo
@@ -431,7 +434,7 @@ jobs:
with: with:
cache: 'npm' cache: 'npm'
cache-dependency-path: '**/package-lock.json' cache-dependency-path: '**/package-lock.json'
node-version: '18' node-version: ${{ env._NODE_VERSION }}
- name: Update NPM - name: Update NPM
run: | run: |

2
.github/workflows/integration-test.yml vendored
View File

@@ -10,12 +10,14 @@ on:
- "src/services/ldap-directory.service*" # we only have integration for LDAP testing at the moment - "src/services/ldap-directory.service*" # we only have integration for LDAP testing at the moment
- "./openldap/**/*" # any change to test fixtures - "./openldap/**/*" # any change to test fixtures
- "./docker-compose.yml" # any change to Docker configuration - "./docker-compose.yml" # any change to Docker configuration
- "./package.json" # dependencies
pull_request: pull_request:
paths: paths:
- ".github/workflows/integration-test.yml" # this file - ".github/workflows/integration-test.yml" # this file
- "src/services/ldap-directory.service*" # we only have integration for LDAP testing at the moment - "src/services/ldap-directory.service*" # we only have integration for LDAP testing at the moment
- "./openldap/**/*" # any change to test fixtures - "./openldap/**/*" # any change to test fixtures
- "./docker-compose.yml" # any change to Docker configuration - "./docker-compose.yml" # any change to Docker configuration
- "./package.json" # dependencies
permissions: permissions:
contents: read contents: read
checks: write # required by dorny/test-reporter to upload its results checks: write # required by dorny/test-reporter to upload its results