From ceff0559f23bbfc3be996d4b667f164d80259b6b Mon Sep 17 00:00:00 2001 From: Vince Grassia <593223+vgrassia@users.noreply.github.com> Date: Thu, 12 Jun 2025 16:06:11 +0000 Subject: [PATCH] Remove checksum assets from releases (#795) --- .github/workflows/build.yml | 38 +++-------------------------------- .github/workflows/release.yml | 6 +++--- 2 files changed, 6 insertions(+), 38 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 51ab93a4..7b5f5cc4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -9,6 +9,9 @@ on: - "hotfix-rc" workflow_dispatch: {} +permissions: + contents: read + jobs: cloc: name: CLOC @@ -95,11 +98,6 @@ jobs: - name: Zip run: zip -j dist-cli/bwdc-linux-$_PACKAGE_VERSION.zip dist-cli/linux/bwdc keytar/linux/build/Release/keytar.node - - name: Create checksums - run: | - shasum -a 256 dist-cli/bwdc-linux-$_PACKAGE_VERSION.zip | \ - cut -d " " -f 1 > dist-cli/bwdc-linux-sha256-$_PACKAGE_VERSION.txt - - name: Version Test run: | sudo apt-get update @@ -129,13 +127,6 @@ jobs: path: ./dist-cli/bwdc-linux-${{ env._PACKAGE_VERSION }}.zip if-no-files-found: error - - name: Upload Linux checksum to GitHub - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0 - with: - name: bwdc-linux-sha256-${{ env._PACKAGE_VERSION }}.txt - path: ./dist-cli/bwdc-linux-sha256-${{ env._PACKAGE_VERSION }}.txt - if-no-files-found: error - macos-cli: name: Build Mac CLI @@ -190,11 +181,6 @@ jobs: - name: Zip run: zip -j dist-cli/bwdc-macos-$_PACKAGE_VERSION.zip dist-cli/macos/bwdc keytar/macos/build/Release/keytar.node - - name: Create checksums - run: | - shasum -a 256 dist-cli/bwdc-macos-$_PACKAGE_VERSION.zip | \ - cut -d " " -f 1 > dist-cli/bwdc-macos-sha256-$_PACKAGE_VERSION.txt - - name: Version Test run: | mkdir -p test/macos @@ -217,12 +203,6 @@ jobs: path: ./dist-cli/bwdc-macos-${{ env._PACKAGE_VERSION }}.zip if-no-files-found: error - - name: Upload Mac checksum to GitHub - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0 - with: - name: bwdc-macos-sha256-${{ env._PACKAGE_VERSION }}.txt - path: ./dist-cli/bwdc-macos-sha256-${{ env._PACKAGE_VERSION }}.txt - if-no-files-found: error windows-cli: name: Build Windows CLI @@ -349,11 +329,6 @@ jobs: Throw "Version test failed." } - - name: Create checksums - run: | - checksum -f="./dist-cli/bwdc-windows-${env:_PACKAGE_VERSION}.zip" ` - -t sha256 | Out-File ./dist-cli/bwdc-windows-sha256-${env:_PACKAGE_VERSION}.txt - - name: Upload Windows Zip to GitHub uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0 with: @@ -361,13 +336,6 @@ jobs: path: ./dist-cli/bwdc-windows-${{ env._PACKAGE_VERSION }}.zip if-no-files-found: error - - name: Upload Windows checksum to GitHub - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0 - with: - name: bwdc-windows-sha256-${{ env._PACKAGE_VERSION }}.txt - path: ./dist-cli/bwdc-windows-sha256-${{ env._PACKAGE_VERSION }}.txt - if-no-files-found: error - windows-gui: name: Build Windows GUI diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5620e258..c5f809c3 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -13,6 +13,9 @@ on: - Redeploy - Dry Run +permissions: + contents: read + jobs: setup: name: Setup @@ -71,9 +74,6 @@ jobs: artifacts: "./bwdc-windows-${{ env.PKG_VERSION }}.zip, ./bwdc-macos-${{ env.PKG_VERSION }}.zip, ./bwdc-linux-${{ env.PKG_VERSION }}.zip, - ./bwdc-windows-sha256-${{ env.PKG_VERSION }}.txt, - ./bwdc-macos-sha256-${{ env.PKG_VERSION }}.txt, - ./bwdc-linux-sha256-${{ env.PKG_VERSION }}.txt, ./Bitwarden-Connector-Portable-${{ env.PKG_VERSION }}.exe, ./Bitwarden-Connector-Installer-${{ env.PKG_VERSION }}.exe, ./Bitwarden-Connector-Installer-${{ env.PKG_VERSION }}.exe.blockmap,