From db3e7aa6854b93efc44bf857bcd38d59e00aac01 Mon Sep 17 00:00:00 2001
From: Jared <TheWolfBadger@gmail.com>
Date: Mon, 23 Feb 2026 12:42:39 -0500
Subject: [PATCH] Refactor error handling in LdapDirectoryService to ensure
 proper unbinding and error propagation (#995)

---
 src/services/directory-services/ldap-directory.service.ts | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/services/directory-services/ldap-directory.service.ts b/src/services/directory-services/ldap-directory.service.ts
index b9893885..b2fa384b 100644
--- a/src/services/directory-services/ldap-directory.service.ts
+++ b/src/services/directory-services/ldap-directory.service.ts
@@ -68,10 +68,12 @@ export class LdapDirectoryService implements IDirectoryService {
         }
         groups = await this.getGroups(groupForce);
       }
-    } finally {
+    } catch (e) {
       await this.client.unbind();
+      throw e;
     }
 
+    await this.client.unbind();
     return [groups, users];
   }
 
@@ -453,8 +455,9 @@ export class LdapDirectoryService implements IDirectoryService {
 
     try {
       await this.client.bind(user, pass);
-    } catch {
+    } catch (error) {
       await this.client.unbind();
+      throw error;
     }
   }