bitwarden/jslib
1
0
Fork 0
mirror of https://github.com/bitwarden/jslib synced 2025-12-21 02:33:37 +00:00
Code Issues Releases Wiki Activity

Add test for returning early if 2FA required

Browse Source
This commit is contained in:
Thomas Rittson
2021-12-15 13:15:04 +10:00
parent e2fd3bd5a9
commit 23cfd1de7f
1 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
spec/common/services/auth.service.spec.ts
View File

@@ -23,6 +23,7 @@ import { IdentityTokenResponse } from 'jslib-common/models/response/identityToke
import { StateService } from 'jslib-common/abstractions/state.service'; import { StateService } from 'jslib-common/abstractions/state.service';
import { AccountProfile, AccountTokens } from 'jslib-common/models/domain/account'; import { AccountProfile, AccountTokens } from 'jslib-common/models/domain/account';
import { KeyConnectorUserKeyRequest } from 'jslib-common/models/request/keyConnectorUserKeyRequest'; import { KeyConnectorUserKeyRequest } from 'jslib-common/models/request/keyConnectorUserKeyRequest';
import { IdentityTwoFactorResponse } from 'jslib-common/models/response/identityTwoFactorResponse';
describe('Cipher Service', () => { describe('Cipher Service', () => {
let cryptoService: SubstituteOf<CryptoService>; let cryptoService: SubstituteOf<CryptoService>;
@@ -231,6 +232,7 @@ describe('Cipher Service', () => {
cryptoService.didNotReceive().setEncPrivateKey(Arg.any()); cryptoService.didNotReceive().setEncPrivateKey(Arg.any());
}); });
// TODO: this should be logInSso
it('logIn: gets and sets KeyConnector key for enrolled user', async () => { it('logIn: gets and sets KeyConnector key for enrolled user', async () => {
logInSetup(); logInSetup();
commonSetup(); commonSetup();
@@ -261,6 +263,32 @@ describe('Cipher Service', () => {
apiService.received(1).postAccountKeys(Arg.any()); apiService.received(1).postAccountKeys(Arg.any());
}); });
it('logIn: bails out if 2FA is required', async () => {
const twoFactorProviders = new Map<number, null>([
[1, null]
]);
logInSetup();
commonSetup();
const tokenResponse = newTokenResponse();
(tokenResponse as any).twoFactorProviders2 = twoFactorProviders;
tokenService.getTwoFactorToken(email).resolves(null);
apiService.postIdentityToken(Arg.any()).resolves(tokenResponse);
const expected = new AuthResult();
expected.twoFactor = true;
expected.twoFactorProviders = twoFactorProviders;
expected.captchaSiteKey = undefined;
const result = await authService.logIn(email, masterPassword);
stateService.didNotReceive().addAccount(Arg.any());
messagingService.didNotReceive().send(Arg.any());
expect(result).toEqual(expected);
});
// it('login: new SSO user with Key Connector posts key to the server', async () => { // it('login: new SSO user with Key Connector posts key to the server', async () => {
// logInSetup(); // logInSetup();
// commonSetup(); // commonSetup();