Add eslint (#610)

node/package.json

@@ -15,9 +15,7 @@
   "scripts": {
     "clean": "rimraf dist/**/*",
     "build": "npm run clean && tsc",
-    "build:watch": "npm run clean && tsc -watch",
-    "lint": "tslint 'src/**/*.ts' 'spec/**/*.ts'",
-    "lint:fix": "tslint 'src/**/*.ts' 'spec/**/*.ts' --fix"
+    "build:watch": "npm run clean && tsc -watch"
   },
   "devDependencies": {
     "@types/inquirer": "^7.3.1",

node/src/cli/baseProgram.ts

@@ -79,7 +79,7 @@ export abstract class BaseProgram {
       return message.raw;
     }
 
-    let out: string = "";
+    let out = "";
     if (message.title != null) {
       if (message.noColor) {
         out = message.title;

node/src/cli/commands/login.command.ts

@@ -1,17 +1,8 @@
-import * as program from "commander";
 import * as http from "http";
+
+import * as program from "commander";
 import * as inquirer from "inquirer";
-
-import { TwoFactorProviderType } from "jslib-common/enums/twoFactorProviderType";
-
-import { AuthResult } from "jslib-common/models/domain/authResult";
-import {
-  ApiLogInCredentials,
-  PasswordLogInCredentials,
-  SsoLogInCredentials,
-} from "jslib-common/models/domain/logInCredentials";
-import { TwoFactorEmailRequest } from "jslib-common/models/request/twoFactorEmailRequest";
-import { ErrorResponse } from "jslib-common/models/response/errorResponse";
+import Separator from "inquirer/lib/objects/separator";
 
 import { ApiService } from "jslib-common/abstractions/api.service";
 import { AuthService } from "jslib-common/abstractions/auth.service";
@@ -24,20 +15,21 @@ import { PlatformUtilsService } from "jslib-common/abstractions/platformUtils.se
 import { PolicyService } from "jslib-common/abstractions/policy.service";
 import { StateService } from "jslib-common/abstractions/state.service";
 import { TwoFactorService } from "jslib-common/abstractions/twoFactor.service";
-
-import { Response } from "../models/response";
-
-import { UpdateTempPasswordRequest } from "jslib-common/models/request/updateTempPasswordRequest";
-
-import { MessageResponse } from "../models/response/messageResponse";
-
+import { TwoFactorProviderType } from "jslib-common/enums/twoFactorProviderType";
 import { NodeUtils } from "jslib-common/misc/nodeUtils";
 import { Utils } from "jslib-common/misc/utils";
+import { AuthResult } from "jslib-common/models/domain/authResult";
+import {
+  ApiLogInCredentials,
+  PasswordLogInCredentials,
+  SsoLogInCredentials,
+} from "jslib-common/models/domain/logInCredentials";
+import { TwoFactorEmailRequest } from "jslib-common/models/request/twoFactorEmailRequest";
+import { UpdateTempPasswordRequest } from "jslib-common/models/request/updateTempPasswordRequest";
+import { ErrorResponse } from "jslib-common/models/response/errorResponse";
 
-import Separator from "inquirer/lib/objects/separator";
-
-// tslint:disable-next-line
-const open = require("open");
+import { Response } from "../models/response";
+import { MessageResponse } from "../models/response/messageResponse";
 
 export class LoginCommand {
   protected validatedParams: () => Promise<any>;
@@ -482,7 +474,7 @@ export class LoginCommand {
     return clientId;
   }
 
-  private async apiClientSecret(isAdditionalAuthentication: boolean = false): Promise<string> {
+  private async apiClientSecret(isAdditionalAuthentication = false): Promise<string> {
     const additionalAuthenticationMessage = "Additional authentication required.\nAPI key ";
     let clientSecret: string = null;
 

node/src/cli/commands/logout.command.ts

@@ -1,5 +1,3 @@
-import * as program from "commander";
-
 import { AuthService } from "jslib-common/abstractions/auth.service";
 import { I18nService } from "jslib-common/abstractions/i18n.service";
 

node/src/cli/commands/update.command.ts

@@ -1,4 +1,3 @@
-import * as program from "commander";
 import * as fetch from "node-fetch";
 
 import { I18nService } from "jslib-common/abstractions/i18n.service";
@@ -8,7 +7,7 @@ import { Response } from "../models/response";
 import { MessageResponse } from "../models/response/messageResponse";
 
 export class UpdateCommand {
-  inPkg: boolean = false;
+  inPkg = false;
 
   constructor(
     private platformUtilsService: PlatformUtilsService,

node/src/cli/services/cliPlatformUtils.service.ts

@@ -1,12 +1,11 @@
 import * as child_process from "child_process";
 
+import { PlatformUtilsService } from "jslib-common/abstractions/platformUtils.service";
 import { ClientType } from "jslib-common/enums/clientType";
 import { DeviceType } from "jslib-common/enums/deviceType";
 import { ThemeType } from "jslib-common/enums/themeType";
 
-import { PlatformUtilsService } from "jslib-common/abstractions/platformUtils.service";
-
-// tslint:disable-next-line
+// eslint-disable-next-line
 const open = require("open");
 
 export class CliPlatformUtilsService implements PlatformUtilsService {

node/src/cli/services/consoleLog.service.ts

@@ -1,5 +1,4 @@
 import { LogLevelType } from "jslib-common/enums/logLevelType";
-
 import { ConsoleLogService as BaseConsoleLogService } from "jslib-common/services/consoleLog.service";
 
 export class ConsoleLogService extends BaseConsoleLogService {
@@ -13,7 +12,7 @@ export class ConsoleLogService extends BaseConsoleLogService {
     }
 
     if (process.env.BW_RESPONSE === "true") {
-      // tslint:disable-next-line
+      // eslint-disable-next-line
       console.error(message);
       return;
     }

node/src/services/lowdbStorage.service.ts

@@ -1,11 +1,11 @@
 import * as fs from "fs";
+import * as path from "path";
+
 import * as lowdb from "lowdb";
 import * as FileSync from "lowdb/adapters/FileSync";
-import * as path from "path";
 
 import { LogService } from "jslib-common/abstractions/log.service";
 import { StorageService } from "jslib-common/abstractions/storage.service";
-
 import { NodeUtils } from "jslib-common/misc/nodeUtils";
 import { sequentialize } from "jslib-common/misc/sequentialize";
 import { Utils } from "jslib-common/misc/utils";
@@ -66,7 +66,7 @@ export class LowdbStorageService implements StorageService {
         if (fs.existsSync(this.dataFilePath)) {
           const backupPath = this.dataFilePath + ".bak";
           this.logService.warning(`Writing backup of data file to ${backupPath}`);
-          await fs.copyFile(this.dataFilePath, backupPath, (err) => {
+          await fs.copyFile(this.dataFilePath, backupPath, () => {
             this.logService.warning(
               `Error while creating data file backup, "${e.message}". No backup may have been created.`
             );

node/src/services/nodeApi.service.ts

@@ -2,11 +2,10 @@ import * as FormData from "form-data";
 import { HttpsProxyAgent } from "https-proxy-agent";
 import * as fe from "node-fetch";
 
-import { ApiService } from "jslib-common/services/api.service";
-
 import { EnvironmentService } from "jslib-common/abstractions/environment.service";
 import { PlatformUtilsService } from "jslib-common/abstractions/platformUtils.service";
 import { TokenService } from "jslib-common/abstractions/token.service";
+import { ApiService } from "jslib-common/services/api.service";
 
 (global as any).fetch = fe.default;
 (global as any).Request = fe.Request;

node/src/services/nodeCryptoFunction.service.ts

@@ -1,13 +1,12 @@
 import * as crypto from "crypto";
+
 import * as forge from "node-forge";
 
 import { CryptoFunctionService } from "jslib-common/abstractions/cryptoFunction.service";
-
+import { Utils } from "jslib-common/misc/utils";
 import { DecryptParameters } from "jslib-common/models/domain/decryptParameters";
 import { SymmetricCryptoKey } from "jslib-common/models/domain/symmetricCryptoKey";
 
-import { Utils } from "jslib-common/misc/utils";
-
 export class NodeCryptoFunctionService implements CryptoFunctionService {
   pbkdf2(
     password: string | ArrayBuffer,