bitwarden/jslib
1
0
Fork 0
mirror of https://github.com/bitwarden/jslib synced 2025-12-12 14:23:20 +00:00
Code Issues Releases Wiki Activity

Improve URL parsing (#411)

Browse Source 
* Check hostname is valid in getDomain

* fix linting

* Update noop implementation

* Fix tests

* Fix tests
This commit is contained in:
Thomas Rittson
2021-06-23 06:00:14 +10:00
committed by GitHub
parent 18bf616e2e
commit 9ee31ad2fb
3 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
common/src/misc/utils.ts
View File

@@ -221,6 +221,11 @@ export class Utils {
if (httpUrl) {
try {
const url = Utils.getUrlObject(uriString);
const validHostname = tldjs?.isValid != null ? tldjs.isValid(url.hostname) : true;
if (!validHostname) {
return null;
}
if (url.hostname === 'localhost' || Utils.validIpAddress(url.hostname)) {
return url.hostname;
}