bitwarden/jslib
1
0
Fork 0
mirror of https://github.com/bitwarden/jslib synced 2025-12-13 06:43:20 +00:00
Code Issues Releases Wiki Activity

Use rxjs first instead of unsubscribe (#516)

Browse Source
This commit is contained in:
Thomas Rittson
2021-10-14 10:27:52 +10:00
committed by GitHub
parent 28936a113f
commit a20e935268
2 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
angular/src/components/sso.component.ts
View File

@@ -4,6 +4,8 @@ import {
Router,
} from '@angular/router';
import { first } from 'rxjs/operators';
import { ApiService } from 'jslib-common/abstractions/api.service';
import { AuthService } from 'jslib-common/abstractions/auth.service';
import { CryptoFunctionService } from 'jslib-common/abstractions/cryptoFunction.service';
@@ -50,7 +52,7 @@ export class SsoComponent {
protected passwordGenerationService: PasswordGenerationService) { }
async ngOnInit() {
const queryParamsSub = this.route.queryParams.subscribe(async qParams => {
this.route.queryParams.pipe(first()).subscribe(async qParams => {
if (qParams.code != null && qParams.state != null) {
const codeVerifier = await this.storageService.get<string>(ConstantsService.ssoCodeVerifierKey);
const state = await this.storageService.get<string>(ConstantsService.ssoStateKey);
@@ -66,9 +68,6 @@ export class SsoComponent {
this.codeChallenge = qParams.codeChallenge;
this.clientId = qParams.clientId;
}
if (queryParamsSub != null) {
queryParamsSub.unsubscribe();
}
});
}