1
0
mirror of https://github.com/bitwarden/jslib synced 2025-12-23 11:43:51 +00:00
Commit Graph

129 Commits

Author SHA1 Message Date
Thomas Rittson
c8eedc5dd6 Use null coalescing to minimize let statements 2021-12-20 14:54:10 +10:00
Thomas Rittson
71b148c0f8 Assign successCallbacks to named variables 2021-12-20 14:42:16 +10:00
Thomas Rittson
8a94756308 Move method-specific code into successCallback 2021-12-20 14:37:03 +10:00
Thomas Rittson
1f11b7cc3b Run Prettier 2021-12-20 14:20:58 +10:00
Thomas Rittson
54b4154c02 Make authResult.twoFactor a getter 2021-12-20 14:15:53 +10:00
Thomas Rittson
e3c7a79f30 Use more precise type casting instead of any 2021-12-20 12:37:01 +10:00
Thomas Rittson
c2f21e03a9 Add helper methods to authResult 2021-12-20 12:34:57 +10:00
Thomas Rittson
9c22bfd1e8 Move captchaToken to passwordTokenRequest subclass 2021-12-20 12:06:05 +10:00
Thomas Rittson
1b33dbff32 More descriptive arg names for processTokenResponse 2021-12-20 11:51:52 +10:00
Thomas Rittson
358ba67e82 Move api specific stateService calls to entry method 2021-12-20 11:41:46 +10:00
Thomas Rittson
28e98905a0 Move api KC logic into entry method 2021-12-20 11:31:09 +10:00
Thomas Rittson
cfb2ac133a Move existing user KC logic into entry method 2021-12-20 11:29:51 +10:00
Thomas Rittson
49c2d7c5b2 Remove unneeded arg 2021-12-20 11:20:04 +10:00
Thomas Rittson
6e5b267432 Only convert to Key Connector if setCryptoKeys 2021-12-20 11:19:10 +10:00
Thomas Rittson
6227d3a1e9 Move keyConnector onboarding logic to entry method 2021-12-20 11:15:35 +10:00
Thomas Rittson
c8eb559f06 Clean up unused services and imports 2021-12-20 11:05:39 +10:00
Thomas Rittson
a318e267ec Extract completedLogIn logic and fix when it's called 2021-12-20 11:02:37 +10:00
Thomas Rittson
c026265219 Move Key Connector logic into that service 2021-12-20 10:51:20 +10:00
Thomas Rittson
7e9330559b Remove unneeded args 2021-12-20 10:39:12 +10:00
Thomas Rittson
30d3a14524 Move LogIn specific logic to entry method 2021-12-20 10:35:47 +10:00
Thomas Rittson
2551da6592 Make LoginTwoFactor call entry methods
Also fix authingWith* methods
2021-12-20 10:32:58 +10:00
Thomas Rittson
8e633c3604 Fix tokenService calls 2021-12-20 09:37:32 +10:00
Thomas Rittson
e05fd25198 Remove email from processTokenResponse args 2021-12-20 09:29:03 +10:00
Thomas Rittson
be23d022de Fix tokenService interface definition 2021-12-20 09:28:28 +10:00
Thomas Rittson
208e88800b Lift tokenRequest and api call to request methods
Also reduce amount of persistent state (WIP)
2021-12-20 09:20:46 +10:00
Thomas Rittson
bb04c5bf86 Update clients to use new authService interface 2021-12-20 08:01:31 +10:00
Thomas Rittson
8999793882 Deprecate LogIn...Complete methods
Add TwoFactorData to main LogIn methods and handle null instead of
having duplicative methods
2021-12-17 20:32:09 +10:00
Thomas Rittson
33f5ac822d Tweak naming of twoFactorService interface 2021-12-17 20:13:01 +10:00
Thomas Rittson
8b7f20479e Refactor TokenRequest to take TwoFactorData 2021-12-17 18:59:49 +10:00
Thomas Rittson
1acfa54f00 Run prettier in feature branch 2021-12-17 06:09:55 +10:00
Thomas Rittson
44b0d51336 Merge commit '8b2dfc6cdcb8ff5b604364c2ea6d343473aee7cd' into refactor/authService 2021-12-17 06:05:28 +10:00
Thomas Rittson
bd55e6ec81 Break tokenRequest into subclasses 2021-12-16 15:32:44 +10:00
Thomas Rittson
6cb2b91fee Make class properties private 2021-12-16 14:20:44 +10:00
Thomas Rittson
e0f51ccbbc Simpler names for methods 2021-12-16 14:19:26 +10:00
Thomas Rittson
dee5c4bef9 Extract 2FA methods to twoFactorService 2021-12-16 14:13:06 +10:00
Thomas Rittson
73eed7fbbc Refactor parameters on saveState 2021-12-16 12:00:07 +10:00
Thomas Rittson
1606d2a6cb Remove unnecessary null check for setBiometricLocked 2021-12-16 11:55:18 +10:00
Thomas Rittson
30ccb330c6 Extract isNewSsoUser to own method, invert logic 2021-12-16 11:52:27 +10:00
Thomas Rittson
c43bd0e144 Extract createKeyPair to own method 2021-12-16 11:46:28 +10:00
Thomas Rittson
3eba2e67dd Extract convertNewUserToKeyConnector to own method 2021-12-16 11:43:16 +10:00
Thomas Rittson
9ff4a89d54 Extract saveState to own method 2021-12-16 11:37:02 +10:00
Thomas Rittson
897f5565b8 Extract createTokenRequest to new method 2021-12-16 11:29:23 +10:00
Thomas Rittson
5dfdad1a19 Add test: api key happy path 2021-12-16 09:52:12 +10:00
Addison Beck
512c5c2837 [bug] Correct storage location of organizations (#580) 2021-12-14 22:04:39 -05:00
Daniel James Smith
8644d84e68 FSescure-Importer: Add support for style = global (#578)
* Fescure-Importer: Add support for style = global

* Fix linting
2021-12-14 10:22:09 +01:00
Addison Beck
f90b3456d5 [Account Switching] [Feature] Allow clients to store data for more than one user (#491)
* [refactor] Extract, rename, and expand StorageServiceOptions

* Pulled StorageServiceOptions into its own file
* Renamed StorageServiceOptions to StorageOptions
* Pulled KeySuffixOpptions into its own file
* Converted KeySuffixOptions into an enum from a union type

* [refactor] Expand StateService into a full coverage storage proxy

* Expand StateService to allow it to manage all data points of the application state regardless of memory.
* Expand StateService to allow for storing and managing multiple accounts

* [refactor] Create helper services for managing organization and provider state data

* [refactor] Implement StateService across service layer

* Remove service level variables used for in memory data storage and replaced with calls to StateService
* Remove direct calls to StorageService in favor of using StateService as a proxy

* [feature] Implement account switching capable services across components and processes

* Replace calls to StorageService and deprecated services with calls to a StateService

* [chore] Remove unused services

Several services are no longer in use because of the expanded state service. These have simply been removed.

* [bug] Add loginRedirect to the account model

* [bug] Add awaits to newly async calls in TokenService

* [bug] Add several missing awaits

* [bug] Add state service handlers for AutoConfirmFingerprint

* [bug] Move TwoFactorToken to global state

* Update unauth-guard.service.ts

Add back return true

* [refactor] Slim down the boilerplate needed to manage options on StateService calls

* [bug] Allow the lock message handler to manipulate a specific acount

* [bug] Add missing await to auth guard

* [bug] Adjust state scope of several biometric data points

* [bug] Ensure vault locking logic can operate over non-active accounts

* [style] Fix lint complaints

* [bug] Move disableFavicon to global state

* [refactor] Remove an unecassary parameter from a StorageOptions instance

* [bug] Ensure HtmlStorageService paths are accounted for in StateService

* [feature] Add a server url helper to the account model for the account switcher

* [refactor] Remove some unused getters from the account model

* [bug] Ensure locking and logging out can function over any user

* Fix account getting set to null in getAccountFromDisk

* [bug] Ensure lock component is always working with the latest active account in state

* [chore] Update recent KeyConnector changes to use stateService

* [style] Fix lint complaints

* [chore] Resolve TokenService merge issues from KeyConnector

* [bug] Add missing service arguement

* [bug] Correct several default storage option types

* [bug] Check for the right key in hasEncKey

* [bug] Add enableFullWidth to the account model

* [style] Fix lint complaints

* [review] Revist remember email

* [refactor] Remove RememberEmail from state

* setDisableFavicon to correct storage location

* [bug] Convert vault lock loop returns into continues to not skip secondary accounts

* [review] Sorted state service methods

* [bug] Correct neverDomains type on the account model

* [review] Rename stateService.purge to stateService.clean

* [review] [refactor] Extract lock refresh logic to a load function

* [review] [refactor] Extract some timeout logic to dedicated functions

* [review] [refactor] Move AuthenticationStatus to a dedicated file

* [review] [refactor] Rename Globals to GlobalState

* [style] Fix lint complaints

* [review] Remove unused global state property for decodedToken

* [review] [bug] Adjust state scope for OrganizationInvitation

* [review] [bug] Put back the homepage variable in lock guard

* [review] Un-try-catch the window creation function

* Revert "[review] [bug] Adjust state scope for OrganizationInvitation"

This reverts commit caa4574a65.

* [bug] Change || to && in recent vault timeout refactor

* [bug] Keep up with entire state in storage instead of just accounts and globals

Not having access to the last active user was creating issues across clients when restarting the process.
For example: when refreshing the page on web we no longer maintain an understanding of who is logged in.

To resolve this I converted all storage save operations to get and save an entire state object, instead of specifying accounts and globals.
This allows for more flexible saving, like saving activeUserId as a top level storage item.

* [style] Fix lint complaints

* Revert "[bug] Keep up with entire state in storage instead of just accounts and globals"

This reverts commit e8970725be.

* [bug] Initialize GlobalState by default

* [bug] Only get key hash from storage

* [bug] Remove settings storage location overrides

* [bug] Only save accessToken to storage

* [refactor] Remove unecassary argements from electron crypto state calls

* [bug] Ensure keys and tokens load and save to the right locations for web

* [style] Fix lint complaints

* [bug] Remove keySuffix storage option and split uses into unique methods

The keySuffix options don't work with saving serialized json as a storage object - use cases simply overwrite each other in state.
This commit breaks Auto and Biometric keys into distinct storage items and adjusts logic accordingly.

* [bug] Add default vault timeouts to new accounts

* [bug] Save appId as a top level storage item

* [bug] Add missing await to timeout logic

* [bug] Adjust state scope for everBeenUnlocked

* [bug] Clear access tokens when loading account state from disk

* [bug] Adjust theme to be a global state item

* [bug] Adjust null checking for window in state

* [bug] Correct getGlobals not pulling from the stored state item

* [bug] Null check in memory account before claiming it has a userId

* [bug] Scaffold secure storage service when building storage objects on init

* [bug] Adjusted state scope of event collection

* [bug] Adjusted state scope of vault timeout and action

* [bug] Grab account from normal storage if secure storage is requested but does not exist

* [bug] Create a State if one is requested from memory before it exists

* [bug] Ensure all storage locations are cleared on state clean

* [style] Fix lint complaints

* [bug] Remove uneeded clearing of access token

* [bug] Reset tokens when toggling

* [refactor] Split up the Account model

Until this point the account model has been very flat, holding many kinds of data.

In order to be able to prune data at appropriate times, for example clearing keys at logout without clearing QoL settings like locale,
the Account model has been divided into logical chunks.

* [bug] Correct the serverUrl helpers return

* Fix sends always coming back as empty in browser

* Get settings properly (I think)

* [bug] Fix lint error

* [bug] Add missing await to identity token refresh

This was causing weird behavior in web that was creating a lot of 429s

* [bug] Scaffold memory storage for web

Not properly creating storage objects on signin was creating weird behavior when logging out, locking, and logging back in.
Namely, encrypted data that was recently synced had nowhere to save to and was lost.

* [bug] Implement better null handling in a few places for retrieving state

* [bug] Update correct storage locations on account removal

* [bug] Added missing awaits to lock component

* [bug] Reload lock component on account switching vs. account update

* [bug] Store master keys correctly

* [bug] Move some biometrics storage items to global state

* [feature] Add platform helper isMac()

* [refactor] Comment emphasis and call order refresh

* [refactor] Remove unecassary using

* [bug] Relocate authenticationStatus check logic to component

* [bug] Stop not clearing everything on state clean

* [style] Fix lint complaints

* [bug] Correct mismatched uses of encrypted and decrypted pin states

* Add browser specific state classes and methods

* lint fixes

* [bug] Migrate existing persistant data to new schema

* [style] Fix lint complaints

* [bug] Dont clear settings on state clean

* [bug] Maintain the right storage items on logout

* [chore] resolve issues from merge

* [bug] Resolve settings clearing on lock

* [chore] Added a comment

* [review] fromatting for code review

* Revert browser state items

Co-authored-by: Robyn MacCallum <nickersthecat@gmail.com>
Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>
2021-12-13 11:15:16 -05:00
Daniel James Smith
8fc3cf50d2 Bump node to 16 and npm (#575)
* Bump engines required to node 16 and npm 8

* Bump @types/node to 16
The dep on node 14.18 will get cleaned up once we bump electron

* Modify build.yml to build with node 16 and npm 8

* Update requirements in README.md

* Remove install step for npm 8
npm v8.1.2 is included in node v16

* Rename install step

* Fixed typo
2021-12-13 11:43:10 +01:00
Oscar Hinton
6a179ab2df Bump angular to 12. (#571) 2021-12-09 15:00:26 +01:00
Oscar Hinton
a6b95b15e3 Add toastr component (#568) 2021-12-07 19:15:56 +01:00
Matt Gibson
d02fcd082e Add sponsorship pre validate endpoint (#564) 2021-11-24 14:19:03 -06:00