1
0
mirror of https://github.com/bitwarden/jslib synced 2025-12-23 19:53:55 +00:00
Commit Graph

77 Commits

Author SHA1 Message Date
Thomas Rittson
1f11b7cc3b Run Prettier 2021-12-20 14:20:58 +10:00
Thomas Rittson
54b4154c02 Make authResult.twoFactor a getter 2021-12-20 14:15:53 +10:00
Thomas Rittson
c2f21e03a9 Add helper methods to authResult 2021-12-20 12:34:57 +10:00
Thomas Rittson
9c22bfd1e8 Move captchaToken to passwordTokenRequest subclass 2021-12-20 12:06:05 +10:00
Thomas Rittson
358ba67e82 Move api specific stateService calls to entry method 2021-12-20 11:41:46 +10:00
Thomas Rittson
c8eb559f06 Clean up unused services and imports 2021-12-20 11:05:39 +10:00
Thomas Rittson
c026265219 Move Key Connector logic into that service 2021-12-20 10:51:20 +10:00
Thomas Rittson
2551da6592 Make LoginTwoFactor call entry methods
Also fix authingWith* methods
2021-12-20 10:32:58 +10:00
Thomas Rittson
e05fd25198 Remove email from processTokenResponse args 2021-12-20 09:29:03 +10:00
Thomas Rittson
208e88800b Lift tokenRequest and api call to request methods
Also reduce amount of persistent state (WIP)
2021-12-20 09:20:46 +10:00
Thomas Rittson
bb04c5bf86 Update clients to use new authService interface 2021-12-20 08:01:31 +10:00
Thomas Rittson
0e10ee2c50 Add tests for 2FA 2021-12-20 07:48:09 +10:00
Thomas Rittson
8999793882 Deprecate LogIn...Complete methods
Add TwoFactorData to main LogIn methods and handle null instead of
having duplicative methods
2021-12-17 20:32:09 +10:00
Thomas Rittson
8b7f20479e Refactor TokenRequest to take TwoFactorData 2021-12-17 18:59:49 +10:00
Thomas Rittson
1acfa54f00 Run prettier in feature branch 2021-12-17 06:09:55 +10:00
Thomas Rittson
bd55e6ec81 Break tokenRequest into subclasses 2021-12-16 15:32:44 +10:00
Thomas Rittson
dee5c4bef9 Extract 2FA methods to twoFactorService 2021-12-16 14:13:06 +10:00
Thomas Rittson
896e1ef482 Fix linting on tests 2021-12-16 09:55:35 +10:00
Thomas Rittson
5dfdad1a19 Add test: api key happy path 2021-12-16 09:52:12 +10:00
Thomas Rittson
1ec50eb1e8 Add test: do not set keys in new SSO user flow 2021-12-16 09:21:10 +10:00
Thomas Rittson
f0bfc7c68d Fixed broken SSO tests 2021-12-16 09:07:20 +10:00
Thomas Rittson
16b4910aa8 Add test: send 2FA token to server 2021-12-16 08:14:36 +10:00
Thomas Rittson
88e47054fd WIP SSO tests 2021-12-15 14:57:43 +10:00
Thomas Rittson
23cfd1de7f Add test for returning early if 2FA required 2021-12-15 13:15:04 +10:00
Thomas Rittson
e2fd3bd5a9 Add test for making new KeyPair for old account 2021-12-15 12:49:36 +10:00
Thomas Rittson
bfda066bd7 WIP test for Key Connector TODO later 2021-12-15 12:46:35 +10:00
Thomas Rittson
f548402777 Add test for existing keyConnector user 2021-12-15 11:22:15 +10:00
Thomas Rittson
75db9be248 Add test for setCryptoKeys parameter 2021-12-15 11:16:03 +10:00
Thomas Rittson
6e34585dfd Add test for captcha 2021-12-15 11:10:15 +10:00
Thomas Rittson
5e8cc522fb Move common assertions into function 2021-12-15 10:57:46 +10:00
Thomas Rittson
5537d001e1 Move out common variables and setup for re-use 2021-12-15 10:53:18 +10:00
Thomas Rittson
70b743347c Initial test for authService 2021-12-15 10:40:57 +10:00
Daniel James Smith
8644d84e68 FSescure-Importer: Add support for style = global (#578)
* Fescure-Importer: Add support for style = global

* Fix linting
2021-12-14 10:22:09 +01:00
Addison Beck
f90b3456d5 [Account Switching] [Feature] Allow clients to store data for more than one user (#491)
* [refactor] Extract, rename, and expand StorageServiceOptions

* Pulled StorageServiceOptions into its own file
* Renamed StorageServiceOptions to StorageOptions
* Pulled KeySuffixOpptions into its own file
* Converted KeySuffixOptions into an enum from a union type

* [refactor] Expand StateService into a full coverage storage proxy

* Expand StateService to allow it to manage all data points of the application state regardless of memory.
* Expand StateService to allow for storing and managing multiple accounts

* [refactor] Create helper services for managing organization and provider state data

* [refactor] Implement StateService across service layer

* Remove service level variables used for in memory data storage and replaced with calls to StateService
* Remove direct calls to StorageService in favor of using StateService as a proxy

* [feature] Implement account switching capable services across components and processes

* Replace calls to StorageService and deprecated services with calls to a StateService

* [chore] Remove unused services

Several services are no longer in use because of the expanded state service. These have simply been removed.

* [bug] Add loginRedirect to the account model

* [bug] Add awaits to newly async calls in TokenService

* [bug] Add several missing awaits

* [bug] Add state service handlers for AutoConfirmFingerprint

* [bug] Move TwoFactorToken to global state

* Update unauth-guard.service.ts

Add back return true

* [refactor] Slim down the boilerplate needed to manage options on StateService calls

* [bug] Allow the lock message handler to manipulate a specific acount

* [bug] Add missing await to auth guard

* [bug] Adjust state scope of several biometric data points

* [bug] Ensure vault locking logic can operate over non-active accounts

* [style] Fix lint complaints

* [bug] Move disableFavicon to global state

* [refactor] Remove an unecassary parameter from a StorageOptions instance

* [bug] Ensure HtmlStorageService paths are accounted for in StateService

* [feature] Add a server url helper to the account model for the account switcher

* [refactor] Remove some unused getters from the account model

* [bug] Ensure locking and logging out can function over any user

* Fix account getting set to null in getAccountFromDisk

* [bug] Ensure lock component is always working with the latest active account in state

* [chore] Update recent KeyConnector changes to use stateService

* [style] Fix lint complaints

* [chore] Resolve TokenService merge issues from KeyConnector

* [bug] Add missing service arguement

* [bug] Correct several default storage option types

* [bug] Check for the right key in hasEncKey

* [bug] Add enableFullWidth to the account model

* [style] Fix lint complaints

* [review] Revist remember email

* [refactor] Remove RememberEmail from state

* setDisableFavicon to correct storage location

* [bug] Convert vault lock loop returns into continues to not skip secondary accounts

* [review] Sorted state service methods

* [bug] Correct neverDomains type on the account model

* [review] Rename stateService.purge to stateService.clean

* [review] [refactor] Extract lock refresh logic to a load function

* [review] [refactor] Extract some timeout logic to dedicated functions

* [review] [refactor] Move AuthenticationStatus to a dedicated file

* [review] [refactor] Rename Globals to GlobalState

* [style] Fix lint complaints

* [review] Remove unused global state property for decodedToken

* [review] [bug] Adjust state scope for OrganizationInvitation

* [review] [bug] Put back the homepage variable in lock guard

* [review] Un-try-catch the window creation function

* Revert "[review] [bug] Adjust state scope for OrganizationInvitation"

This reverts commit caa4574a65.

* [bug] Change || to && in recent vault timeout refactor

* [bug] Keep up with entire state in storage instead of just accounts and globals

Not having access to the last active user was creating issues across clients when restarting the process.
For example: when refreshing the page on web we no longer maintain an understanding of who is logged in.

To resolve this I converted all storage save operations to get and save an entire state object, instead of specifying accounts and globals.
This allows for more flexible saving, like saving activeUserId as a top level storage item.

* [style] Fix lint complaints

* Revert "[bug] Keep up with entire state in storage instead of just accounts and globals"

This reverts commit e8970725be.

* [bug] Initialize GlobalState by default

* [bug] Only get key hash from storage

* [bug] Remove settings storage location overrides

* [bug] Only save accessToken to storage

* [refactor] Remove unecassary argements from electron crypto state calls

* [bug] Ensure keys and tokens load and save to the right locations for web

* [style] Fix lint complaints

* [bug] Remove keySuffix storage option and split uses into unique methods

The keySuffix options don't work with saving serialized json as a storage object - use cases simply overwrite each other in state.
This commit breaks Auto and Biometric keys into distinct storage items and adjusts logic accordingly.

* [bug] Add default vault timeouts to new accounts

* [bug] Save appId as a top level storage item

* [bug] Add missing await to timeout logic

* [bug] Adjust state scope for everBeenUnlocked

* [bug] Clear access tokens when loading account state from disk

* [bug] Adjust theme to be a global state item

* [bug] Adjust null checking for window in state

* [bug] Correct getGlobals not pulling from the stored state item

* [bug] Null check in memory account before claiming it has a userId

* [bug] Scaffold secure storage service when building storage objects on init

* [bug] Adjusted state scope of event collection

* [bug] Adjusted state scope of vault timeout and action

* [bug] Grab account from normal storage if secure storage is requested but does not exist

* [bug] Create a State if one is requested from memory before it exists

* [bug] Ensure all storage locations are cleared on state clean

* [style] Fix lint complaints

* [bug] Remove uneeded clearing of access token

* [bug] Reset tokens when toggling

* [refactor] Split up the Account model

Until this point the account model has been very flat, holding many kinds of data.

In order to be able to prune data at appropriate times, for example clearing keys at logout without clearing QoL settings like locale,
the Account model has been divided into logical chunks.

* [bug] Correct the serverUrl helpers return

* Fix sends always coming back as empty in browser

* Get settings properly (I think)

* [bug] Fix lint error

* [bug] Add missing await to identity token refresh

This was causing weird behavior in web that was creating a lot of 429s

* [bug] Scaffold memory storage for web

Not properly creating storage objects on signin was creating weird behavior when logging out, locking, and logging back in.
Namely, encrypted data that was recently synced had nowhere to save to and was lost.

* [bug] Implement better null handling in a few places for retrieving state

* [bug] Update correct storage locations on account removal

* [bug] Added missing awaits to lock component

* [bug] Reload lock component on account switching vs. account update

* [bug] Store master keys correctly

* [bug] Move some biometrics storage items to global state

* [feature] Add platform helper isMac()

* [refactor] Comment emphasis and call order refresh

* [refactor] Remove unecassary using

* [bug] Relocate authenticationStatus check logic to component

* [bug] Stop not clearing everything on state clean

* [style] Fix lint complaints

* [bug] Correct mismatched uses of encrypted and decrypted pin states

* Add browser specific state classes and methods

* lint fixes

* [bug] Migrate existing persistant data to new schema

* [style] Fix lint complaints

* [bug] Dont clear settings on state clean

* [bug] Maintain the right storage items on logout

* [chore] resolve issues from merge

* [bug] Resolve settings clearing on lock

* [chore] Added a comment

* [review] fromatting for code review

* Revert browser state items

Co-authored-by: Robyn MacCallum <nickersthecat@gmail.com>
Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>
2021-12-13 11:15:16 -05:00
Oscar Hinton
f09fb69882 Remove empty catch blocks, and update tslint rule (#513) 2021-10-19 10:32:14 +02:00
Oscar Hinton
83548a6753 Remove deprecated index.ts (#490)
* Remove deprecated index.ts

* Update tests
2021-09-17 14:57:31 +02:00
Thomas Rittson
9ee31ad2fb Improve URL parsing (#411)
* Check hostname is valid in getDomain

* fix linting

* Update noop implementation

* Fix tests

* Fix tests
2021-06-23 06:00:14 +10:00
Matt Gibson
ea90aea013 Use encrypted filename filename in Cipher attachment upload blob name (#403)
* Use EncString type to enforce encryption on filename in Cipher attachment upload

* Fix Cipher attachment test
2021-06-08 14:02:08 -05:00
Oscar Hinton
1016bbfb9e Split jslib into multiple modules (#363)
* Split jslib into multiple modules
2021-06-03 18:58:57 +02:00
Thomas Rittson
306aef73d4 Increase error checking on imported Login items (#369)
* Increase error checking on imported Login items

* Check encKey when importing encrypted JSON

* Fix style, use GUID as random string for test

* Revert "Increase error checking on imported Login items"

This reverts commit 1729452786.

* fix linting

* Fix tests
2021-05-13 10:58:59 +10:00
Daniel James Smith
1eb40a4891 Add support to import from Nordpass(.csv) (#360)
* Add support for parsing .csv files from Nordpass

* Remove whitespace before extracting CardExpiration

* Add curlybraces to one-liner if's as requested

* NordPassImporter: Process more complex names
2021-04-29 06:51:35 -04:00
Daniel James Smith
e298ecfee3 Add import of totp from Lastpass (#361)
* Add import of totp from Lastpass

* Fixed import as request during review
2021-04-28 16:50:37 -04:00
Oscar Hinton
aca098645a Bump dependencies (#350)
* Bump dependencies
2021-04-22 21:17:14 +02:00
Matt Gibson
3a1087456f Rename CipherString and CipherArrayBuffer to Enc (#352) 2021-04-20 19:16:19 -05:00
Matt Gibson
0a0cdaa7fd Fix cipher upload (#346)
* Upload correct data array

* Require BufferArray Encryption for upload to server

The CipherArrayBuffer tiny type is only created by CryptoService
and required by all upload methods

* Add test for attachment upload encryption
2021-04-14 10:47:10 -05:00
Tomasz Zdybał
827674847f Skip FirefoxAccounts during Firefox CSV Import (#323)
* Skip FirefoxAccounts during Firefox CSV Import

Firefox exports 'chrome://FirefoxAccounts' if Firefox Accouts are used
in browser. It's quite hacky - password field in CSV is actually a JSON
encoded data, not a password.
Because it's not a useful record, it should be skipped during import.

* Fix indentation

* Move test Firefox test data to files, fix linter errors
2021-04-12 12:08:56 -05:00
Daniel James Smith
c7ac645eb7 Fixes linting error introduced with PR #307 (#309) 2021-03-17 17:14:10 -04:00
Paul Sieben
a36f1c25d8 Enhance SafeInCloud import (#307)
* don't import deleted cards

* keep favourite status while importing from saveInCloud

* import all passwords from saveInCloud

* add test data
2021-03-16 15:06:12 -05:00
Matt Gibson
2730e04a05 Match tslint rules (#264) 2021-02-08 14:11:44 -06:00
Matt Gibson
58f40b0085 Fix glob processing in npm. Ban single param parens (#257) 2021-02-04 09:49:23 -06:00