bitwarden/mobile
1
0
Fork 0
mirror of https://github.com/bitwarden/mobile synced 2026-01-02 00:23:15 +00:00
Code Issues Releases Wiki Activity

PM-3349 PM-3350 Workaround to fix issues with text getting cropped/truncated when a Label has both Multiline and LinebreakMode set

Browse Source
This commit is contained in:
Dinis Vieira
2023-11-26 14:46:30 +00:00
parent 80c424ed03
commit 0a628cc8a8
5 changed files with 51 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/iOS.Core/Handlers/LabelHandlerMappings.cs
View File

@@ -1,4 +1,6 @@
using Bit.App.Controls;
using Microsoft.Maui.Handlers;
using UIKit;
namespace Bit.iOS.Core.Handlers
{
@@ -13,6 +15,23 @@ namespace Bit.iOS.Core.Handlers
handler.PlatformView.AccessibilityIdentifier = customLabel.AutomationId;
}
});
// WORKAROUND: There is an issue causing Multiline Labels that also have a LineBreakMode to not display text properly. (it truncates text on first line even with space available)
// MAUI Github Issue: https://github.com/dotnet/maui/issues/14125 and https://github.com/dotnet/maui/pull/14918
// When this gets fixed by MAUI these two Mapping below can be deleted, same for the UpdateMaxLines, TruncatedMultilineCustomLabel class and the equivalent Mappings on Android
Microsoft.Maui.Handlers.LabelHandler.Mapper.AppendToMapping(nameof(Label.LineBreakMode), UpdateMaxLines);
Microsoft.Maui.Handlers.LabelHandler.Mapper.AppendToMapping(nameof(Label.MaxLines), UpdateMaxLines);
}
private static void UpdateMaxLines(ILabelHandler handler, ILabel label)
{
var textView = handler.PlatformView;
if(label is TruncatedMultilineCustomLabel controlsLabel
&& textView.LineBreakMode == UILineBreakMode.TailTruncation
&& controlsLabel.MaxLines != -1)
{
textView.Lines = controlsLabel.MaxLines;
}
}
}
}