bitwarden/mobile
1
0
Fork 0
mirror of https://github.com/bitwarden/mobile synced 2025-12-05 23:53:33 +00:00
Code Issues Releases Wiki Activity

[PM-5731] feat: check for UV when reprompt is active

Browse Source
This commit is contained in:
Andreas Coroiu
2024-01-19 15:47:06 +01:00
parent 378551e2d5
commit 0dc281edc1
1 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
test/Core.Test/Services/Fido2AuthenticatorTests.cs
View File

@@ -182,17 +182,27 @@ namespace Bit.Core.Test.Services
await Assert.ThrowsAsync<NotAllowedError>(() => sutProvider.Sut.GetAssertionAsync(aParams)); await Assert.ThrowsAsync<NotAllowedError>(() => sutProvider.Sut.GetAssertionAsync(aParams));
} }
// it("should throw error if user verification fails and cipher requires reprompt", async () => { [Theory]
// ciphers[0].reprompt = CipherRepromptType.Password; [InlineCustomAutoData(new[] { typeof(SutProviderCustomization) })]
// userInterfaceSession.pickCredential.mockResolvedValue({ // Spec: If the user does not consent, return an error code equivalent to "NotAllowedError" and terminate the operation.
// cipherId: ciphers[0].id, public async Task GetAssertionAsync_ThrowsNotAllowed_NoUserVerificationForCipherWithReprompt(SutProvider<Fido2AuthenticatorService> sutProvider, Fido2AuthenticatorGetAssertionParams aParams) {
// userVerified: false, var credentialIds = new[] { Guid.NewGuid(), Guid.NewGuid() };
// }); List<CipherView> ciphers = [
CreateCipherView(credentialIds[0].ToString(), "bitwarden.com", false),
CreateCipherView(credentialIds[1].ToString(), "bitwarden.com", true)
];
ciphers[0].Reprompt = CipherRepromptType.Password;
var discoverableCiphers = ciphers.Where((cipher) => cipher.Login.MainFido2Credential.IsDiscoverable).ToList();
aParams.RpId = "bitwarden.com";
aParams.AllowCredentialDescriptorList = null;
sutProvider.GetDependency<ICipherService>().GetAllDecryptedAsync().Returns(ciphers);
sutProvider.GetDependency<IFido2UserInterface>().PickCredentialAsync(Arg.Any<Fido2PickCredentialParams>()).Returns(new Fido2PickCredentialResult {
CipherId = ciphers[0].Id,
UserVerified = false
});
// const result = async () => await authenticator.getAssertion(params, tab); await Assert.ThrowsAsync<NotAllowedError>(() => sutProvider.Sut.GetAssertionAsync(aParams));
}
// await expect(result).rejects.toThrowError(Fido2AuthenticatorErrorCode.NotAllowed);
// });
#endregion #endregion