bitwarden/mobile
1
0
Fork 0
mirror of https://github.com/bitwarden/mobile synced 2026-01-07 02:53:56 +00:00
Code Issues Releases Wiki Activity

PM-3350 Fixed/Updated all MAUI-Migration TODOs

Browse Source
This commit is contained in:
Federico Maccaroni
2023-11-20 13:10:03 -03:00
parent 16ada4993c
commit 1a0b52d644
15 changed files with 51 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Core/Controls/AccountViewCell/AccountViewCell.xaml
View File

@@ -11,10 +11,10 @@
<Grid RowSpacing="0"
ColumnSpacing="0">
<Grid.Behaviors>
<!--TODO: [MAUI-Migration] Currently using a "copied" implementation from the github issue in the link until they add this to the Community Toolkit ( https://github.com/CommunityToolkit/Maui/issues/86 ) -->
<!--TODO: [TouchEffect] Currently using a "copied" implementation from the github issue in the link until they add this to the Community Toolkit ( https://github.com/CommunityToolkit/Maui/issues/86 ) -->
<behaviors:TouchBehavior NativeAnimation="True"
LongPressCommand="{Binding LongPressAccountCommand, Source={x:Reference _accountView}}"
LongPressCommandParameter="{Binding .BindingContext, Source={x:Reference _accountView}}" />
LongPressCommandParameter="{Binding BindingContext, Source={x:Reference _accountView}}" />
</Grid.Behaviors>
<Grid.GestureRecognizers>
<TapGestureRecognizer Command="{Binding SelectAccountCommand, Source={x:Reference _accountView}}" CommandParameter="{Binding .}" />

2
src/Core/Controls/AvatarImageSource.cs
View File

@@ -48,7 +48,7 @@ namespace Bit.App.Controls
private Task<Stream> GetStreamAsync(CancellationToken userToken = new CancellationToken())
{
// TODO: [MAUI-Migration] [Critical] now methods are private protected so cannot be used here, figure out workaround
// TODO: [MAUI-Avatar] now methods are private protected so cannot be used here, figure out workaround
//OnLoadingStarted();
//userToken.Register(CancellationTokenSource.Cancel);
var result = Draw();

15
src/Core/Controls/ExtendedGrid.cs
View File

@@ -6,16 +6,15 @@ namespace Bit.App.Controls
{
public ExtendedGrid()
{
#if ANDROID
// Add Android Ripple effect. Eventually we should be able to replace this with the Maui Community Toolkit implementation. (https://github.com/CommunityToolkit/Maui/issues/86)
// [MAUI-Migration] When this TouchBehavior is replaced we can delete the existing TouchBehavior support files (which is all the files and folders inside "Core.Behaviors.PlatformBehaviors.MCTTouch.*")
if (DeviceInfo.Platform == DevicePlatform.Android)
// TODO: [TouchEffect] When this TouchBehavior is replaced we can delete the existing TouchBehavior support files (which is all the files and folders inside "Core.Behaviors.PlatformBehaviors.MCTTouch.*")
var touchBehavior = new TouchBehavior()
{
var touchBehavior = new TouchBehavior()
{
NativeAnimation = true
};
Behaviors.Add(touchBehavior);
}
NativeAnimation = true
};
Behaviors.Add(touchBehavior);
#endif
}
}
}

15
src/Core/Controls/ExtendedStackLayout.cs
View File

@@ -6,16 +6,15 @@ namespace Bit.App.Controls
{
public ExtendedStackLayout()
{
#if ANDROID
// Add Android Ripple effect. Eventually we should be able to replace this with the Maui Community Toolkit implementation. (https://github.com/CommunityToolkit/Maui/issues/86)
// [MAUI-Migration] When this TouchBehavior is replaced we can delete the existing TouchBehavior support files (which is all the files and folders inside "Core.Behaviors.PlatformBehaviors.MCTTouch.*")
if (DeviceInfo.Platform == DevicePlatform.Android)
// TODO: [TouchEffect] When this TouchBehavior is replaced we can delete the existing TouchBehavior support files (which is all the files and folders inside "Core.Behaviors.PlatformBehaviors.MCTTouch.*")
var touchBehavior = new TouchBehavior()
{
var touchBehavior = new TouchBehavior()
{
NativeAnimation = true
};
Behaviors.Add(touchBehavior);
}
NativeAnimation = true
};
Behaviors.Add(touchBehavior);
#endif
}
}
}