From 24547e67bfa6966d7ff1d02b588082a1277536dd Mon Sep 17 00:00:00 2001 From: Kyle Spearrin Date: Mon, 1 Jun 2020 14:46:37 -0400 Subject: [PATCH] check for empty string on malformed URL (#944) * treat empty string host as null * use `string.IsNullOrEmpty` --- src/Core/Utilities/CoreHelpers.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Core/Utilities/CoreHelpers.cs b/src/Core/Utilities/CoreHelpers.cs index 1951b6f6c..c4b1c7f78 100644 --- a/src/Core/Utilities/CoreHelpers.cs +++ b/src/Core/Utilities/CoreHelpers.cs @@ -36,13 +36,14 @@ namespace Bit.Core.Utilities public static string GetHostname(string uriString) { - return GetUri(uriString)?.Host; + var uri = GetUri(uriString); + return string.IsNullOrEmpty(uri?.Host) ? null : uri.Host; } public static string GetHost(string uriString) { var uri = GetUri(uriString); - if (uri != null) + if (!string.IsNullOrEmpty(uri?.Host)) { if (uri.IsDefaultPort) {