From 446b8c2d3559430c514d516de11e7f5261ca5eb9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Bispo?= <abispo@bitwarden.com>
Date: Tue, 8 Aug 2023 20:15:14 +0100
Subject: [PATCH] [PM-2289] Change header title based on auth request type
 (#2670)

* [PM-2289] Change header title based on auth request type
---
 .../LoginPasswordlessRequestPage.xaml         |  4 +-
 .../LoginPasswordlessRequestViewModel.cs      | 40 ++++++++++++++-----
 src/App/Resources/AppResources.Designer.cs    |  9 +++++
 src/App/Resources/AppResources.resx           |  3 ++
 4 files changed, 43 insertions(+), 13 deletions(-)

diff --git a/src/App/Pages/Accounts/LoginPasswordlessRequestPage.xaml b/src/App/Pages/Accounts/LoginPasswordlessRequestPage.xaml
index 305da4319..f7cac07af 100644
--- a/src/App/Pages/Accounts/LoginPasswordlessRequestPage.xaml
+++ b/src/App/Pages/Accounts/LoginPasswordlessRequestPage.xaml
@@ -21,13 +21,13 @@
         <StackLayout
             Padding="7, 0, 7, 20">
             <Label
-                Text="{Binding Tittle}"
+                Text="{Binding Title}"
                 FontSize="Title"
                 FontAttributes="Bold"
                 Margin="0,14,0,21"
                 AutomationId="LogInInitiatedLabel" />
             <Label
-                Text="{Binding SubTittle}"
+                Text="{Binding SubTitle}"
                 FontSize="Small"
                 Margin="0,0,0,10"/>
             <Label
diff --git a/src/App/Pages/Accounts/LoginPasswordlessRequestViewModel.cs b/src/App/Pages/Accounts/LoginPasswordlessRequestViewModel.cs
index 89faa3553..f9fd48de0 100644
--- a/src/App/Pages/Accounts/LoginPasswordlessRequestViewModel.cs
+++ b/src/App/Pages/Accounts/LoginPasswordlessRequestViewModel.cs
@@ -67,8 +67,6 @@ namespace Bit.App.Pages
             _cryptoFunctionService = ServiceContainer.Resolve<ICryptoFunctionService>();
             _cryptoService = ServiceContainer.Resolve<ICryptoService>();
 
-            PageTitle = AppResources.LogInInitiated;
-
             CreatePasswordlessLoginCommand = new AsyncCommand(CreatePasswordlessLoginAsync,
                 onException: ex => HandleException(ex),
                 allowsMultipleExecutions: false);
@@ -86,7 +84,23 @@ namespace Bit.App.Pages
         public ICommand CreatePasswordlessLoginCommand { get; }
         public ICommand CloseCommand { get; }
 
-        public string Tittle
+        public string HeaderTitle
+        {
+            get
+            {
+                switch (_authRequestType)
+                {
+                    case AuthRequestType.AuthenticateAndUnlock:
+                        return AppResources.LogInWithDevice;
+                    case AuthRequestType.AdminApproval:
+                        return AppResources.LogInInitiated;
+                    default:
+                        return string.Empty;
+                };
+            }
+        }
+
+        public string Title
         {
             get
             {
@@ -102,7 +116,7 @@ namespace Bit.App.Pages
             }
         }
 
-        public string SubTittle
+        public string SubTitle
         {
             get
             {
@@ -165,14 +179,18 @@ namespace Bit.App.Pages
         public AuthRequestType AuthRequestType
         {
             get => _authRequestType;
-            set => SetProperty(ref _authRequestType, value, additionalPropertyNames: new string[]
+            set
             {
-                nameof(Tittle),
-                nameof(SubTittle),
-                nameof(Description),
-                nameof(OtherOptions),
-                nameof(ResendNotificationVisible)
-            });
+                SetProperty(ref _authRequestType, value, additionalPropertyNames: new string[]
+                {
+                    nameof(Title),
+                    nameof(SubTitle),
+                    nameof(Description),
+                    nameof(OtherOptions),
+                    nameof(ResendNotificationVisible)
+                });
+                PageTitle = HeaderTitle;
+            }
         }
 
         public bool ResendNotificationVisible => AuthRequestType == AuthRequestType.AuthenticateAndUnlock;
diff --git a/src/App/Resources/AppResources.Designer.cs b/src/App/Resources/AppResources.Designer.cs
index 308a146ee..2dfb1ed8a 100644
--- a/src/App/Resources/AppResources.Designer.cs
+++ b/src/App/Resources/AppResources.Designer.cs
@@ -3930,6 +3930,15 @@ namespace Bit.App.Resources {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Log in with device.
+        /// </summary>
+        public static string LogInWithDevice {
+            get {
+                return ResourceManager.GetString("LogInWithDevice", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Log in with device must be set up in the settings of the Bitwarden app. Need another option?.
         /// </summary>
diff --git a/src/App/Resources/AppResources.resx b/src/App/Resources/AppResources.resx
index ef128b045..cf45fcb10 100644
--- a/src/App/Resources/AppResources.resx
+++ b/src/App/Resources/AppResources.resx
@@ -2756,4 +2756,7 @@ Do you want to switch to this account?</value>
   <data name="LogInWithDeviceMustBeSetUpInTheSettingsOfTheBitwardenAppNeedAnotherOption" xml:space="preserve">
     <value>Log in with device must be set up in the settings of the Bitwarden app. Need another option?</value>
   </data>
+  <data name="LogInWithDevice" xml:space="preserve">
+    <value>Log in with device</value>
+  </data>
 </root>