bitwarden/mobile
1
0
Fork 0
mirror of https://github.com/bitwarden/mobile synced 2025-12-22 11:13:49 +00:00
Code Issues Releases Wiki Activity

PM-3349 PM-3350 Improved code safety with try...catch, better invoke on main thread and better null handling.

Browse Source
This commit is contained in:
Federico Maccaroni
2024-01-19 15:01:31 -03:00
parent 01ee1ff845
commit 4717f5e230
21 changed files with 612 additions and 377 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/Core/Pages/Accounts/TwoFactorPage.xaml.cs
View File

@@ -2,6 +2,7 @@
using Bit.App.Models;
using Bit.App.Utilities;
using Bit.Core.Abstractions;
using Bit.Core.Services;
using Bit.Core.Utilities;
namespace Bit.App.Pages
@@ -63,11 +64,11 @@ namespace Bit.App.Pages
if (_vm.YubikeyMethod && !string.IsNullOrWhiteSpace(token) &&
token.Length == 44 && !token.Contains(" "))
{
MainThread.BeginInvokeOnMainThread(async () =>
MainThread.BeginInvokeOnMainThread(() =>
{
_vm.Token = token;
await _vm.SubmitAsync();
});
_vm.SubmitCommand.Execute(null);
}
}
else if (message.Command == "resumeYubiKey")
@@ -124,12 +125,9 @@ namespace Bit.App.Pages
return base.OnBackButtonPressed();
}
private async void Continue_Clicked(object sender, EventArgs e)
private void Continue_Clicked(object sender, EventArgs e)
{
if (DoOnce())
{
await _vm.SubmitAsync();
}
_vm.SubmitCommand.Execute(null);
}
private async void Methods_Clicked(object sender, EventArgs e)
@@ -158,17 +156,24 @@ namespace Bit.App.Pages
private async void TryAgain_Clicked(object sender, EventArgs e)
{
if (DoOnce())
try
{
if (_vm.Fido2Method)
if (DoOnce())
{
await _vm.Fido2AuthenticateAsync();
}
else if (_vm.YubikeyMethod)
{
_messagingService.Send("listenYubiKeyOTP", true);
if (_vm.Fido2Method)
{
await _vm.Fido2AuthenticateAsync();
}
else if (_vm.YubikeyMethod)
{
_messagingService.Send("listenYubiKeyOTP", true);
}
}
}
catch (Exception ex)
{
LoggerHelper.LogEvenIfCantBeResolved(ex);
}
}
private async Task StartSetPasswordAsync()