bitwarden/mobile
1
0
Fork 0
mirror of https://github.com/bitwarden/mobile synced 2025-12-21 18:53:29 +00:00
Code Issues Releases Wiki Activity

[PM-7385] Fix for allowing switching accounts while creating a passkey of Android (#3155)

Browse Source 
* PM-7385 Fixed for allowing switching accounts while creating a passkey on Android.
This fixes also include scenarios where we need to unlock the vault after switching
Also fixed the issue where tapping on cipher won't do anything after switching.

* PM-7385 ensure the Options.Fido2CredentialAction and FromFido2Framework are reset when the Credential flow is started to avoid erratic behaviors when switching accounts, app is in background or other edge case scenarios.
These properties where replaced by calls to _fido2MakeCredentialConfirmationUserInterface.IsConfirmingNewCredential instead.

* Minor changes and added comments

* [PM-7385] Implemented several changes suggested in PR for better/cleaner code.

* PM-7385 Added several minor code improvemments.
This commit is contained in:
Dinis Vieira
2024-04-16 21:52:52 +01:00
committed by GitHub
parent f596f31ffa
commit 5a4a54f4af
11 changed files with 110 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/App/Platforms/Android/Services/DeviceActionService.cs
View File

@@ -583,7 +583,11 @@ namespace Bit.Droid.Services
await ExecuteFido2CreateCredentialAsync();
}
appOptions.Fido2CredentialAction = null; //Clear CredentialAction Value
// Clear CredentialAction and FromFido2Framework values to avoid erratic behaviors in subsequent navigation/flows
// For Fido2CredentialGet these are no longer needed as a new Activity will be initiated.
// For Fido2CredentialCreate the app will rely on IFido2MakeCredentialConfirmationUserInterface.IsConfirmingNewCredential
appOptions.Fido2CredentialAction = null;
appOptions.FromFido2Framework = false;
}
private async Task ExecuteFido2GetCredentialAsync(AppOptions appOptions)