Improve Theming (#1707)

* Improved theming logic and performance, also fixed some issues regarding changing the theme after vault timeout and fixed theme applying on password generator/history

* Removed messenger from theme update, and now the navigation stack is traversed and each IThemeDirtablePage gets theme updated

* Improved code on update theme on pages

src/App/Pages/Generator/GeneratorHistoryPage.xaml.cs

@@ -1,10 +1,12 @@
-using Bit.App.Resources;
-using System;
+using System;
+using System.Threading.Tasks;
+using Bit.App.Resources;
+using Bit.App.Styles;
 using Xamarin.Forms;
 
 namespace Bit.App.Pages
 {
-    public partial class GeneratorHistoryPage : BaseContentPage
+    public partial class GeneratorHistoryPage : BaseContentPage, IThemeDirtablePage
     {
         private GeneratorHistoryPageViewModel _vm;
 
@@ -28,6 +30,7 @@ namespace Bit.App.Pages
         protected override async void OnAppearing()
         {
             base.OnAppearing();
+
             await LoadOnAppearedAsync(_mainLayout, true, async () => {
                 await _vm.InitAsync();
             });
@@ -59,5 +62,12 @@ namespace Bit.App.Pages
                 await _vm.ClearAsync();
             }
         }
+
+        public override async Task UpdateOnThemeChanged()
+        {
+            await base.UpdateOnThemeChanged();
+
+            await _vm?.UpdateOnThemeChanged();
+        }
     }
 }

src/App/Pages/Generator/GeneratorHistoryPageViewModel.cs

@@ -1,9 +1,12 @@
-using Bit.App.Resources;
+using System.Collections.Generic;
+using System.Threading.Tasks;
+using Bit.App.Resources;
 using Bit.Core.Abstractions;
 using Bit.Core.Models.Domain;
 using Bit.Core.Utilities;
-using System.Collections.Generic;
-using System.Threading.Tasks;
+#if !FDROID
+using Microsoft.AppCenter.Crashes;
+#endif
 using Xamarin.Forms;
 
 namespace Bit.App.Pages
@@ -19,8 +22,7 @@ namespace Bit.App.Pages
         public GeneratorHistoryPageViewModel()
         {
             _platformUtilsService = ServiceContainer.Resolve<IPlatformUtilsService>("platformUtilsService");
-            _passwordGenerationService = ServiceContainer.Resolve<IPasswordGenerationService>(
-                "passwordGenerationService");
+            _passwordGenerationService = ServiceContainer.Resolve<IPasswordGenerationService>("passwordGenerationService");
             _clipboardService = ServiceContainer.Resolve<IClipboardService>("clipboardService");
 
             PageTitle = AppResources.PasswordHistory;
@@ -57,5 +59,21 @@ namespace Bit.App.Pages
             _platformUtilsService.ShowToast("info", null,
                 string.Format(AppResources.ValueHasBeenCopied, AppResources.Password));
         }
+
+        public async Task UpdateOnThemeChanged()
+        {
+            try
+            {
+                await Device.InvokeOnMainThreadAsync(() => History.ResetWithRange(new List<GeneratedPasswordHistory>()));
+
+                await InitAsync();
+            }
+            catch (System.Exception ex)
+            {
+#if !FDROID
+                Crashes.TrackError(ex);
+#endif
+            }
+        }
     }
 }

src/App/Pages/Generator/GeneratorPage.xaml

@@ -63,6 +63,7 @@
                     </Frame>
                 </Grid>
                 <controls:MonoLabel
+                    x:Name="lblPassword"
                     StyleClass="text-lg, text-html"
                     Text="{Binding ColoredPassword, Mode=OneWay}"
                     Margin="0, 20"

src/App/Pages/Generator/GeneratorPage.xaml.cs

@@ -1,15 +1,15 @@
-using Bit.App.Resources;
-using System;
+using System;
 using System.Threading.Tasks;
+using Bit.App.Resources;
+using Bit.App.Styles;
 using Bit.Core.Abstractions;
 using Bit.Core.Utilities;
 using Xamarin.Forms;
-using Xamarin.Forms.PlatformConfiguration;
 using Xamarin.Forms.PlatformConfiguration.iOSSpecific;
 
 namespace Bit.App.Pages
 {
-    public partial class GeneratorPage : BaseContentPage
+    public partial class GeneratorPage : BaseContentPage, IThemeDirtablePage
     {
         private readonly IBroadcasterService _broadcasterService;
         
@@ -49,7 +49,7 @@ namespace Bit.App.Pages
             }
             if (isIos)
             {
-                _typePicker.On<iOS>().SetUpdateMode(UpdateMode.WhenFinished);
+                _typePicker.On<Xamarin.Forms.PlatformConfiguration.iOS>().SetUpdateMode(UpdateMode.WhenFinished);
             }
         }
 
@@ -61,18 +61,19 @@ namespace Bit.App.Pages
         protected async override void OnAppearing()
         {
             base.OnAppearing();
+
+            lblPassword.IsVisible = true;
+
             if (!_fromTabPage)
             {
                 await InitAsync();
             }
-            _broadcasterService.Subscribe(nameof(GeneratorPage), async (message) =>
+
+            _broadcasterService.Subscribe(nameof(GeneratorPage), (message) =>
             {
                 if (message.Command == "updatedTheme")
                 {
-                    Device.BeginInvokeOnMainThread(() =>
-                    {
-                        _vm.RedrawPassword();
-                    });
+                    Device.BeginInvokeOnMainThread(() => _vm.RedrawPassword());
                 }
             });
         }
@@ -80,6 +81,9 @@ namespace Bit.App.Pages
         protected override void OnDisappearing()
         {
             base.OnDisappearing();
+
+            lblPassword.IsVisible = false;
+
             _broadcasterService.Unsubscribe(nameof(GeneratorPage));
         }
 
@@ -141,5 +145,12 @@ namespace Bit.App.Pages
                 await Navigation.PopModalAsync();
             }
         }
+
+        public override async Task UpdateOnThemeChanged()
+        {
+            await base.UpdateOnThemeChanged();
+
+            await Device.InvokeOnMainThreadAsync(() => _vm?.RedrawPassword());
+        }
     }
 }