bitwarden/mobile
1
0
Fork 0
mirror of https://github.com/bitwarden/mobile synced 2025-12-12 14:23:26 +00:00
Code Issues Releases Wiki Activity

Remove userid from Ga service, not being used

Browse Source
This commit is contained in:
Kyle Spearrin
2017-04-19 21:05:03 -04:00
parent a960ccd786
commit 8e29a990cb
8 changed files with 5 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/Android/Services/GoogleAnalyticsService.cs
View File

@@ -9,8 +9,6 @@ namespace Bit.Android.Services
{
public class GoogleAnalyticsService : IGoogleAnalyticsService
{
private const string UserId = "&uid";
private readonly GoogleAnalytics _instance;
private readonly IAuthService _authService;
private readonly Tracker _tracker;
@@ -33,16 +31,10 @@ namespace Bit.Android.Services
_tracker.EnableAutoActivityTracking(true);
_tracker.SetClientId(appIdService.AnonymousAppId);
var gaOptOut = settings.GetValueOrDefault(Constants.SettingGAOptOut, false);
var gaOptOut = settings.GetValueOrDefault(Constants.SettingGaOptOut, false);
SetAppOptOut(gaOptOut);
}
public void RefreshUserId()
{
_tracker.Set(UserId, null);
_setUserId = true;
}
public void TrackAppEvent(string eventName, string label = null)
{
TrackEvent("App", eventName, label);
@@ -63,7 +55,6 @@ namespace Bit.Android.Services
builder.SetLabel(label);
}
SetUserId();
_tracker.Send(builder.Build());
}
@@ -73,26 +64,15 @@ namespace Bit.Android.Services
builder.SetDescription(message);
builder.SetFatal(fatal);
SetUserId();
_tracker.Send(builder.Build());
}
public void TrackPage(string pageName)
{
SetUserId();
_tracker.SetScreenName(pageName);
_tracker.Send(new HitBuilders.ScreenViewBuilder().Build());
}
private void SetUserId()
{
if(_setUserId && _authService.IsAuthenticated)
{
_tracker.Set(UserId, _authService.UserId);
_setUserId = false;
}
}
public void Dispatch(Action completionHandler = null)
{
_instance.DispatchLocalHits();