bitwarden/mobile
1
0
Fork 0
mirror of https://github.com/bitwarden/mobile synced 2025-12-15 15:53:44 +00:00
Code Issues Releases Wiki Activity

remove re-throws of exceptions, hiding stack trace (#1680)

Browse Source 
* remove re-throws of exceptions, hiding stack trace

* revert to catch all ApiExceptions

* add back throw in auditService

* whitespace
This commit is contained in:
Jake Fink
2021-12-16 15:34:33 -05:00
committed by GitHub
parent adb8bb4f1b
commit ad3b401ed3
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Core/Services/AuditService.cs
View File

@@ -55,7 +55,7 @@ namespace Bit.Core.Services
{
return new List<BreachAccountResponse>();
}
throw e;
throw;
}
}
}

2
src/Core/Services/AuthService.cs
View File

@@ -272,7 +272,7 @@ namespace Bit.Core.Services
{
if (e.Error == null || e.Error.StatusCode != System.Net.HttpStatusCode.NotFound)
{
throw e;
throw;
}
}
return await _cryptoService.MakeKeyAsync(masterPassword, email, kdf, kdfIterations);

2
src/Core/Services/CipherService.cs
View File

@@ -732,7 +732,7 @@ namespace Bit.Core.Services
catch (ApiException e)
{
await DeleteAttachmentAsync(id, attachmentId);
throw e;
throw;
}
}

4
src/Core/Services/SendService.cs
View File

@@ -219,12 +219,12 @@ namespace Bit.Core.Services
{
response = await LegacyServerSendFileUpload(request, send, encryptedFileData);
}
catch (Exception e)
catch
{
if (response != default){
await _apiService.DeleteSendAsync(response.Id);
}
throw e;
throw;
}
break;
default: