From e0c721098c838ccfb875d6d1b203e1c5932729fd Mon Sep 17 00:00:00 2001 From: Dinis Vieira Date: Thu, 9 Nov 2023 23:01:04 +0000 Subject: [PATCH] PM-3349 PM-3350 Migrated remaining AutomationProperties to SemanticProperties. All 'IsInAccessibleTree="True"' were deleted. 'IsInAccessibleTree="False"' were kept and stayed in code. --- .../AuthenticatorViewCell.xaml | 1 - .../CipherViewCell/CipherViewCell.xaml | 3 -- .../Controls/DateTime/DateTimePicker.xaml | 6 +-- .../Controls/DateTime/DateTimePicker.xaml.cs | 4 +- src/Core/Controls/ExternalLinkItemView.xaml | 1 - .../Controls/SendViewCell/SendViewCell.xaml | 6 --- .../BooleanCustomFieldItemLayout.xaml | 1 - .../HiddenCustomFieldItemLayout.xaml | 4 -- .../LinkedCustomFieldItemLayout.xaml | 1 - .../TextCustomFieldItemLayout.xaml | 3 -- src/Core/Pages/Accounts/HomePage.xaml | 1 - src/Core/Pages/Accounts/LockPage.xaml | 8 +--- src/Core/Pages/Accounts/LoginPage.xaml | 5 +-- src/Core/Pages/Accounts/RegisterPage.xaml | 6 +-- src/Core/Pages/Accounts/SetPasswordPage.xaml | 6 +-- src/Core/Pages/Accounts/TwoFactorPage.xaml | 1 - .../Accounts/UpdateTempPasswordPage.xaml | 9 ++--- .../Pages/Accounts/VerificationCodePage.xaml | 1 - .../Pages/Generator/GeneratorHistoryPage.xaml | 2 - src/Core/Pages/Generator/GeneratorPage.xaml | 16 +------- src/Core/Pages/Send/SendAddEditPage.xaml | 17 ++------ .../Pages/Send/SendAddOnlyOptionsView.xaml | 5 +-- src/Core/Pages/Send/SendAddOnlyPage.xaml | 1 - .../SendGroupingsPage/SendGroupingsPage.xaml | 4 -- .../Pages/Settings/AboutSettingsPage.xaml | 1 - .../Pages/Settings/BlockAutofillUrisPage.xaml | 3 -- src/Core/Pages/Settings/ExportVaultPage.xaml | 3 +- .../Pages/Settings/FolderAddEditPage.xaml | 1 - src/Core/Pages/Settings/FoldersPage.xaml | 2 - .../LoginPasswordlessRequestsListPage.xaml | 1 - .../Pages/Settings/SecuritySettingsPage.xaml | 1 - src/Core/Pages/Vault/AttachmentsPage.xaml | 1 - src/Core/Pages/Vault/CipherAddEditPage.xaml | 39 +------------------ src/Core/Pages/Vault/CipherDetailsPage.xaml | 16 +------- src/Core/Pages/Vault/CipherSelectionPage.xaml | 3 -- src/Core/Pages/Vault/CiphersPage.xaml | 3 -- .../Vault/GroupingsPage/GroupingsPage.xaml | 6 --- src/Core/Pages/Vault/PasswordHistoryPage.xaml | 1 - 38 files changed, 22 insertions(+), 171 deletions(-) diff --git a/src/Core/Controls/AuthenticatorViewCell/AuthenticatorViewCell.xaml b/src/Core/Controls/AuthenticatorViewCell/AuthenticatorViewCell.xaml index 9f16b28ef..70b21fc50 100644 --- a/src/Core/Controls/AuthenticatorViewCell/AuthenticatorViewCell.xaml +++ b/src/Core/Controls/AuthenticatorViewCell/AuthenticatorViewCell.xaml @@ -122,6 +122,5 @@ Padding="0,0,1,0" HorizontalOptions="Center" VerticalOptions="Center" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{u:I18n CopyTotp}" /> \ No newline at end of file diff --git a/src/Core/Controls/CipherViewCell/CipherViewCell.xaml b/src/Core/Controls/CipherViewCell/CipherViewCell.xaml index 2a4347fe3..d86a61f39 100644 --- a/src/Core/Controls/CipherViewCell/CipherViewCell.xaml +++ b/src/Core/Controls/CipherViewCell/CipherViewCell.xaml @@ -95,7 +95,6 @@ Margin="5, 0, 0, 0" Text="{Binding Source={x:Static core:BitwardenIcons.Collection}}" IsVisible="{Binding Cipher.Shared, Mode=OneTime}" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{u:I18n Shared}" AutomationId="CipherInCollectionIcon" /> @@ -120,7 +118,6 @@ Clicked="MoreButton_Clicked" VerticalOptions="CenterAndExpand" HorizontalOptions="EndAndExpand" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{u:I18n Options}" AutomationId="CipherOptionsButton" /> diff --git a/src/Core/Controls/DateTime/DateTimePicker.xaml b/src/Core/Controls/DateTime/DateTimePicker.xaml index 173016526..bdb4e00d5 100644 --- a/src/Core/Controls/DateTime/DateTimePicker.xaml +++ b/src/Core/Controls/DateTime/DateTimePicker.xaml @@ -10,12 +10,10 @@ x:Name="_datePicker" Grid.Column="0" NullableDate="{Binding Date, Mode=TwoWay}" - Format="d" - AutomationProperties.IsInAccessibleTree="True" /> + Format="d" /> + Format="t" /> diff --git a/src/Core/Controls/DateTime/DateTimePicker.xaml.cs b/src/Core/Controls/DateTime/DateTimePicker.xaml.cs index 889156c57..caca95865 100644 --- a/src/Core/Controls/DateTime/DateTimePicker.xaml.cs +++ b/src/Core/Controls/DateTime/DateTimePicker.xaml.cs @@ -18,8 +18,8 @@ namespace Bit.App.Controls && BindingContext is DateTimeViewModel dateTimeViewModel) { - AutomationProperties.SetName(_datePicker, dateTimeViewModel.DateName); - AutomationProperties.SetName(_timePicker, dateTimeViewModel.TimeName); + SemanticProperties.SetDescription(_datePicker, dateTimeViewModel.DateName); + SemanticProperties.SetDescription(_timePicker, dateTimeViewModel.TimeName); _datePicker.PlaceHolder = dateTimeViewModel.DatePlaceholder; _timePicker.PlaceHolder = dateTimeViewModel.TimePlaceholder; diff --git a/src/Core/Controls/ExternalLinkItemView.xaml b/src/Core/Controls/ExternalLinkItemView.xaml index fe2d93410..8a4252eea 100644 --- a/src/Core/Controls/ExternalLinkItemView.xaml +++ b/src/Core/Controls/ExternalLinkItemView.xaml @@ -21,7 +21,6 @@ TextColor="{DynamicResource TextColor}" HorizontalOptions="End" VerticalOptions="Center" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{Binding Title, Mode=OneWay, Source={x:Reference _contentView}}" /> diff --git a/src/Core/Controls/SendViewCell/SendViewCell.xaml b/src/Core/Controls/SendViewCell/SendViewCell.xaml index 5379c0282..6a55a918d 100644 --- a/src/Core/Controls/SendViewCell/SendViewCell.xaml +++ b/src/Core/Controls/SendViewCell/SendViewCell.xaml @@ -73,7 +73,6 @@ Margin="5, 0, 0, 0" Text="{Binding Source={x:Static core:BitwardenIcons.ExclamationTriangle}}" IsVisible="{Binding Send.Disabled, Mode=OneTime}" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{u:I18n Disabled}" AutomationId="DisabledSendLabel" /> @@ -135,7 +130,6 @@ Clicked="MoreButton_Clicked" VerticalOptions="CenterAndExpand" HorizontalOptions="EndAndExpand" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{u:I18n Options}" AutomationId="SendOptionsButton" /> diff --git a/src/Core/Lists/ItemLayouts/CustomFields/BooleanCustomFieldItemLayout.xaml b/src/Core/Lists/ItemLayouts/CustomFields/BooleanCustomFieldItemLayout.xaml index 27a57a487..e24800905 100644 --- a/src/Core/Lists/ItemLayouts/CustomFields/BooleanCustomFieldItemLayout.xaml +++ b/src/Core/Lists/ItemLayouts/CustomFields/BooleanCustomFieldItemLayout.xaml @@ -67,7 +67,6 @@ Grid.Row="0" Grid.Column="2" Grid.RowSpan="2" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{u:I18n Options}" /> diff --git a/src/Core/Lists/ItemLayouts/CustomFields/HiddenCustomFieldItemLayout.xaml b/src/Core/Lists/ItemLayouts/CustomFields/HiddenCustomFieldItemLayout.xaml index 47cf279c9..d1da7f176 100644 --- a/src/Core/Lists/ItemLayouts/CustomFields/HiddenCustomFieldItemLayout.xaml +++ b/src/Core/Lists/ItemLayouts/CustomFields/HiddenCustomFieldItemLayout.xaml @@ -57,7 +57,6 @@ IsEnabled="{Binding ShowViewHidden}" IsSpellCheckEnabled="False" IsTextPredictionEnabled="False" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{Binding Field.Name}" AutomationId="HiddenCustomFieldValueEntry"> @@ -76,7 +75,6 @@ Grid.Row="0" Grid.Column="1" Grid.RowSpan="2" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{u:I18n ToggleVisibility}" AutomationId="HiddenCustomFieldShowValueButton" /> diff --git a/src/Core/Lists/ItemLayouts/CustomFields/LinkedCustomFieldItemLayout.xaml b/src/Core/Lists/ItemLayouts/CustomFields/LinkedCustomFieldItemLayout.xaml index 084d0f0d2..ed00b0be3 100644 --- a/src/Core/Lists/ItemLayouts/CustomFields/LinkedCustomFieldItemLayout.xaml +++ b/src/Core/Lists/ItemLayouts/CustomFields/LinkedCustomFieldItemLayout.xaml @@ -57,7 +57,6 @@ Grid.Row="0" Grid.Column="1" Grid.RowSpan="2" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{u:I18n Options}" AutomationId="LinkedCustomFieldOptionsButton" /> diff --git a/src/Core/Lists/ItemLayouts/CustomFields/TextCustomFieldItemLayout.xaml b/src/Core/Lists/ItemLayouts/CustomFields/TextCustomFieldItemLayout.xaml index 8ad28a14e..2b668fb7f 100644 --- a/src/Core/Lists/ItemLayouts/CustomFields/TextCustomFieldItemLayout.xaml +++ b/src/Core/Lists/ItemLayouts/CustomFields/TextCustomFieldItemLayout.xaml @@ -44,7 +44,6 @@ Grid.Row="1" Grid.Column="0" IsVisible="{Binding IsEditing}" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{Binding Field.Name}" AutomationId="TextCustomFieldValueEntry" /> diff --git a/src/Core/Pages/Accounts/HomePage.xaml b/src/Core/Pages/Accounts/HomePage.xaml index 371118940..f149cc2ba 100644 --- a/src/Core/Pages/Accounts/HomePage.xaml +++ b/src/Core/Pages/Accounts/HomePage.xaml @@ -22,7 +22,6 @@ Order="Primary" Priority="-1" UseOriginalImage="True" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{u:I18n Account}" AutomationId="AccountIconButton" /> diff --git a/src/Core/Pages/Accounts/LockPage.xaml b/src/Core/Pages/Accounts/LockPage.xaml index 22459163b..6460303de 100644 --- a/src/Core/Pages/Accounts/LockPage.xaml +++ b/src/Core/Pages/Accounts/LockPage.xaml @@ -23,7 +23,6 @@ Order="Primary" Priority="-1" UseOriginalImage="True" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{u:I18n Account}" AutomationId="AccountIconButton" /> @@ -33,7 +32,6 @@ diff --git a/src/Core/Pages/Accounts/LoginPage.xaml b/src/Core/Pages/Accounts/LoginPage.xaml index eafaef3d0..97963cdcd 100644 --- a/src/Core/Pages/Accounts/LoginPage.xaml +++ b/src/Core/Pages/Accounts/LoginPage.xaml @@ -24,7 +24,6 @@ Order="Primary" Priority="-1" UseOriginalImage="True" - AutomationProperties.IsInAccessibleTree="True" SemanticProperties.Description="{u:I18n Account}" AutomationId="AccountIconButton" /> @@ -34,7 +33,6 @@ + SemanticProperties.Hint="{Binding PasswordVisibilityAccessibilityText}"/>