From 3127295444648f310521639f696ee790cedab00b Mon Sep 17 00:00:00 2001 From: Matt Portune <59324545+mportune-bw@users.noreply.github.com> Date: Mon, 14 Feb 2022 11:29:04 -0500 Subject: [PATCH 1/2] Fix for vault timeout not firing on resume (#1775) * fix for vault timeout not firing on resume * call ResumedAsync with FireAndForget --- src/App/App.xaml.cs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/App/App.xaml.cs b/src/App/App.xaml.cs index e75f711dc..44c6531f8 100644 --- a/src/App/App.xaml.cs +++ b/src/App/App.xaml.cs @@ -97,7 +97,7 @@ namespace Bit.App { if (Device.RuntimePlatform == Device.iOS) { - ResumedAsync(); + ResumedAsync().FireAndForget(); } } else if (message.Command == "slept") @@ -205,7 +205,7 @@ namespace Bit.App _isResumed = true; if (Device.RuntimePlatform == Device.Android) { - ResumedAsync(); + ResumedAsync().FireAndForget(); } } @@ -215,12 +215,11 @@ namespace Bit.App _messagingService.Send("stopEventTimer"); } - private async void ResumedAsync() + private async Task ResumedAsync() { - await UpdateThemeAsync(); - await _vaultTimeoutService.CheckVaultTimeoutAsync(); _messagingService.Send("startEventTimer"); + await UpdateThemeAsync(); await ClearCacheIfNeededAsync(); Prime(); SyncIfNeeded(); From 4fb811ae877a294c23aea26715ce770201d39394 Mon Sep 17 00:00:00 2001 From: Federico Maccaroni Date: Mon, 14 Feb 2022 16:06:35 -0300 Subject: [PATCH 2/2] Build: Upload dSYMs to AppCenter (#1776) * Added dsym artifact to be uploaded alongside with the ipa o the build.yml * Added dsym artifact to be uploaded alongside with the ipa o the build.yml * Fixed build.yml dsym artifact * Fix upload dsym build.yml * Fix build.yml to check what gets exported and after this will become the adjustment for the dsym (disabling Android build for this test) * Fix build.yml to copy all dsyms and artifact them (disabling Android build for this test) * Fix build.yml to only copy all dsyms and ipa and artifact them (disabling Android build for this test) * Added Appcenterr CLI and upload missing symbols for dSYM to the build * Add secret to build workflow (#1771) * Changed build.yml upload dsym command from upload-missing-symbols to upload-symbols * Added restrictions for uploading iOS symbols to AppCenter on build.yml Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com> --- .github/workflows/build.yml | 53 ++++++++++++++++++++++++++++++++++--- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7578e3849..7d8d2475c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -366,6 +366,18 @@ jobs: - name: Checkout repo uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4 + - name: Login to Azure - Prod Subscription + uses: Azure/login@77f1b2e3fb80c0e8645114159d17008b8a2e475a + with: + creds: ${{ secrets.AZURE_PROD_KV_CREDENTIALS }} + + - name: Retrieve secrets + id: retrieve-secrets + uses: Azure/get-keyvault-secrets@80ccd3fafe5662407cc2e55f202ee34bfff8c403 + with: + keyvault: "bitwarden-prod-kv" + secrets: "appcenter-ios-token" + - name: Decrypt secrets env: DECRYPT_FILE_PASSWORD: ${{ secrets.DECRYPT_FILE_PASSWORD }} @@ -479,13 +491,48 @@ jobs: -exportOptionsPlist $EXPORT_OPTIONS_PATH shell: bash - - name: Upload App Store .ipa artifact + - name: Copy all dSYMs files to upload + run: | + ARCHIVE_DSYMS_PATH="$HOME/Library/Developer/Xcode/Archives/*/*.xcarchive/dSYMs" + EXPORT_PATH="./bitwarden-export" + + cp -r $ARCHIVE_DSYMS_PATH $EXPORT_PATH + shell: bash + + - name: Upload App Store .ipa & dSYMs artifacts uses: actions/upload-artifact@ee69f02b3dfdecd58bb31b4d133da38ba6fe3700 # v2.2.4 with: - name: Bitwarden.ipa - path: ./bitwarden-export/Bitwarden.ipa + name: Bitwarden iOS + path: | + ./bitwarden-export/Bitwarden.ipa + ./bitwarden-export/dSYMs/*.* if-no-files-found: error + - name: Install AppCenter CLI + if: | + (github.ref == 'refs/heads/master' + && needs.setup.outputs.rc_branch_exists == 0 + && needs.setup.outputs.hotfix_branch_exists == 0) + || (github.ref == 'refs/heads/rc' && needs.setup.outputs.hotfix_branch_exists == 0) + || github.ref == 'refs/heads/hotfix' + uses: actions/setup-node@v2 + with: + node-version: '14' + - run: npm install -g appcenter-cli + + - name: Upload dSYMs to App Center + if: | + (github.ref == 'refs/heads/master' + && needs.setup.outputs.rc_branch_exists == 0 + && needs.setup.outputs.hotfix_branch_exists == 0) + || (github.ref == 'refs/heads/rc' && needs.setup.outputs.hotfix_branch_exists == 0) + || github.ref == 'refs/heads/hotfix' + env: + APPCENTER_IOS_TOKEN: ${{ steps.retrieve-secrets.outputs.appcenter-ios-token }} + run: | + appcenter crashes upload-symbols -a kspearrin/bitwarden -s "./bitwarden-export/dSYMs" --token $APPCENTER_IOS_TOKEN + shell: bash + - name: Deploy to App Store if: | (github.ref == 'refs/heads/master'