bitwarden/mobile
1
0
Fork 0
mirror of https://github.com/bitwarden/mobile synced 2025-12-17 00:33:20 +00:00
Code Issues Releases Wiki Activity

[PM-6848] Improved User verification on passkeys creation (#3099)

Browse Source 
* PM-6848 Updated cancellation flow on passkey user verification and improved UV enforcement on creation

* PM-6848 Added null checks to help diagnosing if NRE is presented
This commit is contained in:
Federico Maccaroni
2024-03-21 13:28:14 -03:00
committed by GitHub
parent 6bec0ede05
commit ebc068d820
15 changed files with 202 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/iOS.Autofill/CredentialProviderViewController.Passkeys.cs
View File

@@ -264,7 +264,7 @@ namespace Bit.iOS.Autofill
var encrypted = await _cipherService.Value.GetAsync(selectedCipherId);
var cipher = await encrypted.DecryptAsync();
return await _userVerificationMediatorService.Value.VerifyUserForFido2Async(
var cResult = await _userVerificationMediatorService.Value.VerifyUserForFido2Async(
new Fido2UserVerificationOptions(
cipher?.Reprompt == Bit.Core.Enums.CipherRepromptType.Password,
userVerificationPreference,
@@ -285,8 +285,10 @@ namespace Bit.iOS.Autofill
_platformUtilsService.Value.ShowToast(null, null, AppResources.VerifyingIdentityEllipsis);
await _conditionedAwaiterManager.Value.GetAwaiterForPrecondition(AwaiterPrecondition.AutofillIOSExtensionViewDidAppear);
})
);
}
)
);
return !cResult.IsCancelled && cResult.Result;
}
catch (InvalidOperationNeedsUIException)
{