bitwarden/mobile
1
0
Fork 0
mirror of https://github.com/bitwarden/mobile synced 2025-12-16 16:23:29 +00:00
Code Issues Releases Wiki Activity

added viewable checks on autofill for iOS

Browse Source
This commit is contained in:
Kyle Spearrin
2016-11-11 22:43:15 -05:00
parent 4b819bbcc4
commit feb484dc9f
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/iOS.Extension/Models/FillScript.cs
View File

@@ -19,7 +19,7 @@ namespace Bit.iOS.Extension.Models
List<PageDetails.Field> usernames = new List<PageDetails.Field>(); List<PageDetails.Field> usernames = new List<PageDetails.Field>();
List<PageDetails.Field> passwords = new List<PageDetails.Field>(); List<PageDetails.Field> passwords = new List<PageDetails.Field>();
var passwordFields = pageDetails.Fields.Where(f => f.Type == "password").ToArray(); var passwordFields = pageDetails.Fields.Where(f => f.Type == "password" && f.Viewable).ToArray();
foreach(var form in pageDetails.Forms) foreach(var form in pageDetails.Forms)
{ {
var passwordFieldsForForm = passwordFields.Where(f => f.Form == form.Key).ToArray(); var passwordFieldsForForm = passwordFields.Where(f => f.Form == form.Key).ToArray();
@@ -32,7 +32,7 @@ namespace Bit.iOS.Extension.Models
foreach(var pf in passwordFieldsForForm) foreach(var pf in passwordFieldsForForm)
{ {
var username = pageDetails.Fields.LastOrDefault(f => f.Form == pf.Form var username = pageDetails.Fields.LastOrDefault(f => f.Form == pf.Form && f.Viewable
&& f.ElementNumber < pf.ElementNumber && (f.Type == "text" || f.Type == "email" || f.Type == "tel")); && f.ElementNumber < pf.ElementNumber && (f.Type == "text" || f.Type == "email" || f.Type == "tel"));
if(username != null) if(username != null)
{ {
@@ -51,7 +51,7 @@ namespace Bit.iOS.Extension.Models
if(!string.IsNullOrWhiteSpace(fillUsername) && pf.ElementNumber > 0) if(!string.IsNullOrWhiteSpace(fillUsername) && pf.ElementNumber > 0)
{ {
var username = pageDetails.Fields.LastOrDefault(f => f.ElementNumber < pf.ElementNumber var username = pageDetails.Fields.LastOrDefault(f => f.ElementNumber < pf.ElementNumber && f.Viewable
&& (f.Type == "text" || f.Type == "email" || f.Type == "tel")); && (f.Type == "text" || f.Type == "email" || f.Type == "tel"));
if(username != null) if(username != null)
{ {