From 02447fbfb7735477e41c80274530a2edaace3c33 Mon Sep 17 00:00:00 2001 From: Ike Kottlowski Date: Wed, 21 Jan 2026 10:10:45 -0500 Subject: [PATCH] chore: rename grantee list variable to be emails not names --- .../Mail/EmergencyAccessRemoveGranteesMailView.cs | 5 +++-- .../EmergencyAccess/EmergencyAccessMailTests.cs | 12 ++++++------ 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/Core/Auth/UserFeatures/EmergencyAccess/Mail/EmergencyAccessRemoveGranteesMailView.cs b/src/Core/Auth/UserFeatures/EmergencyAccess/Mail/EmergencyAccessRemoveGranteesMailView.cs index 4d60556785..52106a089f 100644 --- a/src/Core/Auth/UserFeatures/EmergencyAccess/Mail/EmergencyAccessRemoveGranteesMailView.cs +++ b/src/Core/Auth/UserFeatures/EmergencyAccess/Mail/EmergencyAccessRemoveGranteesMailView.cs @@ -4,8 +4,9 @@ namespace Bit.Core.Auth.UserFeatures.EmergencyAccess.Mail; public class EmergencyAccessRemoveGranteesMailView : BaseMailView { - public required IEnumerable RemovedGranteeNames { get; set; } - public string EmergencyAccessHelpPageUrl => "https://bitwarden.com/help/emergency-access/"; + + public required IEnumerable RemovedGranteeEmails { get; set; } + public static string EmergencyAccessHelpPageUrl => "https://bitwarden.com/help/emergency-access/"; } public class EmergencyAccessRemoveGranteesMail : BaseMail diff --git a/test/Core.Test/Auth/UserFeatures/EmergencyAccess/EmergencyAccessMailTests.cs b/test/Core.Test/Auth/UserFeatures/EmergencyAccess/EmergencyAccessMailTests.cs index 8cb6c2c2fe..0a64c59d58 100644 --- a/test/Core.Test/Auth/UserFeatures/EmergencyAccess/EmergencyAccessMailTests.cs +++ b/test/Core.Test/Auth/UserFeatures/EmergencyAccess/EmergencyAccessMailTests.cs @@ -41,7 +41,7 @@ public class EmergencyAccessMailTests ToEmails = [grantorEmail], View = new EmergencyAccessRemoveGranteesMailView { - RemovedGranteeNames = [granteeName] + RemovedGranteeEmails = [granteeName] } }; @@ -84,7 +84,7 @@ public class EmergencyAccessMailTests ToEmails = [grantorEmail], View = new EmergencyAccessRemoveGranteesMailView { - RemovedGranteeNames = granteeNames + RemovedGranteeEmails = granteeNames } }; @@ -119,14 +119,14 @@ public class EmergencyAccessMailTests View = new EmergencyAccessRemoveGranteesMailView { // Required: at least one removed grantee name - RemovedGranteeNames = ["Example Grantee"] + RemovedGranteeEmails = ["Example Grantee"] } }; // Assert Assert.NotNull(mail); Assert.NotNull(mail.View); - Assert.NotEmpty(mail.View.RemovedGranteeNames); + Assert.NotEmpty(mail.View.RemovedGranteeEmails); } /// @@ -141,13 +141,13 @@ public class EmergencyAccessMailTests var mail = new EmergencyAccessRemoveGranteesMail { ToEmails = [grantorEmail], - View = new EmergencyAccessRemoveGranteesMailView { RemovedGranteeNames = [granteeName] } + View = new EmergencyAccessRemoveGranteesMailView { RemovedGranteeEmails = [granteeName] } }; // Assert Assert.NotNull(mail); Assert.NotNull(mail.View); Assert.Equal(_emergencyAccessMailSubject, mail.Subject); - Assert.Equal(_emergencyAccessHelpUrl, mail.View.EmergencyAccessHelpPageUrl); + Assert.Equal(_emergencyAccessHelpUrl, EmergencyAccessRemoveGranteesMailView.EmergencyAccessHelpPageUrl); } }