1
0
mirror of https://github.com/bitwarden/server synced 2025-12-16 16:23:31 +00:00

Update tests

This commit is contained in:
Bernd Schoolmann
2025-12-03 13:14:34 +01:00
parent 4c0cabbd6b
commit 25c0bcef69

View File

@@ -7,32 +7,12 @@ using Bit.Core.KeyManagement.Repositories;
using Bit.Core.Repositories; using Bit.Core.Repositories;
using Bit.Test.Common.AutoFixture.Attributes; using Bit.Test.Common.AutoFixture.Attributes;
using NSubstitute; using NSubstitute;
using NSubstitute.ReturnsExtensions;
using Xunit; using Xunit;
namespace Bit.Core.Test.KeyManagement.Commands; namespace Bit.Core.Test.KeyManagement.Commands;
public class SetAccountKeysForUserCommandTests public class SetAccountKeysForUserCommandTests
{ {
[Theory]
[BitAutoData]
public async Task SetAccountKeysForUserAsync_UserNotFound_ThrowsArgumentExceptionAsync(
Guid userId,
AccountKeysRequestModel accountKeys)
{
var userRepository = Substitute.For<IUserRepository>();
var userSignatureKeyPairRepository = Substitute.For<IUserSignatureKeyPairRepository>();
var command = new SetAccountKeysForUserCommand(userRepository, userSignatureKeyPairRepository);
userRepository.GetByIdAsync(userId).ReturnsNullForAnyArgs();
var exception = await Assert.ThrowsAsync<ArgumentException>(() =>
command.SetAccountKeysForUserAsync(userId, accountKeys));
Assert.Equal("userId", exception.ParamName);
Assert.Contains("User not found", exception.Message);
}
[Theory] [Theory]
[BitAutoData] [BitAutoData]
public async Task SetAccountKeysForUserAsync_WithV1Keys_UpdatesUserCorrectlyAsync( public async Task SetAccountKeysForUserAsync_WithV1Keys_UpdatesUserCorrectlyAsync(
@@ -52,9 +32,7 @@ public class SetAccountKeysForUserCommandTests
var userSignatureKeyPairRepository = Substitute.For<IUserSignatureKeyPairRepository>(); var userSignatureKeyPairRepository = Substitute.For<IUserSignatureKeyPairRepository>();
var command = new SetAccountKeysForUserCommand(userRepository, userSignatureKeyPairRepository); var command = new SetAccountKeysForUserCommand(userRepository, userSignatureKeyPairRepository);
userRepository.GetByIdAsync(user.Id).Returns(user); await command.SetAccountKeysForUserAsync(user, accountKeys);
await command.SetAccountKeysForUserAsync(user.Id, accountKeys);
Assert.Equal(accountKeys.UserKeyEncryptedAccountPrivateKey, user.PrivateKey); Assert.Equal(accountKeys.UserKeyEncryptedAccountPrivateKey, user.PrivateKey);
Assert.Equal(accountKeys.AccountPublicKey, user.PublicKey); Assert.Equal(accountKeys.AccountPublicKey, user.PublicKey);
@@ -68,7 +46,7 @@ public class SetAccountKeysForUserCommandTests
await userSignatureKeyPairRepository await userSignatureKeyPairRepository
.DidNotReceiveWithAnyArgs() .DidNotReceiveWithAnyArgs()
.UpsertAsync(Arg.Any<UserSignatureKeyPair>()); .CreateAsync(Arg.Any<UserSignatureKeyPair>());
} }
[Theory] [Theory]
@@ -109,9 +87,7 @@ public class SetAccountKeysForUserCommandTests
var userSignatureKeyPairRepository = Substitute.For<IUserSignatureKeyPairRepository>(); var userSignatureKeyPairRepository = Substitute.For<IUserSignatureKeyPairRepository>();
var command = new SetAccountKeysForUserCommand(userRepository, userSignatureKeyPairRepository); var command = new SetAccountKeysForUserCommand(userRepository, userSignatureKeyPairRepository);
userRepository.GetByIdAsync(user.Id).Returns(user); await command.SetAccountKeysForUserAsync(user, accountKeys);
await command.SetAccountKeysForUserAsync(user.Id, accountKeys);
Assert.Equal(publicKeyEncryptionKeyPair.WrappedPrivateKey, user.PrivateKey); Assert.Equal(publicKeyEncryptionKeyPair.WrappedPrivateKey, user.PrivateKey);
Assert.Equal(publicKeyEncryptionKeyPair.PublicKey, user.PublicKey); Assert.Equal(publicKeyEncryptionKeyPair.PublicKey, user.PublicKey);
@@ -125,7 +101,7 @@ public class SetAccountKeysForUserCommandTests
await userSignatureKeyPairRepository await userSignatureKeyPairRepository
.Received(1) .Received(1)
.UpsertAsync(Arg.Is<UserSignatureKeyPair>(pair => .CreateAsync(Arg.Is<UserSignatureKeyPair>(pair =>
pair.UserId == user.Id && pair.UserId == user.Id &&
pair.SignatureAlgorithm == SignatureAlgorithm.Ed25519 && pair.SignatureAlgorithm == SignatureAlgorithm.Ed25519 &&
pair.SigningKey == signatureKeyPair.WrappedSigningKey && pair.SigningKey == signatureKeyPair.WrappedSigningKey &&