From 2bf848720bd2b5b462294c09357daf226b28474f Mon Sep 17 00:00:00 2001 From: Thomas Rittson Date: Thu, 1 Jan 2026 15:31:47 +1000 Subject: [PATCH] local code review feedback --- .../Repositories/CollectionRepository.cs | 2 +- .../2025-12-30_02_PopulateDefaultCollectionSemaphore.sql | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/Infrastructure.Dapper/Repositories/CollectionRepository.cs b/src/Infrastructure.Dapper/Repositories/CollectionRepository.cs index 001efe07ba..9a14612e14 100644 --- a/src/Infrastructure.Dapper/Repositories/CollectionRepository.cs +++ b/src/Infrastructure.Dapper/Repositories/CollectionRepository.cs @@ -453,7 +453,7 @@ public class CollectionRepository : Repository, ICollectionRep .OrderBy(s => s.OrganizationUserId) .ToList(); - using var bulkCopy = new SqlBulkCopy(connection, SqlBulkCopyOptions.KeepIdentity & SqlBulkCopyOptions.CheckConstraints, transaction); + using var bulkCopy = new SqlBulkCopy(connection, SqlBulkCopyOptions.KeepIdentity | SqlBulkCopyOptions.CheckConstraints, transaction); bulkCopy.DestinationTableName = "[dbo].[DefaultCollectionSemaphore]"; bulkCopy.BatchSize = 500; bulkCopy.BulkCopyTimeout = 120; diff --git a/util/Migrator/DbScripts/2025-12-30_02_PopulateDefaultCollectionSemaphore.sql b/util/Migrator/DbScripts/2025-12-30_02_PopulateDefaultCollectionSemaphore.sql index 488377f0df..b8518b0eba 100644 --- a/util/Migrator/DbScripts/2025-12-30_02_PopulateDefaultCollectionSemaphore.sql +++ b/util/Migrator/DbScripts/2025-12-30_02_PopulateDefaultCollectionSemaphore.sql @@ -2,14 +2,12 @@ -- This migration is idempotent and can be run multiple times safely INSERT INTO [dbo].[DefaultCollectionSemaphore] ( - [OrganizationId], [OrganizationUserId], [CreationDate] ) SELECT DISTINCT - c.[OrganizationId], cu.[OrganizationUserId], - c.[CreationDate] + GETUTCDATE() FROM [dbo].[Collection] c INNER JOIN @@ -23,7 +21,6 @@ WHERE FROM [dbo].[DefaultCollectionSemaphore] dcs WHERE - dcs.[OrganizationId] = c.[OrganizationId] - AND dcs.[OrganizationUserId] = cu.[OrganizationUserId] + dcs.[OrganizationUserId] = cu.[OrganizationUserId] ); GO