bitwarden/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server synced 2026-01-06 18:43:36 +00:00
Code Issues Releases Wiki Activity

feat(OTP): [PM-18612] Change email OTP to six digits

Browse Source 
* Change email OTP to 6 digits

* Added comment on base class

* Added tests

* Renamed tests.

* Fixed tests

* Renamed file to match class
This commit is contained in:
Todd Martin
2025-07-14 10:23:30 -04:00
committed by GitHub
parent 9b65e9f4cc
commit 2f8460f4db
8 changed files with 144 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
test/Core.Test/Auth/Identity/EmailTwoFactorTokenProviderTests.cs
View File

@@ -1,13 +1,15 @@
using Bit.Core.Auth.Enums;
using Bit.Core.Auth.Identity.TokenProviders;
using Bit.Core.Entities;
using Bit.Core.Services;
using Bit.Test.Common.AutoFixture;
using Bit.Test.Common.AutoFixture.Attributes;
using NSubstitute;
using Xunit;
namespace Bit.Core.Test.Auth.Identity;
public class EmailTwoFactorTokenProviderTests : BaseTokenProviderTests<EmailTwoFactorTokenProvider>
public class EmailTwoFactorTokenProviderTests : BaseTwoFactorTokenProviderTests<EmailTwoFactorTokenProvider>
{
public override TwoFactorProviderType TwoFactorProviderType => TwoFactorProviderType.Email;
@@ -42,4 +44,48 @@ public class EmailTwoFactorTokenProviderTests : BaseTokenProviderTests<EmailTwoF
{
await base.RunCanGenerateTwoFactorTokenAsync(metaData, expectedResponse, user, sutProvider);
}
[Theory]
[BitAutoData]
public async Task GenerateAsync_ShouldReturnSixDigitToken_WithFeatureFlagEnabled(
User user, SutProvider<EmailTwoFactorTokenProvider> sutProvider)
{
// Arrange
user.TwoFactorProviders = GetTwoFactorEmailProvidersJson();
sutProvider.GetDependency<IFeatureService>()
.IsEnabled(FeatureFlagKeys.Otp6Digits)
.Returns(true);
// Act
var token = await sutProvider.Sut.GenerateAsync("purpose", SubstituteUserManager(), user);
// Assert
Assert.NotNull(token);
Assert.Equal(6, token.Length);
}
[Theory]
[BitAutoData]
public async Task GenerateAsync_ShouldReturnSixDigitToken_WithFeatureFlagDisabled(
User user, SutProvider<EmailTwoFactorTokenProvider> sutProvider)
{
// Arrange
user.TwoFactorProviders = GetTwoFactorEmailProvidersJson();
sutProvider.GetDependency<IFeatureService>()
.IsEnabled(FeatureFlagKeys.Otp6Digits)
.Returns(false);
// Act
var token = await sutProvider.Sut.GenerateAsync("purpose", SubstituteUserManager(), user);
// Assert
Assert.NotNull(token);
Assert.Equal(6, token.Length);
}
private string GetTwoFactorEmailProvidersJson()
{
return
"{\"1\":{\"Enabled\":true,\"MetaData\":{\"Email\":\"test@email.com\"}}}";
}
}